Attachment 27618 Details for Bug 109940 – Proposed fix

[patch] Proposed fix

patch_109940.txt (text/plain), 1.58 KB, created by Olivier Thomann

on 2005-09-28 11:24:06 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2005-09-28 11:24:06 EDT

Size: 1.58 KB

patch

obsolete

>Index: CharacterLiteral.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/CharacterLiteral.java,v
>retrieving revision 1.31
>diff -u -r1.31 CharacterLiteral.java
>--- CharacterLiteral.java	4 Apr 2005 17:35:08 -0000	1.31
>+++ CharacterLiteral.java	28 Sep 2005 15:23:49 -0000
>@@ -265,22 +265,21 @@
> 								throw new IllegalArgumentException("illegal character literal");//$NON-NLS-1$
> 							}
> 							number = (number * 8) + Character.getNumericValue(nextChar);
>-						}
>-						nextChar = (char) scanner.getNextChar();
>-						if (nextChar == -1) {
>-							throw new IllegalArgumentException("illegal character literal");//$NON-NLS-1$
>-						}
>-						if (nextChar != '\'') {
>-							if (!Character.isDigit(nextChar)) {
>+							nextChar = (char) scanner.getNextChar();
>+							if (nextChar == -1) {
> 								throw new IllegalArgumentException("illegal character literal");//$NON-NLS-1$
> 							}
>-							number = (number * 8) + Character.getNumericValue(nextChar);
>+							if (nextChar != '\'') {
>+								if (!Character.isDigit(nextChar)) {
>+									throw new IllegalArgumentException("illegal character literal");//$NON-NLS-1$
>+								}
>+								number = (number * 8) + Character.getNumericValue(nextChar);
>+							}
> 						}
>-						value = (char) number;
>+						return (char) number;				
> 					} else {
> 						throw new IllegalArgumentException("illegal character literal");//$NON-NLS-1$
> 					}
>-					break;
> 			}
> 			nextChar = (char) scanner.getNextChar();
> 			if (nextChar == -1) {

Actions: View | Diff

Attachments on bug 109940: 27319 | 27618 | 27619