Attachment 267900 Details for Bug 502833 – Proposal fix - Git patch

[patch] Proposal fix - Git patch

Bug-502833-Dragging-bendpoints-endpoints-crashes-Eclipse (text/plain), 1.08 KB, created by Fanch Bonnabesse

on 2017-04-21 04:48:29 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fanch Bonnabesse

Created: 2017-04-21 04:48:29 EDT

Size: 1.08 KB

patch

obsolete

>diff --git a/org.eclipse.draw2d/src/org/eclipse/draw2d/DeferredUpdateManager.java b/org.eclipse.draw2d/src/org/eclipse/draw2d/DeferredUpdateManager.java
>index 664ef26..c422fd7 100644
>--- a/org.eclipse.draw2d/src/org/eclipse/draw2d/DeferredUpdateManager.java
>+++ b/org.eclipse.draw2d/src/org/eclipse/draw2d/DeferredUpdateManager.java
>@@ -21,7 +21,7 @@
> import org.eclipse.swt.graphics.GC;
> import org.eclipse.swt.widgets.Display;
> 
>-import org.eclipse.draw2d.geometry.Rectangle;
>+import geometry.Rectangle;
> 
> /**
>  * An UpdateManager that asynchronously updates the affected figures.
>@@ -215,11 +215,14 @@
> 			IFigure fig;
> 			validating = true;
> 			fireValidating();
>-			for (int i = 0; i < invalidFigures.size(); i++) {
>-				fig = (IFigure) invalidFigures.get(i);
>-				invalidFigures.set(i, null);
>+			List invalidFiguresCopy = new ArrayList(invalidFigures);
>+			for (int i = 0; i < invalidFiguresCopy.size(); i++) {
>+				fig = (IFigure) invalidFiguresCopy.get(i);
>+				invalidFigures.set(i, null); 
> 				fig.validate();
> 			}
>+
>+			
> 		} finally {
> 			invalidFigures.clear();
> 			validating = false;

Actions: View | Diff

Attachments on bug 502833: 264505 | 267900