Attachment #249301 for bug #432147




 * Copyright (c) 2000, 2014 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *     Timo Kinnunen - Contribution for bug 432147 - [refactoring] Extract Constant displays error message on name of local variable
 *     IBM Corporation - initial API and implementation
 *******************************************************************************/
package org.eclipse.jdt.internal.corext.refactoring.code;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;

import org.eclipse.jdt.core.dom.Expression;
import org.eclipse.jdt.core.dom.FieldDeclaration;
import org.eclipse.jdt.core.dom.IBinding;
import org.eclipse.jdt.core.dom.IExtendedModifier;
import org.eclipse.jdt.core.dom.IMethodBinding;
import org.eclipse.jdt.core.dom.ITypeBinding;
import org.eclipse.jdt.core.dom.IVariableBinding;
import org.eclipse.jdt.core.dom.Initializer;
import org.eclipse.jdt.core.dom.Javadoc;
import org.eclipse.jdt.core.dom.MethodDeclaration;
import org.eclipse.jdt.core.dom.Modifier;
import org.eclipse.jdt.core.dom.SimpleName;
import org.eclipse.jdt.core.dom.Statement;
import org.eclipse.jdt.core.dom.SwitchStatement;
import org.eclipse.jdt.core.dom.Type;


	//------ settings ---------//
	private String fFieldName;
	private int fVisibility; 	/*see Modifier*/
	private boolean fDeclareStatic;
	private boolean fDeclareFinal;
	private int fInitializeIn; /*see INITIALIZE_IN_* constraints */
	private boolean fInitializeAsConstantIfPossible= false;

	//------ fields used for computations ---------//
    private CompilationUnit fCompilationUnitNode;
    private VariableDeclaration fTempDeclarationNode;
	//------ analysis ---------//
	private boolean fInitializerUsesLocalTypes;
	private boolean fTempTypeUsesClassTypeVariables;

	}

	public boolean canEnableSettingFinal(){
		if (fInitializeIn == INITIALIZE_IN_CONSTRUCTOR)
			return  canEnableSettingDeclareInConstructors() && ! tempHasAssignmentsOtherThanInitialization();
		else if (fInitializeIn == INITIALIZE_IN_FIELD)
			return  canEnableSettingDeclareInFieldDeclaration() && ! tempHasAssignmentsOtherThanInitialization();
		else if (isDeclaredInConstructor() || isDeclaredInInitializer())
			return  !tempHasAssignmentsOtherThanInitialization();
		else
			return false;
	}

    private boolean tempHasAssignmentsOtherThanInitialization() {
    	TempAssignmentFinder assignmentFinder= new TempAssignmentFinder(fTempDeclarationNode);
    	fCompilationUnitNode.accept(assignmentFinder);
		return assignmentFinder.hasAssignments();
    }

	public boolean canEnableSettingDeclareInConstructors(){
		return ! fDeclareStatic &&
				! fInitializerUsesLocalTypes &&
				! isDeclaredInConstructor() &&
				! isDeclaredInAnonymousClass() &&
				! isTempDeclaredInStaticMethod() &&
				tempHasInitializer();
	}

	private boolean isDeclaredInConstructor() {
		BodyDeclaration methodDeclaration= getBodyDeclaration();
		if(methodDeclaration instanceof MethodDeclaration) {
			return ((MethodDeclaration) methodDeclaration).isConstructor();
		}
		return false;
	}

	private boolean isDeclaredInInitializer() {
		BodyDeclaration initializerDeclaration= getBodyDeclaration();
		return initializerDeclaration instanceof Initializer;
	}

	public boolean canEnableSettingDeclareInMethod(){
		return (! fDeclareFinal || isDeclaredInInitializer()) &&
				tempHasInitializer();
	}
    private boolean tempHasInitializer() {
        return getTempInitializer() != null;
    }

	public boolean canEnableSettingDeclareInFieldDeclaration(){

	}

    private Expression getTempInitializer() {
    	return fTempDeclarationNode.getInitializer();
    }

    private boolean isTempDeclaredInStaticMethod() {
    	return Modifier.isStatic(getBodyDeclaration().getModifiers());
    }

    private BodyDeclaration getBodyDeclaration(){
    	return (BodyDeclaration)ASTNodes.getParent(fTempDeclarationNode, BodyDeclaration.class);
    }

    private boolean isDeclaredInAnonymousClass() {
    	return null != ASTNodes.getParent(fTempDeclarationNode, AnonymousClassDeclaration.class);
    }

    /*

			return result;

		initAST(pm);

		if (fTempDeclarationNode == null)
			return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_select_declaration);

		if (! Checks.isDeclaredIn(fTempDeclarationNode, MethodDeclaration.class) && !Checks.isDeclaredIn(fTempDeclarationNode, Initializer.class) )
			return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_only_declared_in_methods);

		if (isMethodParameter())
			return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_method_parameters);

		if (isTempAnExceptionInCatchBlock())
			return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_exceptions);

		if (!fSelfInitializing)
			initializeDefaults();
		return result;
	}

    private void initializeDefaults() {
        fVisibility= Modifier.PRIVATE;
        fDeclareStatic= Modifier.isStatic(getBodyDeclaration().getModifiers());
		if (fInitializeAsConstantIfPossible) {
			if(canEnableSettingDeclareInFieldDeclaration())
		        fInitializeIn= INITIALIZE_IN_FIELD;
			else if (canEnableSettingDeclareInMethod())
		        fInitializeIn= INITIALIZE_IN_METHOD;
		    else if (canEnableSettingDeclareInConstructors())
		        fInitializeIn= INITIALIZE_IN_CONSTRUCTOR;
		} else {
			if (canEnableSettingDeclareInMethod())
				fInitializeIn= INITIALIZE_IN_METHOD;
			else if (canEnableSettingDeclareInFieldDeclaration())
				fInitializeIn= INITIALIZE_IN_FIELD;
			else if (canEnableSettingDeclareInConstructors())
				fInitializeIn= INITIALIZE_IN_CONSTRUCTOR;
		}
        fDeclareFinal= fInitializeAsConstantIfPossible && canEnableSettingFinal();
    }

	public String[] guessFieldNames() {
		String rawTempName= StubUtility.getBaseName(fTempDeclarationNode.resolveBinding(), fCu.getJavaProject());
		String[] excludedNames= getNamesOfFieldsInDeclaringType();
		int dim= ASTNodes.getDimensions(fTempDeclarationNode);
		return StubUtility.getFieldNameSuggestions(fCu.getJavaProject(), rawTempName, dim, getModifiers(), excludedNames);

	}

    private void checkTempInitializerForLocalTypeUsage() {
    	Expression initializer= fTempDeclarationNode.getInitializer();
    	if (initializer == null)
	        return;

		IMethodBinding declaringMethodBinding= getMethodBinding();
		ITypeBinding[] methodTypeParameters= declaringMethodBinding == null ? new ITypeBinding[0] : declaringMethodBinding.getTypeParameters();
	    LocalTypeAndVariableUsageAnalyzer localTypeAnalyer= new LocalTypeAndVariableUsageAnalyzer(methodTypeParameters);
	    initializer.accept(localTypeAnalyer);
	    fInitializerUsesLocalTypes= ! localTypeAnalyer.getUsageOfEnclosingNodes().isEmpty();
    }

    private RefactoringStatus checkTempTypeForLocalTypeUsage(){

    	if (vds == null)
    		return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_cannot_promote);
    	Type type= 	vds.getType();
    	ITypeBinding binding= type.resolveBinding();
    	if (binding == null)
    		return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_cannot_promote);

		IMethodBinding declaringMethodBinding= getMethodBinding();
		ITypeBinding[] methodTypeParameters= declaringMethodBinding == null ? new ITypeBinding[0] : declaringMethodBinding.getTypeParameters();
		LocalTypeAndVariableUsageAnalyzer analyzer= new LocalTypeAndVariableUsageAnalyzer(methodTypeParameters);
		type.accept(analyzer);
		boolean usesLocalTypes= ! analyzer.getUsageOfEnclosingNodes().isEmpty();
		fTempTypeUsesClassTypeVariables= analyzer.getClassTypeVariablesUsed();
		if (usesLocalTypes)
			return RefactoringStatus.createFatalErrorStatus(RefactoringCoreMessages.PromoteTempToFieldRefactoring_uses_type_declared_locally);
		return null;
    }

	private IMethodBinding getMethodBinding() {
		BodyDeclaration methodDeclaration= getBodyDeclaration();
		return methodDeclaration != null && methodDeclaration instanceof MethodDeclaration ? ((MethodDeclaration) methodDeclaration).resolveBinding() : null;
	}

    private VariableDeclarationStatement getTempDeclarationStatement() {
        return (VariableDeclarationStatement) ASTNodes.getParent(fTempDeclarationNode, VariableDeclarationStatement.class);
    }

    private boolean isTempAnExceptionInCatchBlock() {
		return (fTempDeclarationNode.getParent() instanceof CatchClause);

    		pm.done();
    	}
    }

    private RefactoringStatus checkClashesInConstructors() {
		Assert.isTrue(fInitializeIn == INITIALIZE_IN_CONSTRUCTOR);
		Assert.isTrue(!isDeclaredInAnonymousClass());
		final AbstractTypeDeclaration declaration= (AbstractTypeDeclaration) getBodyDeclaration().getParent();
		if (declaration instanceof TypeDeclaration) {
			MethodDeclaration[] methods= ((TypeDeclaration) declaration).getMethods();
			for (int i= 0; i < methods.length; i++) {
				MethodDeclaration method= methods[i];
				if (!method.isConstructor())
					continue;
				NameCollector nameCollector= new NameCollector(method) {

                }
            }
        }
        return null;
    }

    private FieldDeclaration[] getFieldDeclarations() {
    	List<BodyDeclaration> bodyDeclarations= ASTNodes.getBodyDeclarations(getBodyDeclaration().getParent());
    	List<FieldDeclaration> fields= new ArrayList<FieldDeclaration>(1);
    	for (Iterator<BodyDeclaration> iter= bodyDeclarations.iterator(); iter.hasNext();) {
	        Object each= iter.next();
	        if (each instanceof FieldDeclaration)
	        	fields.add((FieldDeclaration) each);
        }
        return fields.toArray(new FieldDeclaration[fields.size()]);

				rewrite.replace(occurence, newName, null);
			}
		}
    }

    private void addInitializersToConstructors(ASTRewrite rewrite) throws CoreException {
    	Assert.isTrue(! isDeclaredInAnonymousClass());
    	final AbstractTypeDeclaration declaration= (AbstractTypeDeclaration)getBodyDeclaration().getParent();
    	final MethodDeclaration[] constructors= getAllConstructors(declaration);
    	if (constructors.length == 0) {
    		AST ast= rewrite.getAST();
    		MethodDeclaration newConstructor= ast.newMethodDeclaration();
    		newConstructor.setConstructor(true);
    		newConstructor.modifiers().addAll(ast.newModifiers(declaration.getModifiers() & ModifierRewrite.VISIBILITY_MODIFIERS));
    		newConstructor.setName(ast.newSimpleName(declaration.getName().getIdentifier()));

        rewrite.remove(fragment, null);
        if (fragments.size() == 1)
			rewrite.remove(tempDeclarationStatement, null);
    }

    private void addFieldDeclaration(ASTRewrite rewrite) {
    	FieldDeclaration[] fields= getFieldDeclarations();
    	ASTNode parent= getBodyDeclaration().getParent();
    	ChildListPropertyDescriptor descriptor= ASTNodes.getBodyDeclarationsProperty(parent);
    	int insertIndex;
    	if (fields.length == 0)
    		insertIndex= 0;
    	else
    		insertIndex= ASTNodes.getBodyDeclarations(parent).indexOf(fields[fields.length - 1]) + 1;


		return new RefactoringStatus();
	}


	public void setLinkedProposalModel(LinkedProposalModel model) {
		fLinkedProposalModel= model;
	}

	public void setInitializeAsConstantIfPossible(boolean value) {
		fInitializeAsConstantIfPossible = value;
	}
}




PullUpInputPage_pull_up1=Pull Up Methods
PullUpInputPage_exception=An unexpected exception occurred. See the error log for more details

ExtractTempAction_label=Extract &Local Variable...
ExtractTempAction_extract_temp=Extract Local Variable

ConvertLocalToField_label=Con&vert Local Variable to Field...
ConvertLocalToField_title=Convert Local Variable to Field or Constant

ExtractConstantAction_label=Extr&act Constant...
ExtractSuperTypeAction_label=Ex&tract Superclass...
ExtractConstantAction_extract_constant=Extract Constant

InlineTempAction_inline_temp=Inline Local Variable
InlineTempAction_label=&Inline Local Variable...

MoveInstanceMethodPage_Method_name=New &method name:
MoveInstanceMethodPage_New_receiver=&New target for ''{0}'':
MoveInstanceMethodPage_Receiver=Receiver
MoveInstanceMethodPage_Type=Type
MoveInstanceMethodPage_invalid_target=Target ''{0}'' is used in an assignment.

PromoteTempInputPage_Field_declaration=Field decla&ration
PromoteTempInputPage_Current_method=&Current block
PromoteTempInputPage_constructors=C&lass constructors
PromoteTempInputPage_Field_name=F&ield name:
PromoteTempInputPage_Initialize=Initialize in
PromoteTempInputPage_declare_static=&Declare field as \'static\'
PromoteTempInputPage_declare_final=Decl&are field as \'final\'

UseSupertypeInputPage_Select_supertype=Select the supertype to use




 * Copyright (c) 2000, 2011 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *     Timo Kinnunen - Contribution for bug 432147 - [refactoring] Extract Constant displays error message on name of local variable
 *     IBM Corporation - initial API and implementation
 *******************************************************************************/
package org.eclipse.jdt.ui.actions;

import org.eclipse.jface.text.ITextSelection;

import org.eclipse.ui.PlatformUI;

import org.eclipse.jdt.core.ICompilationUnit;
import org.eclipse.jdt.core.JavaModelException;
import org.eclipse.jdt.core.SourceRange;
import org.eclipse.jdt.core.dom.ASTNode;
import org.eclipse.jdt.core.dom.CompilationUnit;
import org.eclipse.jdt.core.dom.SimpleName;
import org.eclipse.jdt.core.dom.VariableDeclaration;

import org.eclipse.jdt.internal.corext.dom.fragments.ASTFragmentFactory;
import org.eclipse.jdt.internal.corext.dom.fragments.IASTFragment;
import org.eclipse.jdt.internal.corext.refactoring.RefactoringAvailabilityTester;
import org.eclipse.jdt.internal.corext.refactoring.code.ExtractConstantRefactoring;
import org.eclipse.jdt.internal.corext.refactoring.code.PromoteTempToFieldRefactoring;
import org.eclipse.jdt.internal.corext.refactoring.structure.CompilationUnitRewrite;
import org.eclipse.jdt.internal.corext.refactoring.util.RefactoringASTParser;

import org.eclipse.jdt.ui.refactoring.RefactoringSaveHelper;

import org.eclipse.jdt.internal.ui.IJavaHelpContextIds;
import org.eclipse.jdt.internal.ui.JavaPlugin;
import org.eclipse.jdt.internal.ui.actions.ActionUtil;
import org.eclipse.jdt.internal.ui.actions.SelectionConverter;
import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor;
import org.eclipse.jdt.internal.ui.javaeditor.JavaTextSelection;
import org.eclipse.jdt.internal.ui.refactoring.ExtractConstantWizard;
import org.eclipse.jdt.internal.ui.refactoring.PromoteTempWizard;
import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages;
import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter;

/**
 * Extracts an expression into a constant field and replaces all occurrences of
 * the expression with the new constant.
 *

	/* (non-Javadoc)
	 * Method declared on SelectionDispatchAction
	 */
	@Override
	public void run(ITextSelection selection) {
		if (!ActionUtil.isEditable(fEditor))
			return;
		ICompilationUnit unit= SelectionConverter.getInputAsCompilationUnit(fEditor);
		CompilationUnit cuNode= RefactoringASTParser.parseWithASTProvider(unit, true, null);
		int selectionStart= selection.getOffset();
		int selectionLength= selection.getLength();
		ExtractConstantRefactoring refactoring= new ExtractConstantRefactoring(cuNode, selectionStart, selectionLength);
		try {
			CompilationUnitRewrite cuRewrite= new CompilationUnitRewrite(unit, cuNode);
			SourceRange range= new SourceRange(selectionStart, selectionLength);
			IASTFragment ast= ASTFragmentFactory.createFragmentForSourceRange(range, cuRewrite.getRoot(), unit);
			ASTNode node= ast.getAssociatedNode();
			if (node instanceof SimpleName && node.getParent() instanceof VariableDeclaration) {
				ICompilationUnit cunit= SelectionConverter.getInputAsCompilationUnit(fEditor);
				PromoteTempToFieldRefactoring refactoring2= new PromoteTempToFieldRefactoring(cunit, selection.getOffset(), selection.getLength());
				refactoring2.setDeclareFinal(true);
				refactoring2.setDeclareStatic(true);
				refactoring2.setFieldName(refactoring.guessConstantName());
				refactoring2.setInitializeAsConstantIfPossible(true);
				new RefactoringStarter().activate(new PromoteTempWizard(refactoring2), getShell(), RefactoringMessages.ConvertLocalToField_title, RefactoringSaveHelper.SAVE_NOTHING);
				return;
			}
		} catch (JavaModelException e) {
			JavaPlugin.log(e);
		}
		new RefactoringStarter().activate(new ExtractConstantWizard(refactoring), getShell(), RefactoringMessages.ExtractConstantAction_extract_constant, RefactoringSaveHelper.SAVE_NOTHING);
	}
}

Return to bug 432147

Lines 134-148 Link Here

(-)a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/refactoringui.properties (-2 / +2 lines)
134	PullUpInputPage_pull_up1=Pull Up Methods	134	PullUpInputPage_pull_up1=Pull Up Methods
135	PullUpInputPage_exception=An unexpected exception occurred. See the error log for more details	135	PullUpInputPage_exception=An unexpected exception occurred. See the error log for more details
136		136
137	ExtractTempAction_label=Extract &Local Variable...	137	ExtractTempAction_label=Extract &Local Variable...
138	ExtractTempAction_extract_temp=Extract Local Variable	138	ExtractTempAction_extract_temp=Extract Local Variable
139		139
140	ConvertLocalToField_label=Con&vert Local Variable to Field...	140	ConvertLocalToField_label=Con&vert Local Variable to Field...
141	ConvertLocalToField_title=Convert Local Variable to Field	141	ConvertLocalToField_title=Convert Local Variable to Field or Constant
142		142
143	ExtractConstantAction_label=Extr&act Constant...	143	ExtractConstantAction_label=Extr&act Constant...
144	ExtractSuperTypeAction_label=Ex&tract Superclass...	144	ExtractSuperTypeAction_label=Ex&tract Superclass...
145	ExtractConstantAction_extract_constant=Extract Constant	145	ExtractConstantAction_extract_constant=Extract Constant
146		146
147	InlineTempAction_inline_temp=Inline Local Variable	147	InlineTempAction_inline_temp=Inline Local Variable
148	InlineTempAction_label=&Inline Local Variable...	148	InlineTempAction_label=&Inline Local Variable...
Lines 317-331 Link Here
317	MoveInstanceMethodPage_Method_name=New &method name:	317	MoveInstanceMethodPage_Method_name=New &method name:
318	MoveInstanceMethodPage_New_receiver=&New target for ''{0}'':	318	MoveInstanceMethodPage_New_receiver=&New target for ''{0}'':
319	MoveInstanceMethodPage_Receiver=Receiver	319	MoveInstanceMethodPage_Receiver=Receiver
320	MoveInstanceMethodPage_Type=Type	320	MoveInstanceMethodPage_Type=Type
321	MoveInstanceMethodPage_invalid_target=Target ''{0}'' is used in an assignment.	321	MoveInstanceMethodPage_invalid_target=Target ''{0}'' is used in an assignment.
322		322
323	PromoteTempInputPage_Field_declaration=Field decla&ration	323	PromoteTempInputPage_Field_declaration=Field decla&ration
324	PromoteTempInputPage_Current_method=&Current method	324	PromoteTempInputPage_Current_method=&Current block
325	PromoteTempInputPage_constructors=C&lass constructors	325	PromoteTempInputPage_constructors=C&lass constructors
326	PromoteTempInputPage_Field_name=F&ield name:	326	PromoteTempInputPage_Field_name=F&ield name:
327	PromoteTempInputPage_Initialize=Initialize in	327	PromoteTempInputPage_Initialize=Initialize in
328	PromoteTempInputPage_declare_static=&Declare field as \'static\'	328	PromoteTempInputPage_declare_static=&Declare field as \'static\'
329	PromoteTempInputPage_declare_final=Decl&are field as \'final\'	329	PromoteTempInputPage_declare_final=Decl&are field as \'final\'
330		330
331	UseSupertypeInputPage_Select_supertype=Select the supertype to use	331	UseSupertypeInputPage_Select_supertype=Select the supertype to use

Lines 2-34 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/ExtractConstantAction.java (-1 / +39 lines)
2	* Copyright (c) 2000, 2011 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
6	* http://www.eclipse.org/legal/epl-v10.html	6	* http://www.eclipse.org/legal/epl-v10.html
7	*	7	*
8	* Contributors:	8	* Contributors:
		9	* Timo Kinnunen - Contribution for bug 432147 - [refactoring] Extract Constant displays error message on name of local variable
9	* IBM Corporation - initial API and implementation	10	* IBM Corporation - initial API and implementation
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.ui.actions;	12	package org.eclipse.jdt.ui.actions;
12		13
13	import org.eclipse.jface.text.ITextSelection;	14	import org.eclipse.jface.text.ITextSelection;
14		15
15	import org.eclipse.ui.PlatformUI;	16	import org.eclipse.ui.PlatformUI;
16		17
		18	import org.eclipse.jdt.core.ICompilationUnit;
		19	import org.eclipse.jdt.core.JavaModelException;
		20	import org.eclipse.jdt.core.SourceRange;
		21	import org.eclipse.jdt.core.dom.ASTNode;
		22	import org.eclipse.jdt.core.dom.CompilationUnit;
		23	import org.eclipse.jdt.core.dom.SimpleName;
		24	import org.eclipse.jdt.core.dom.VariableDeclaration;
		25
		26	import org.eclipse.jdt.internal.corext.dom.fragments.ASTFragmentFactory;
		27	import org.eclipse.jdt.internal.corext.dom.fragments.IASTFragment;
17	import org.eclipse.jdt.internal.corext.refactoring.RefactoringAvailabilityTester;	28	import org.eclipse.jdt.internal.corext.refactoring.RefactoringAvailabilityTester;
18	import org.eclipse.jdt.internal.corext.refactoring.code.ExtractConstantRefactoring;	29	import org.eclipse.jdt.internal.corext.refactoring.code.ExtractConstantRefactoring;
		30	import org.eclipse.jdt.internal.corext.refactoring.code.PromoteTempToFieldRefactoring;
		31	import org.eclipse.jdt.internal.corext.refactoring.structure.CompilationUnitRewrite;
		32	import org.eclipse.jdt.internal.corext.refactoring.util.RefactoringASTParser;
19		33
20	import org.eclipse.jdt.ui.refactoring.RefactoringSaveHelper;	34	import org.eclipse.jdt.ui.refactoring.RefactoringSaveHelper;
21		35
22	import org.eclipse.jdt.internal.ui.IJavaHelpContextIds;	36	import org.eclipse.jdt.internal.ui.IJavaHelpContextIds;
		37	import org.eclipse.jdt.internal.ui.JavaPlugin;
23	import org.eclipse.jdt.internal.ui.actions.ActionUtil;	38	import org.eclipse.jdt.internal.ui.actions.ActionUtil;
24	import org.eclipse.jdt.internal.ui.actions.SelectionConverter;	39	import org.eclipse.jdt.internal.ui.actions.SelectionConverter;
25	import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor;	40	import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor;
26	import org.eclipse.jdt.internal.ui.javaeditor.JavaTextSelection;	41	import org.eclipse.jdt.internal.ui.javaeditor.JavaTextSelection;
27	import org.eclipse.jdt.internal.ui.refactoring.ExtractConstantWizard;	42	import org.eclipse.jdt.internal.ui.refactoring.ExtractConstantWizard;
		43	import org.eclipse.jdt.internal.ui.refactoring.PromoteTempWizard;
28	import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages;	44	import org.eclipse.jdt.internal.ui.refactoring.RefactoringMessages;
29	import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter;	45	import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter;
30		46
31	/**	47	/**
32	* Extracts an expression into a constant field and replaces all occurrences of	48	* Extracts an expression into a constant field and replaces all occurrences of
33	* the expression with the new constant.	49	* the expression with the new constant.
34	*	50	*
Lines 80-90 Link Here
80	/* (non-Javadoc)	96	/* (non-Javadoc)
81	* Method declared on SelectionDispatchAction	97	* Method declared on SelectionDispatchAction
82	*/	98	*/
83	@Override	99	@Override
84	public void run(ITextSelection selection) {	100	public void run(ITextSelection selection) {
85	if (!ActionUtil.isEditable(fEditor))	101	if (!ActionUtil.isEditable(fEditor))
86	return;	102	return;
87	ExtractConstantRefactoring refactoring= new ExtractConstantRefactoring(SelectionConverter.getInputAsCompilationUnit(fEditor), selection.getOffset(), selection.getLength());	103	ICompilationUnit unit= SelectionConverter.getInputAsCompilationUnit(fEditor);
		104	CompilationUnit cuNode= RefactoringASTParser.parseWithASTProvider(unit, true, null);
		105	int selectionStart= selection.getOffset();
		106	int selectionLength= selection.getLength();
		107	ExtractConstantRefactoring refactoring= new ExtractConstantRefactoring(cuNode, selectionStart, selectionLength);
		108	try {
		109	CompilationUnitRewrite cuRewrite= new CompilationUnitRewrite(unit, cuNode);
		110	SourceRange range= new SourceRange(selectionStart, selectionLength);
		111	IASTFragment ast= ASTFragmentFactory.createFragmentForSourceRange(range, cuRewrite.getRoot(), unit);
		112	ASTNode node= ast.getAssociatedNode();
		113	if (node instanceof SimpleName && node.getParent() instanceof VariableDeclaration) {
		114	ICompilationUnit cunit= SelectionConverter.getInputAsCompilationUnit(fEditor);
		115	PromoteTempToFieldRefactoring refactoring2= new PromoteTempToFieldRefactoring(cunit, selection.getOffset(), selection.getLength());
		116	refactoring2.setDeclareFinal(true);
		117	refactoring2.setDeclareStatic(true);
		118	refactoring2.setFieldName(refactoring.guessConstantName());
		119	refactoring2.setInitializeAsConstantIfPossible(true);
		120	new RefactoringStarter().activate(new PromoteTempWizard(refactoring2), getShell(), RefactoringMessages.ConvertLocalToField_title, RefactoringSaveHelper.SAVE_NOTHING);
		121	return;
		122	}
		123	} catch (JavaModelException e) {
		124	JavaPlugin.log(e);
		125	}
88	new RefactoringStarter().activate(new ExtractConstantWizard(refactoring), getShell(), RefactoringMessages.ExtractConstantAction_extract_constant, RefactoringSaveHelper.SAVE_NOTHING);	126	new RefactoringStarter().activate(new ExtractConstantWizard(refactoring), getShell(), RefactoringMessages.ExtractConstantAction_extract_constant, RefactoringSaveHelper.SAVE_NOTHING);
89	}	127	}
90	}	128	}