Attachment 23945 Details for Bug 101613 – Changed IndexBasedBuilder#createInfofFromClassFileInJar(...) to use the OS path in the case of external jars

[patch] Changed IndexBasedBuilder#createInfofFromClassFileInJar(...) to use the OS path in the case of external jars

patch101613_org.eclipse.jdt.core.txt (text/plain), 1.83 KB, created by Jerome Lanneluc

on 2005-06-24 10:37:54 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jerome Lanneluc

Created: 2005-06-24 10:37:54 EDT

Size: 1.83 KB

patch

obsolete

>Index: model/org/eclipse/jdt/internal/core/hierarchy/IndexBasedHierarchyBuilder.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/hierarchy/IndexBasedHierarchyBuilder.java,v
>retrieving revision 1.90
>diff -u -r1.90 IndexBasedHierarchyBuilder.java
>--- model/org/eclipse/jdt/internal/core/hierarchy/IndexBasedHierarchyBuilder.java	9 May 2005 09:17:58 -0000	1.90
>+++ model/org/eclipse/jdt/internal/core/hierarchy/IndexBasedHierarchyBuilder.java	24 Jun 2005 14:35:36 -0000
>@@ -12,12 +12,10 @@
> 
> import java.util.*;
> 
>+import org.eclipse.core.runtime.IPath;
> import org.eclipse.core.runtime.IProgressMonitor;
> import org.eclipse.core.runtime.SubProgressMonitor;
> import org.eclipse.jdt.core.*;
>-import org.eclipse.jdt.core.IJavaProject;
>-import org.eclipse.jdt.core.IType;
>-import org.eclipse.jdt.core.JavaModelException;
> import org.eclipse.jdt.core.compiler.CharOperation;
> import org.eclipse.jdt.core.search.*;
> import org.eclipse.jdt.internal.compiler.env.AccessRuleSet;
>@@ -350,7 +348,8 @@
> protected IBinaryType createInfoFromClassFileInJar(Openable classFile) {
> 	String filePath = (((ClassFile)classFile).getType().getFullyQualifiedName('$')).replace('.', '/') + SuffixConstants.SUFFIX_STRING_class;
> 	IPackageFragmentRoot root = classFile.getPackageFragmentRoot();
>-	String rootPath = root.getPath().toString(); // root path always contain forward slahes (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=93113)
>+	IPath path = root.getPath();
>+	String rootPath = path.getDevice() == null ? path.toString() : path.toOSString();
> 	String documentPath = rootPath + IJavaSearchScope.JAR_FILE_ENTRY_SEPARATOR + filePath;
> 	IBinaryType binaryType = (IBinaryType)this.binariesFromIndexMatches.get(documentPath);
> 	if (binaryType != null) {

Actions: View | Diff

Attachments on bug 101613: 23933 | 23934 | 23945 | 23949 | 23950