Attachment 2336 Details for Bug 25818 – First cut of patch - need refinement

[patch] First cut of patch - need refinement

patchForBug25818.txt (text/plain), 1.17 KB, created by Dani Megert

on 2002-11-07 10:00:16 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Dani Megert

Created: 2002-11-07 10:00:16 EST

Size: 1.17 KB

patch

obsolete

>Index: PageBookView.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui/Eclipse UI/org/eclipse/ui/part/Attic/PageBookView.java,v
>retrieving revision 1.14
>diff -u -r1.14 PageBookView.java
>--- PageBookView.java	19 Jun 2002 14:43:59 -0000	1.14
>+++ PageBookView.java	7 Nov 2002 14:58:19 -0000
>@@ -360,6 +360,8 @@
> 	Iterator enum = clone.values().iterator();
> 	while (enum.hasNext()) {
> 		PageRec rec = (PageRec) enum.next();
>+		if (rec.subActionBars != null)
>+			rec.subActionBars.dispose();
> 		removePage(rec);
> 	}
> 
>@@ -533,6 +535,7 @@
>  * method deal with the closing of the active part. Subclasses may extend.
>  */
> public void partClosed(IWorkbenchPart part) {
>+	PageRec rec = getPageRec(part);
> 	// Update the active part.
> 	if (activeRec != null && activeRec.part == part) {
> 		activeRec.subActionBars.dispose();
>@@ -543,10 +546,12 @@
> 
> 		activeRec = null;
> 		showPageRec(defaultPageRec);
>+	} else {
>+		if (rec != null && rec.subActionBars != null)
>+			rec.subActionBars.dispose();
> 	}
> 	
> 	// Find and remove the part page.
>-	PageRec rec = getPageRec(part);
> 	if (rec != null)
> 		removePage(rec);
> }

Actions: View | Diff

Attachments on bug 25818: 2336