Attachment 23096 Details for Bug 99629 – Proposed patch

Proposed patch

patchjdtcore002.txt (text/plain), 2.53 KB, created by David Audel

on 2005-06-14 15:21:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2005-06-14 15:21:43 EDT

Size: 2.53 KB

patch

obsolete

>Index: buildnotes_jdt-core.html
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/buildnotes_jdt-core.html,v
>retrieving revision 1.4388
>diff -u -r1.4388 buildnotes_jdt-core.html
>--- buildnotes_jdt-core.html	14 Jun 2005 16:42:57 -0000	1.4388
>+++ buildnotes_jdt-core.html	14 Jun 2005 19:15:30 -0000
>@@ -50,7 +50,9 @@
> </ul>
> 
> <h3>Problem Reports Fixed</h3>
>-<a href="http://bugs.eclipse.org/bugs/show_bug.cgi?id=99922">99922</a>
>+<a href="http://bugs.eclipse.org/bugs/show_bug.cgi?id=99629">99629</a>
>+Error while entering expression in change variable value dialog
>+<br><a href="http://bugs.eclipse.org/bugs/show_bug.cgi?id=99922">99922</a>
> [1.5][compiler] NPE in compiler for Arrays.asList(3, 3.1);
> <br><a href="http://bugs.eclipse.org/bugs/show_bug.cgi?id=98378">98378</a>
> [search] Can't find declarations in hierarchy of interface.
>Index: codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java,v
>retrieving revision 1.246
>diff -u -r1.246 CompletionEngine.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	8 Jun 2005 11:21:45 -0000	1.246
>+++ codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	14 Jun 2005 19:15:44 -0000
>@@ -1306,6 +1306,26 @@
> 					}
> 				}
> 			}
>+		}  catch (IndexOutOfBoundsException e) { // work-around internal failure - 1GEMF6D (added with fix of 99629)
>+			if(DEBUG) {
>+				System.out.println("Exception caught by CompletionEngine:"); //$NON-NLS-1$
>+				e.printStackTrace(System.out);
>+			}
>+		} catch (InvalidCursorLocation e) { // may eventually report a usefull error (added to fix 99629)
>+			if(DEBUG) {
>+				System.out.println("Exception caught by CompletionEngine:"); //$NON-NLS-1$
>+				e.printStackTrace(System.out);
>+			}
>+		} catch (AbortCompilation e) { // ignore this exception for now since it typically means we cannot find java.lang.Object (added with fix of 99629)
>+			if(DEBUG) {
>+				System.out.println("Exception caught by CompletionEngine:"); //$NON-NLS-1$
>+				e.printStackTrace(System.out);
>+			}
>+		} catch (CompletionNodeFound e){ // internal failure - bugs 5618 (added with fix of 99629)
>+			if(DEBUG) {
>+				System.out.println("Exception caught by CompletionEngine:"); //$NON-NLS-1$
>+				e.printStackTrace(System.out);
>+			}
> 		} catch(JavaModelException e) {
> 			// Do nothing
> 		}

Actions: View

Attachments on bug 99629: 23096