Attachment 22308 Details for Bug 84001 – Proposed patch

Proposed patch

patchjdtcore001.txt (text/plain), 1.53 KB, created by David Audel

on 2005-06-03 07:19:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2005-06-03 07:19:36 EDT

Size: 1.53 KB

patch

obsolete

>Index: codeassist/org/eclipse/jdt/internal/codeassist/select/SelectionParser.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/select/SelectionParser.java,v
>retrieving revision 1.72
>diff -u -r1.72 SelectionParser.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/select/SelectionParser.java	18 Mar 2005 15:06:29 -0000	1.72
>+++ codeassist/org/eclipse/jdt/internal/codeassist/select/SelectionParser.java	3 Jun 2005 07:48:10 -0000
>@@ -154,11 +154,17 @@
> 	// ClassBodyopt produces a null item on the astStak if it produces NO class body
> 	// An empty class body produces a 0 on the length stack.....
> 
>-	int length;
>-	if (((length = astLengthStack[astLengthPtr]) == 1)
>+	
>+	if ((astLengthStack[astLengthPtr] == 1)
> 		&& (astStack[astPtr] == null)) {
> 
>-		if (this.indexOfAssistIdentifier() < 0) {
>+		
>+		int index;
>+		if ((index = this.indexOfAssistIdentifier()) < 0) {
>+			super.classInstanceCreation(hasClassBody);
>+			return;
>+		} else if(this.identifierLengthPtr > -1 &&
>+					(this.identifierLengthStack[this.identifierLengthPtr] - 1) != index) {
> 			super.classInstanceCreation(hasClassBody);
> 			return;
> 		}
>@@ -168,6 +174,7 @@
> 		alloc = new SelectionOnQualifiedAllocationExpression();
> 		alloc.sourceEnd = endPosition; //the position has been stored explicitly
> 
>+		int length;
> 		if ((length = expressionLengthStack[expressionLengthPtr--]) != 0) {
> 			expressionPtr -= length;
> 			System.arraycopy(

Actions: View

Attachments on bug 84001: 17574 | 22308