Attachment 22012 Details for Bug 96944 – Proposed patch

Proposed patch

patchjdtcore001.txt (text/plain), 1.54 KB, created by David Audel

on 2005-05-31 04:56:24 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2005-05-31 04:56:24 EDT

Size: 1.54 KB

patch

obsolete

>Index: codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java,v
>retrieving revision 1.240
>diff -u -r1.240 CompletionEngine.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	26 May 2005 09:06:55 -0000	1.240
>+++ codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	31 May 2005 08:43:00 -0000
>@@ -4361,7 +4361,10 @@
> 		
> 		if (!skip && proposeType && scope.enclosingSourceType() != null) {
> 			findNestedTypes(token, scope.enclosingSourceType(), scope, proposeAllMemberTypes, typesFound);
>-			findTypeParameters(token, scope);
>+			if(!assistNodeIsConstructor) {
>+				// don't propose type parmaters if the completion is a constructor ('new |')
>+				findTypeParameters(token, scope);
>+			}
> 		}
> 
> 		if (!skip && proposeType && this.unitScope != null) {
>@@ -4458,6 +4461,11 @@
> 					if(this.expectedTypes[i] instanceof ReferenceBinding) {
> 						ReferenceBinding refBinding = (ReferenceBinding)this.expectedTypes[i];
> 						
>+						if(refBinding.isTypeVariable() && assistNodeIsConstructor) {
>+							// don't propose type variable if the completion is a constructor ('new |')
>+							continue next;
>+						}
>+						
> 						int accessibility = IAccessRule.K_ACCESSIBLE;
> 						if(refBinding.hasRestrictedAccess()) {
> 							AccessRestriction accessRestriction = lookupEnvironment.getAccessRestriction(refBinding);

Actions: View

Attachments on bug 96944: 22012 | 22013