Attachment 209374 Details for Bug 358903 – ResourceLeakTests.java

ResourceLeakTests.java

ResourceLeakTests.java (text/plain), 100.75 KB, created by Stephan Herrmann

on 2012-01-12 08:43:12 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Herrmann

Created: 2012-01-12 08:43:12 EST

Size: 100.75 KB

patch

obsolete

>/*******************************************************************************
> * Copyright (c) 2011, 2012 GK Software AG and others.
> * All rights reserved. This program and the accompanying materials
> * are made available under the terms of the Eclipse Public License v1.0
> * which accompanies this distribution, and is available at
> * http://www.eclipse.org/legal/epl-v10.html
> *
> * Contributors:
> *     Stephan Herrmann - initial API and implementation
> *******************************************************************************/
>package org.eclipse.jdt.core.tests.compiler.regression;
>
>import java.io.IOException;
>import java.net.URL;
>import java.util.Map;
>
>import junit.framework.Test;
>
>import org.eclipse.core.runtime.FileLocator;
>import org.eclipse.core.runtime.Path;
>import org.eclipse.core.runtime.Platform;
>import org.eclipse.jdt.core.JavaCore;
>import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
>import org.eclipse.jdt.internal.compiler.impl.CompilerOptions;
>
>public class ResourceLeakTests extends AbstractRegressionTest {
>
>static {
>//	TESTS_NAMES = new String[] { "test061c"};
>//	TESTS_NUMBERS = new int[] { 50 };
>//	TESTS_RANGE = new int[] { 11, -1 };
>}
>public ResourceLeakTests(String name) {
>	super(name);
>}
>public static Test suite() {
>	return buildAllCompliancesTestSuite(ResourceLeakTests.class);
>}
>
>void runTestsExpectingErrorsOnlyIn17(String[] testFiles, String errorsIn17, Map options) {
>	if (this.complianceLevel >= ClassFileConstants.JDK1_7)
>		runNegativeTest(testFiles, errorsIn17, null, true, options);
>	else
>		runConformTest(testFiles, "", null, true, null, options, null);
>}
>
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses an AutoCloseable without ever closing it.
>public void test056() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>// not invoking any methods on FileReader, try to avoid necessary call to superclass() in the compiler
>//			"        char[] in = new char[50];\n" +
>//			"        fileReader.read(in);\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	FileReader fileReader = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Resource leak: 'fileReader' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses an AutoCloseable and closes it but not protected by t-w-r nor regular try-finally
>public void test056a() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportExplicitlyClosedAutoCloseable, CompilerOptions.ERROR);
>	runTestsExpectingErrorsOnlyIn17(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"		 fileReader.close();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	FileReader fileReader = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Resource 'fileReader' should be managed by try-with-resource\n" +
>		"----------\n",
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses an AutoCloseable and closes it properly in a finally block
>public void test056b() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        try {\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"        } finally {\n" +
>			"		     fileReader.close();\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) {\n" +
>			"        try {\n" +
>			"            new X().foo();\n" +
>			"        } catch (IOException ioex) {\n" +
>			"            System.out.println(\"caught\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"caught", /*output*/
>		null/*classLibs*/,
>		true/*shouldFlush*/,
>		null/*vmargs*/,
>		options,
>		null/*requestor*/);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses an AutoCloseable properly within try-with-resources.
>public void test056c() {
>	if (this.complianceLevel < ClassFileConstants.JDK1_7) return; // t-w-r used
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        try (FileReader fileReader = new FileReader(file)) {\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"		 }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) {\n" +
>			"        try {\n" +
>			"            new X().foo();\n" +
>			"        } catch (IOException ioex) {\n" +
>			"            System.out.println(\"caught\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"caught", /*output*/
>		null/*classLibs*/,
>		true/*shouldFlush*/,
>		null/*vmargs*/,
>		options,
>		null/*requestor*/);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses two AutoCloseables (testing independent analysis)
>//- one closeable may be unclosed at a conditional return
>//- the other is only conditionally closed
>public void test056d() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(boolean flag1, boolean flag2) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        char[] in = new char[50];\n" +
>			"        FileReader fileReader1 = new FileReader(file);\n" +
>			"        fileReader1.read(in);\n" +
>			"        FileReader fileReader2 = new FileReader(file);\n" +
>			"        fileReader2.read(in);\n" +
>			"        if (flag1) {\n" +
>			"            fileReader2.close();\n" +
>			"            return;\n" +
>			"        } else if (flag2) {\n" +
>			"            fileReader2.close();\n" +
>			"        }\n" +
>			"        fileReader1.close();\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo(false, true);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. WARNING in X.java (at line 10)\n" +
>		"	FileReader fileReader2 = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^^\n" +
>		"Potential resource leak: 'fileReader2' may not be closed\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 14)\n" +
>		"	return;\n" +
>		"	^^^^^^^\n" +
>		"Resource leak: 'fileReader1' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses two AutoCloseables (testing independent analysis)
>//- one closeable may be unclosed at a conditional return
>//- the other is only conditionally closed
>public void test056d_suppress() {
>	if (this.complianceLevel < ClassFileConstants.JDK1_5) return; // annotations used
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	options.put(CompilerOptions.OPTION_SuppressOptionalErrors, CompilerOptions.ENABLED);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(boolean flag1, boolean flag2) throws IOException {\n" +
>			"        @SuppressWarnings(\"resource\") File file = new File(\"somefile\"); // unnecessary suppress\n" +
>			"        char[] in = new char[50];\n" +
>			"        FileReader fileReader1 = new FileReader(file);\n" +
>			"        fileReader1.read(in);\n" +
>			"        @SuppressWarnings(\"resource\") FileReader fileReader2 = new FileReader(file); // useful suppress\n" +
>			"        fileReader2.read(in);\n" +
>			"        if (flag1) {\n" +
>			"            fileReader2.close();\n" +
>			"            return; // not suppressed\n" +
>			"        } else if (flag2) {\n" +
>			"            fileReader2.close();\n" +
>			"        }\n" +
>			"        fileReader1.close();\n" +
>			"    }\n" +
>			"    @SuppressWarnings(\"resource\") // useful suppress\n" +
>			"    void bar() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo(false, true);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. WARNING in X.java (at line 6)\n" +
>		"	@SuppressWarnings(\"resource\") File file = new File(\"somefile\"); // unnecessary suppress\n" +
>		"	                  ^^^^^^^^^^\n" +
>		"Unnecessary @SuppressWarnings(\"resource\")\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 14)\n" +
>		"	return; // not suppressed\n" +
>		"	^^^^^^^\n" +
>		"Resource leak: 'fileReader1' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// Bug 362332 - Only report potential leak when closeable not created in the local scope
>// one method returns an AutoCleasble, a second method uses this object without ever closing it.
>public void test056e() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    FileReader getReader(String filename) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        return fileReader;\n" + 		// don't complain here, pass responsibility to caller
>			"    }\n" +
>			"    void foo() throws IOException {\n" +
>			"        FileReader reader = getReader(\"somefile\");\n" +
>			"        char[] in = new char[50];\n" +
>			"        reader.read(in);\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 11)\n" +
>		"	FileReader reader = getReader(\"somefile\");\n" +
>		"	           ^^^^^^\n" +
>		"Potential resource leak: \'reader\' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method explicitly closes its AutoCloseable rather than using t-w-r
>public void test056f() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	options.put(CompilerOptions.OPTION_ReportExplicitlyClosedAutoCloseable, CompilerOptions.ERROR);
>	runTestsExpectingErrorsOnlyIn17(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = null;\n" +
>			"        try {\n" +
>			"            fileReader = new FileReader(file);\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"        } finally {\n" +
>			"            fileReader.close();\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	FileReader fileReader = null;\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Resource 'fileReader' should be managed by try-with-resource\n" +
>		"----------\n",
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// an AutoCloseable local is re-assigned
>public void test056g() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"        fileReader = new FileReader(file);\n" +
>			"        fileReader.read(in);\n" +
>			"        fileReader.close();\n" +
>			"        fileReader = null;\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 10)\n" +
>		"	fileReader = new FileReader(file);\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: 'fileReader' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// an AutoCloseable local is re-assigned after null-assigned
>public void test056g2() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"        fileReader = null;\n" +
>			"        fileReader = new FileReader(file);\n" + // don't complain again, fileReader is null, so nothing can leak here
>			"        fileReader.read(in);\n" +
>			"        fileReader.close();\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 10)\n" +
>		"	fileReader = null;\n" +
>		"	^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: 'fileReader' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// two AutoCloseables at different nesting levels (anonymous local type)
>public void test056h() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        final File file = new File(\"somefile\");\n" +
>			"        final FileReader fileReader = new FileReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"        new Runnable() {\n public void run() {\n" +
>			"            try {\n" +
>			"                fileReader.close();\n" +
>			"                FileReader localReader = new FileReader(file);\n" +
>			"            } catch (IOException ex) { /* nop */ }\n" +
>			"        }}.run();\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. WARNING in X.java (at line 7)\n" +
>		"	final FileReader fileReader = new FileReader(file);\n" +
>		"	                 ^^^^^^^^^^\n" +
>		"Potential resource leak: 'fileReader' may not be closed\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 14)\n" +
>		"	FileReader localReader = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^^\n" +
>		"Resource leak: 'localReader' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// three AutoCloseables in different blocks of the same method
>public void test056i() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(boolean f1, boolean f2) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        if (f1) {\n" +
>			"            FileReader fileReader = new FileReader(file); // err: not closed\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"            while (true) {\n" +
>			"                 FileReader loopReader = new FileReader(file); // don't warn, properly closed\n" +
>			"                 loopReader.close();" +
>			"                 break;\n" +
>			"            }\n" +
>			"        } else {\n" +
>			"            FileReader fileReader = new FileReader(file); // warn: not closed on all paths\n" +
>			"            if (f2)\n" +
>			"                fileReader.close();\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo(true, true);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 8)\n" +
>		"	FileReader fileReader = new FileReader(file); // err: not closed\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Resource leak: 'fileReader' is never closed\n" +
>		"----------\n" +
>		"2. WARNING in X.java (at line 16)\n" +
>		"	FileReader fileReader = new FileReader(file); // warn: not closed on all paths\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Potential resource leak: 'fileReader' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// three AutoCloseables in different blocks of the same method - problems ignored
>public void test056i_ignore() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.IGNORE);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.IGNORE);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(boolean f1, boolean f2) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        if (f1) {\n" +
>			"            FileReader fileReader = new FileReader(file); // err: not closed\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"            while (true) {\n" +
>			"                 FileReader loopReader = new FileReader(file); // don't warn, properly closed\n" +
>			"                 loopReader.close();" +
>			"                 break;\n" +
>			"            }\n" +
>			"        } else {\n" +
>			"            FileReader fileReader = new FileReader(file); // warn: not closed on all paths\n" +
>			"            if (f2)\n" +
>			"                fileReader.close();\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// three AutoCloseables in different blocks of the same method
>public void test056i2() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(boolean f1, boolean f2) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        if (f1) {\n" +
>			"            FileReader fileReader = new FileReader(file); // properly closed\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"            while (true) {\n" +
>			"                  fileReader.close();\n" +
>			"                  FileReader loopReader = new FileReader(file); // don't warn, properly closed\n" +
>			"                  loopReader.close();\n" +
>			"                  break;\n" +
>			"            }\n" +
>			"        } else {\n" +
>			"            FileReader fileReader = new FileReader(file); // warn: not closed on all paths\n" +
>			"            if (f2)\n" +
>			"                fileReader.close();\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo(true, true);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 18)\n" +
>		"	FileReader fileReader = new FileReader(file); // warn: not closed on all paths\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Potential resource leak: 'fileReader' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses an AutoCloseable without closing it locally but passing as arg to another method
>public void test056j() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        read(fileReader);\n" +
>			"    }\n" +
>			"    void read(FileReader reader) { }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	FileReader fileReader = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Potential resource leak: 'fileReader' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// a method uses an AutoCloseable without closing it locally but passing as arg to another method
>public void test056jconditional() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(boolean b) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        synchronized (b ? this : new X()) {\n" +
>			"            new ReadDelegator(fileReader);\n" +
>			"        }\n" +
>			"    }\n" +
>			"    class ReadDelegator { ReadDelegator(FileReader reader) { } }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo(true);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	FileReader fileReader = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Potential resource leak: 'fileReader' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// many locals, some are AutoCloseable.
>// Unfortunately analysis cannot respect how exception exits may affect ra3 and rb3,
>// doing so would create false positives.
>public void test056k() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	options.put(CompilerOptions.OPTION_ReportExplicitlyClosedAutoCloseable, CompilerOptions.ERROR);
>	String expectedProblems = this.complianceLevel < ClassFileConstants.JDK1_7 ?
>				"----------\n" +
>				"1. ERROR in X.java (at line 15)\n" +
>				"	ra2 = new FileReader(file);\n" +
>				"	^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>				"Resource leak: \'ra2\' is never closed\n" +
>				"----------\n" +
>				"2. ERROR in X.java (at line 28)\n" +
>				"	rb2 = new FileReader(file);\n" +
>				"	^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>				"Resource leak: \'rb2\' is never closed\n" +
>				"----------\n"
>			:
>				"----------\n" +
>				"1. ERROR in X.java (at line 12)\n" +
>				"	FileReader ra1 = null, ra2 = null;\n" +
>				"	           ^^^\n" +
>				"Resource 'ra1' should be managed by try-with-resource\n" +
>				"----------\n" +
>				"2. ERROR in X.java (at line 15)\n" +
>				"	ra2 = new FileReader(file);\n" +
>				"	^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>				"Resource leak: 'ra2' is never closed\n" +
>				"----------\n" +
>				"3. ERROR in X.java (at line 16)\n" +
>				"	FileReader ra3 = new FileReader(file);\n" +
>				"	           ^^^\n" +
>				"Resource 'ra3' should be managed by try-with-resource\n" +
>				"----------\n" +
>				"4. ERROR in X.java (at line 25)\n" +
>				"	FileReader rb1 = null, rb2 = null;\n" +
>				"	           ^^^\n" +
>				"Resource 'rb1' should be managed by try-with-resource\n" +
>				"----------\n" +
>				"5. ERROR in X.java (at line 28)\n" +
>				"	rb2 = new FileReader(file);\n" +
>				"	^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>				"Resource leak: 'rb2' is never closed\n" +
>				"----------\n" +
>				"6. ERROR in X.java (at line 29)\n" +
>				"	FileReader rb3 = new FileReader(file);\n" +
>				"	           ^^^\n" +
>				"Resource 'rb3' should be managed by try-with-resource\n" +
>				"----------\n";
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        int i01, i02, i03, i04, i05, i06, i07, i08, i09,\n" +
>			"            i11, i12, i13, i14, i15, i16, i17, i18, i19,\n" +
>			"            i21, i22, i23, i24, i25, i26, i27, i28, i29,\n" +
>			"            i31, i32, i33, i34, i35, i36, i37, i38, i39,\n" +
>			"            i41, i42, i43, i44, i45, i46, i47, i48, i49;\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader ra1 = null, ra2 = null;\n" +
>			"        try {\n" +
>			"            ra1 = new FileReader(file);\n" +
>			"            ra2 = new FileReader(file);\n" +
>			"            FileReader ra3 = new FileReader(file);\n" +
>			"            char[] in = new char[50];\n" +
>			"            ra1.read(in);\n" +
>			"            ra2.read(in);\n" +
>			"            ra3.close();\n" +
>			"        } finally {\n" +
>			"            ra1.close();\n" +
>			"        }\n" +
>			"        int i51, i52, i53, i54, i55, i56, i57, i58, i59, i60;\n" + // beyond this point locals are analyzed using extraBits
>			"        FileReader rb1 = null, rb2 = null;\n" +
>			"        try {\n" +
>			"            rb1 = new FileReader(file);\n" +
>			"            rb2 = new FileReader(file);\n" +
>			"            FileReader rb3 = new FileReader(file);\n" +
>			"            char[] in = new char[50];\n" +
>			"            rb1.read(in);\n" +
>			"            rb2.read(in);\n" +
>			"            rb3.close();\n" +
>			"        } finally {\n" +
>			"            rb1.close();\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		expectedProblems,
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// various non-problems
>public void test056l() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportExplicitlyClosedAutoCloseable, CompilerOptions.ERROR);
>	String expectedProblems = this.complianceLevel >= ClassFileConstants.JDK1_7 ?
>				"----------\n" +
>				"1. ERROR in X.java (at line 8)\n" +
>				"	FileReader fileReader = getReader();\n" +
>				"	           ^^^^^^^^^^\n" +
>				"Resource 'fileReader' should be managed by try-with-resource\n" +
>				"----------\n" +
>				"2. ERROR in X.java (at line 11)\n" +
>				"	FileReader r3 = getReader();\n" +
>				"	           ^^\n" +
>				"Resource 'r3' should be managed by try-with-resource\n" +
>				"----------\n" +
>				"3. ERROR in X.java (at line 24)\n" +
>				"	FileReader r2 = new FileReader(new File(\"inexist\")); // only potential problem: ctor X below might close r2\n" +
>				"	           ^^\n" +
>				"Potential resource leak: 'r2' may not be closed\n" +
>				"----------\n"
>			:
>				"----------\n" +
>				"1. ERROR in X.java (at line 24)\n" +
>				"	FileReader r2 = new FileReader(new File(\"inexist\")); // only potential problem: ctor X below might close r2\n" +
>				"	           ^^\n" +
>				"Potential resource leak: 'r2' may not be closed\n" +
>				"----------\n";
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    X(FileReader r0) {}\n" + // don't complain against argument
>			"    FileReader getReader() { return null; }\n" +
>			"    void foo(FileReader r1) throws IOException {\n" +
>			"        FileReader fileReader = getReader();\n" +
>			"        if (fileReader == null)\n" +
>			"            return;\n" + // don't complain, resource is actually null
>			"        FileReader r3 = getReader();\n" +
>			"        if (r3 == null)\n" +
>			"            r3 = new FileReader(new File(\"absent\"));\n" + // don't complain, previous resource is actually null
>			"        try {\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"            r1.read(in);\n" +
>			"        } finally {\n" +
>			"            fileReader.close();\n" +
>			"            r3.close();\n" +  // the effect of this close() call might be spoiled by exception in fileReader.close() above, but we ignore exception exits in the analysis
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        FileReader r2 = new FileReader(new File(\"inexist\")); // only potential problem: ctor X below might close r2\n" +
>			"        new X(r2).foo(new FileReader(new File(\"notthere\")));\n" +
>			"    }\n" +
>			"}\n"
>		},
>		expectedProblems,
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// nested try with early exit
>public void test056m() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() {\n" +
>			"        File file = new File(\"somefile\");" +
>			"        try {\n" +
>			"            FileReader fileReader = new FileReader(file);\n" +
>			"            try {\n" +
>			"                char[] in = new char[50];\n" +
>			"                if (fileReader.read(in)==0)\n" +
>			"                    return;\n" +
>			"            } finally {\n" +
>			"		         fileReader.close();\n" +
>			"            }\n" +
>			"        } catch (IOException e) {\n" +
>			"            System.out.println(\"caught\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"caught", /*output*/
>		null/*classLibs*/,
>		true/*shouldFlush*/,
>		null/*vmargs*/,
>		options,
>		null/*requestor*/);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// nested try should not interfere with earlier analysis.
>public void test056n() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"import java.io.FileNotFoundException;\n" +
>			"public class X {\n" +
>			"    void foo(File someFile, char[] buf) throws IOException {\n" +
>			"		FileReader fr1 = new FileReader(someFile);\n" +
>			"		try {\n" +
>			"			fr1.read(buf);\n" +
>			"		} finally {\n" +
>			"			fr1.close();\n" +
>			"		}\n" +
>			"		try {\n" +
>			"			FileReader fr3 = new FileReader(someFile);\n" +
>			"			try {\n" +
>			"			} finally {\n" +
>			"				fr3.close();\n" +
>			"			}\n" +
>			"		} catch (IOException e) {\n" +
>			"		}\n" +
>			"	 }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        try {\n" +
>			"            new X().foo(new File(\"missing\"), new char[100]);\n" +
>			"        } catch (FileNotFoundException e) {\n" +
>			"            System.out.println(\"caught\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"caught", /*output*/
>		null/*classLibs*/,
>		true/*shouldFlush*/,
>		null/*vmargs*/,
>		options,
>		null/*requestor*/);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// if close is guarded by null check this should still be recognized as definitely closed
>public void test056o() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"import java.io.FileNotFoundException;\n" +
>			"public class X {\n" +
>			"    void foo(File someFile, char[] buf) throws IOException {\n" +
>			"		FileReader fr1 = null;\n" +
>			"		try {\n" +
>			"           fr1 = new FileReader(someFile);" +
>			"			fr1.read(buf);\n" +
>			"		} finally {\n" +
>			"			if (fr1 != null)\n" +
>			"               try {\n" +
>			"                   fr1.close();\n" +
>			"               } catch (IOException e) { /*do nothing*/ }\n" +
>			"		}\n" +
>			"	 }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        try {\n" +
>			"            new X().foo(new File(\"missing\"), new char[100]);\n" +
>			"        } catch (FileNotFoundException e) {\n" +
>			"            System.out.println(\"caught\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"caught", /*output*/
>		null/*classLibs*/,
>		true/*shouldFlush*/,
>		null/*vmargs*/,
>		options,
>		null/*requestor*/);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// Bug 362332 - Only report potential leak when closeable not created in the local scope
>// a method uses an AutoCloseable without ever closing it, type from a type variable
>public void test056p() {
>	if (this.complianceLevel < ClassFileConstants.JDK1_5) return; // generics used
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.Reader;\n" +
>			"import java.io.IOException;\n" +
>			"public abstract class X <T extends Reader> {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        T fileReader = newReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"    }\n" +
>			"    abstract T newReader(File file) throws IOException;\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X<FileReader>() {\n" +
>			"            FileReader newReader(File f) throws IOException { return new FileReader(f); }\n" +
>			"        }.foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 8)\n" +
>		"	T fileReader = newReader(file);\n" +
>		"	  ^^^^^^^^^^\n" +
>		"Potential resource leak: \'fileReader\' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// closed in dead code
>public void test056q() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fileReader = new FileReader(file);\n" +
>			"        char[] in = new char[50];\n" +
>			"        fileReader.read(in);\n" +
>			"        if (2*2 == 4)\n" +
>			"        	return;\n" +
>			"        fileReader.close();\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	FileReader fileReader = new FileReader(file);\n" +
>		"	           ^^^^^^^^^^\n" +
>		"Resource leak: 'fileReader' is never closed\n" +
>		"----------\n" +
>		"2. WARNING in X.java (at line 10)\n" +
>		"	if (2*2 == 4)\n" +
>		"	    ^^^^^^^^\n" +
>		"Comparing identical expressions\n" +
>		"----------\n" +
>		"3. WARNING in X.java (at line 12)\n" +
>		"	fileReader.close();\n" +
>		"	^^^^^^^^^^^^^^^^^^\n" +
>		"Dead code\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// properly closed, dead code in between
>public void test056r() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileReader fr = new FileReader(file);\n" +
>			"  		 Object b = null;\n" +
>			"        fr.close();\n" +
>			"        if (b != null) {\n" +
>			"            fr = new FileReader(file);\n" +
>			"            return;\n" +
>			"        } else {\n" +
>			"            System.out.print(42);\n" +
>			"        }\n" +
>			"        return;     // Should not complain about fr\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 10)\n" +
>		"	if (b != null) {\n" +
>		"            fr = new FileReader(file);\n" +
>		"            return;\n" +
>		"        } else {\n" +
>		"	               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Dead code\n" +
>		"----------\n" +
>		"2. WARNING in X.java (at line 13)\n" +
>		"	} else {\n" +
>		"            System.out.print(42);\n" +
>		"        }\n" +
>		"	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Statement unnecessarily nested within else clause. The corresponding then clause does not complete normally\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// resource inside t-w-r is re-assigned, shouldn't even record an errorLocation
>public void test056s() {
>	if (this.complianceLevel < ClassFileConstants.JDK1_7) return; // t-w-r used
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.IGNORE);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        try (FileReader fileReader = new FileReader(file);) {\n" +
>			"            char[] in = new char[50];\n" +
>			"            fileReader.read(in);\n" +
>			"            fileReader = new FileReader(file);  // debug here\n" +
>			"            fileReader.read(in);\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 10)\n" +
>		"	fileReader = new FileReader(file);  // debug here\n" +
>		"	^^^^^^^^^^\n" +
>		"The resource fileReader of a try-with-resources statement cannot be assigned\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// resource is closed, dead code follows
>public void test056t() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo31() throws IOException {\n" +
>			"        FileReader reader = new FileReader(\"file\"); //warning\n" +
>			"        if (reader != null) {\n" +
>			"            reader.close();\n" +
>			"        } else {\n" +
>			"            // nop\n" +
>			"        }\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo31();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 8)\n" +
>		"	} else {\n" +
>		"            // nop\n" +
>		"        }\n" +
>		"	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Dead code\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// resource is reassigned within t-w-r with different resource
>// was initially broken due to https://bugs.eclipse.org/358827
>public void test056u() {
>	if (this.complianceLevel < ClassFileConstants.JDK1_7) return; // t-w-r used
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo() throws Exception {\n" +
>			"        FileReader reader1 = new FileReader(\"file1\");\n" +
>			"        FileReader reader2 = new FileReader(\"file2\");\n" +
>			"        reader2 = reader1;// this disconnects reader 2\n" +
>			"        try (FileReader reader3 = new FileReader(\"file3\")) {\n" +
>			"            int ch;\n" +
>			"            while ((ch = reader2.read()) != -1) {\n" +
>			"                System.out.println(ch);\n" +
>			"                reader1.read();\n" +
>			"            }\n" +
>			"            reader2 = reader1; // warning 1 regarding original reader1\n" + // this warning was missing
>			"            reader2 = reader1; // warning 2 regarding original reader1\n" +
>			"        } finally {\n" +
>			"            if (reader2 != null) {\n" +
>			"                reader2.close();\n" +
>			"            } else {\n" +
>			"                System.out.println();\n" +
>			"            }\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 5)\n" +
>		"	FileReader reader2 = new FileReader(\"file2\");\n" +
>		"	           ^^^^^^^\n" +
>		"Resource leak: 'reader2' is never closed\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 13)\n" +
>		"	reader2 = reader1; // warning 1 regarding original reader1\n" +
>		"	^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: 'reader1' is not closed at this location\n" +
>		"----------\n" +
>		"3. ERROR in X.java (at line 14)\n" +
>		"	reader2 = reader1; // warning 2 regarding original reader1\n" +
>		"	^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: 'reader1' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// scope-related pbs reported in https://bugs.eclipse.org/349326#c70 and https://bugs.eclipse.org/349326#c82
>public void test056v() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	String expectedProblems = this.complianceLevel >= ClassFileConstants.JDK1_7 ?
>				"----------\n" +
>				"1. ERROR in X.java (at line 4)\n" +
>				"	FileReader reader = new FileReader(\"file\");\n" +
>				"	           ^^^^^^\n" +
>				"Resource leak: 'reader' is never closed\n" +
>				"----------\n" +
>				"2. WARNING in X.java (at line 19)\n" +
>				"	FileReader reader111 = new FileReader(\"file2\");\n" +
>				"	           ^^^^^^^^^\n" +
>				"Resource 'reader111' should be managed by try-with-resource\n" +
>				"----------\n" +
>				"3. ERROR in X.java (at line 42)\n" +
>				"	return;\n" +
>				"	^^^^^^^\n" +
>				"Resource leak: 'reader2' is not closed at this location\n" +
>				"----------\n"
>			:
>				"----------\n" +
>				"1. ERROR in X.java (at line 4)\n" +
>				"	FileReader reader = new FileReader(\"file\");\n" +
>				"	           ^^^^^^\n" +
>				"Resource leak: 'reader' is never closed\n" +
>				"----------\n" +
>				"2. ERROR in X.java (at line 42)\n" +
>				"	return;\n" +
>				"	^^^^^^^\n" +
>				"Resource leak: 'reader2' is not closed at this location\n" +
>				"----------\n";
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    boolean foo1() throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            int ch;\n" +
>			"            while ((ch = reader.read()) != -1) {\n" +
>			"                System.out.println(ch);\n" +
>			"                reader.read();\n" +
>			"            }\n" +
>			"            if (ch > 10) {\n" +
>			"                return true;\n" +
>			"            }\n" +
>			"            return false;\n" + // return while resource from enclosing scope remains unclosed
>			"        } finally {\n" +
>			"        }\n" +
>			"    }\n" +
>			"    void foo111() throws Exception {\n" +
>			"        FileReader reader111 = new FileReader(\"file2\");\n" +
>			"        try {\n" +
>			"            int ch;\n" +
>			"            while ((ch = reader111.read()) != -1) {\n" +
>			"                System.out.println(ch);\n" +
>			"                reader111.read();\n" +
>			"            }\n" +
>			"            return;\n" + // this shouldn't spoil the warning "should be managed with t-w-r"
>			"        } finally {\n" +
>			"            if (reader111 != null) {\n" +
>			"                reader111.close();\n" +
>			"            }\n" +
>			"        }\n" +
>			"    }\n" +
>			"    void foo2() throws Exception {\n" +
>			"        FileReader reader2 = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            int ch;\n" +
>			"            while ((ch = reader2.read()) != -1) {\n" +
>			"                System.out.println(ch);\n" +
>			"                reader2.read();\n" +
>			"            }\n" +
>			"            if (ch > 10) {\n" +
>			"                return;\n" + // potential leak
>			"            }\n" +
>			"        } finally {\n" +
>			"        }\n" +
>			"        reader2.close();\n" + // due to this close we don't say "never closed"
>			"    }\n" +
>			"}\n"
>		},
>		expectedProblems,
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// end of method is dead end, but before we have both a close() and an early return
>public void test056w() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    boolean foo1() throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            int ch;\n" +
>			"            while ((ch = reader.read()) != -1) {\n" +
>			"                System.out.println(ch);\n" +
>			"                reader.read();\n" +
>			"            }\n" +
>			"            if (ch > 10) {\n" +
>			"				 reader.close();\n" +
>			"                return true;\n" +
>			"            }\n" +
>			"            return false;\n" +
>			"        } finally {\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 15)\n" +
>		"	return false;\n" +
>		"	^^^^^^^^^^^^^\n" +
>		"Resource leak: 'reader' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// different early exits, if no close seen report as definitely unclosed
>public void test056x() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo31(boolean b) throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\");\n" +
>			"        if (b) {\n" +
>			"            reader.close();\n" +
>			"        } else {\n" +
>			"            return; // warning\n" +
>			"        }\n" +
>			"    }\n" +
>			"    void foo32(boolean b) throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\"); // warn here\n" +
>			"        return;\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 8)\n" +
>		"	return; // warning\n" +
>		"	^^^^^^^\n" +
>		"Resource leak: 'reader' is not closed at this location\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 12)\n" +
>		"	FileReader reader = new FileReader(\"file\"); // warn here\n" +
>		"	           ^^^^^^\n" +
>		"Resource leak: 'reader' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// nested method passes the resource to outside code
>public void test056y() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.WARNING);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo31(boolean b) throws Exception {\n" +
>			"        final FileReader reader31 = new FileReader(\"file\");\n" +
>			"        new Runnable() {\n" +
>			"            public void run() {\n" +
>			"                foo18(reader31);\n" +
>			"            }\n" +
>			"        }.run();\n" +
>			"    }\n" +
>			"    void foo18(FileReader r18) {\n" +
>			"        // could theoretically close r18;\n" +
>			"    }\n" +
>			"    abstract class ResourceProvider {\n" +
>			"        abstract FileReader provide();" +
>			"    }\n" +
>			"    ResourceProvider provider;" +
>			"    void foo23() throws Exception {\n" +
>			"        final FileReader reader23 = new FileReader(\"file\");\n" +
>			"        provider = new ResourceProvider() {\n" +
>			"            public FileReader provide() {\n" +
>			"                return reader23;\n" +
>			"            }\n" +
>			"        };\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. WARNING in X.java (at line 4)\n" +
>		"	final FileReader reader31 = new FileReader(\"file\");\n" +
>		"	                 ^^^^^^^^\n" +
>		"Potential resource leak: 'reader31' may not be closed\n" +
>		"----------\n" +
>		"2. WARNING in X.java (at line 17)\n" +
>		"	final FileReader reader23 = new FileReader(\"file\");\n" +
>		"	                 ^^^^^^^^\n" +
>		"Potential resource leak: 'reader23' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// resource assigned to second local and is (potentially) closed on the latter
>public void test056z() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo17() throws Exception {\n" +
>			"        FileReader reader17 = new FileReader(\"file\");\n" +
>			"        final FileReader readerCopy = reader17;\n" +
>			"        readerCopy.close();\n" +
>			"    }\n" +
>			"    void foo17a() throws Exception {\n" +
>			"        FileReader reader17a = new FileReader(\"file\");\n" +
>			"        FileReader readerCopya;" +
>			"		 readerCopya = reader17a;\n" +
>			"        bar(readerCopya);\n" + // potentially closes
>			"    }\n" +
>			"    void bar(FileReader r) {}\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 9)\n" +
>		"	FileReader reader17a = new FileReader(\"file\");\n" +
>		"	           ^^^^^^^^^\n" +
>		"Potential resource leak: 'reader17a' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// multiple early exists from nested scopes (always closed)
>public void test056zz() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	runTestsExpectingErrorsOnlyIn17(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo16() throws Exception {\n" +
>			"        FileReader reader16 = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            reader16.close();\n " +
>			"            return;\n" +
>			"        } catch (RuntimeException re) {\n" +
>			"            return;\n" +
>			"        } catch (Error e) {\n" +
>			"            return;\n" +
>			"        } finally {\n" +
>			"            reader16.close();\n " +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 4)\n" +
>		"	FileReader reader16 = new FileReader(\"file\");\n" +
>		"	           ^^^^^^^^\n" +
>		"Resource 'reader16' should be managed by try-with-resource\n" +
>		"----------\n",
>		options);
>}
>// Bug 349326 - [1.7] new warning for missing try-with-resources
>// multiple early exists from nested scopes (never closed)
>public void test056zzz() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo16() throws Exception {\n" +
>			"        FileReader reader16 = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            return;\n" +
>			"        } catch (RuntimeException re) {\n" +
>			"            return;\n" +
>			"        } catch (Error e) {\n" +
>			"            return;\n" +
>			"        } finally {\n" +
>			"            System.out.println();\n " +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 4)\n" +
>		"	FileReader reader16 = new FileReader(\"file\");\n" +
>		"	           ^^^^^^^^\n" +
>		"Resource leak: 'reader16' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 359334 - Analysis for resource leak warnings does not consider exceptions as method exit points
>// explicit throw is a true method exit here
>public void test056throw1() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo2(boolean a, boolean b, boolean c) throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\");\n" +
>			"        if(a)\n" +
>			"            throw new Exception();    //warning 1\n" +
>			"        else if (b)\n" +
>			"            reader.close();\n" +
>			"        else if(c)\n" +
>			"            throw new Exception();    //warning 2\n" +
>			"        reader.close();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 6)\n" +
>		"	throw new Exception();    //warning 1\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: 'reader' is not closed at this location\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 10)\n" +
>		"	throw new Exception();    //warning 2\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: 'reader' is not closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 359334 - Analysis for resource leak warnings does not consider exceptions as method exit points
>// close() within finally provides protection for throw
>public void test056throw2() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	runTestsExpectingErrorsOnlyIn17(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>					"public class X {\n" +
>					"    void foo1() throws Exception {\n" +
>					"        FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>					"        try {\n" +
>					"            reader.read();\n" +
>					"            return;\n" +
>					"        } catch (Exception e) {\n" +
>					"            throw new Exception();\n" +
>					"        } finally {\n" +
>					"            reader.close();\n" +
>					"        }\n" +
>					"    }\n" +
>					"\n" +
>					"    void foo2() throws Exception {\n" +
>					"        FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>					"        try {\n" +
>					"            reader.read();\n" +
>					"            throw new Exception(); // should not warn here\n" +
>					"        } catch (Exception e) {\n" +
>					"            throw new Exception();\n" +
>					"        } finally {\n" +
>					"            reader.close();\n" +
>					"        }\n" +
>					"    }\n" +
>					"\n" +
>					"    void foo3() throws Exception {\n" +
>					"        FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>					"        try {\n" +
>					"            reader.read();\n" +
>					"            throw new Exception();\n" +
>					"        } finally {\n" +
>					"            reader.close();\n" +
>					"        }\n" +
>					"    }\n" +
>					"}\n"
>			},
>			"----------\n" +
>			"1. ERROR in X.java (at line 4)\n" +
>			"	FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>			"	           ^^^^^^\n" +
>			"Resource 'reader' should be managed by try-with-resource\n" +
>			"----------\n" +
>			"2. ERROR in X.java (at line 16)\n" +
>			"	FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>			"	           ^^^^^^\n" +
>			"Resource 'reader' should be managed by try-with-resource\n" +
>			"----------\n" +
>			"3. ERROR in X.java (at line 28)\n" +
>			"	FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>			"	           ^^^^^^\n" +
>			"Resource 'reader' should be managed by try-with-resource\n" +
>			"----------\n",
>			options);
>}
>// Bug 359334 - Analysis for resource leak warnings does not consider exceptions as method exit points
>// close() nested within finally provides protection for throw
>public void test056throw3() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	runTestsExpectingErrorsOnlyIn17(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo2x() throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>			"        try {\n" +
>			"            reader.read();\n" +
>			"            throw new Exception(); // should not warn here\n" +
>			"        } catch (Exception e) {\n" +
>			"            throw new Exception();\n" +
>			"        } finally {\n" +
>			"            if (reader != null)\n" +
>			"                 try {\n" +
>			"                     reader.close();\n" +
>			"                 } catch (java.io.IOException io) {}\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 4)\n" +
>		"	FileReader reader = new FileReader(\"file\"); // propose t-w-r\n" +
>		"	           ^^^^^^\n" +
>		"Resource 'reader' should be managed by try-with-resource\n" +
>		"----------\n",
>		options);
>}
>// Bug 359334 - Analysis for resource leak warnings does not consider exceptions as method exit points
>// additional boolean should shed doubt on whether we reach the close() call
>public void test056throw4() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo2x(boolean b) throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            reader.read();\n" +
>			"            throw new Exception(); // should warn here\n" +
>			"        } catch (Exception e) {\n" +
>			"            throw new Exception(); // should warn here\n" +
>			"        } finally {\n" +
>			"            if (reader != null && b)\n" + // this condition is too strong to protect reader
>			"                 try {\n" +
>			"                     reader.close();\n" +
>			"                 } catch (java.io.IOException io) {}\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	throw new Exception(); // should warn here\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: 'reader' may not be closed at this location\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 9)\n" +
>		"	throw new Exception(); // should warn here\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: 'reader' may not be closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 359334 - Analysis for resource leak warnings does not consider exceptions as method exit points
>// similar to test056throw3() but indirectly calling close(), so doubts remain.
>public void test056throw5() {
>	Map options = getCompilerOptions();
>	options.put(JavaCore.COMPILER_PB_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_POTENTIALLY_UNCLOSED_CLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_EXPLICITLY_CLOSED_AUTOCLOSEABLE, CompilerOptions.ERROR);
>	options.put(JavaCore.COMPILER_PB_DEAD_CODE, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileReader;\n" +
>			"public class X {\n" +
>			"    void foo2x() throws Exception {\n" +
>			"        FileReader reader = new FileReader(\"file\");\n" +
>			"        try {\n" +
>			"            reader.read();\n" +
>			"            throw new Exception(); // should warn 'may not' here\n" +
>			"        } catch (Exception e) {\n" +
>			"            throw new Exception(); // should warn 'may not' here\n" +
>			"        } finally {\n" +
>			"            doClose(reader);\n" +
>			"        }\n" +
>			"    }\n" +
>			"    void doClose(FileReader r) { try { r.close(); } catch (java.io.IOException ex) {}}\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 7)\n" +
>		"	throw new Exception(); // should warn \'may not\' here\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: 'reader' may not be closed at this location\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 9)\n" +
>		"	throw new Exception(); // should warn \'may not\' here\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: 'reader' may not be closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// Bug 360908 - Avoid resource leak warning when the underlying/chained resource is closed explicitly
>// a resource wrapper is not closed but the underlying resource is
>public void test061a() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream  = new FileInputStream(file);\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(fileStream);\n" +
>			"        BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>			"        System.out.println(bis.available());\n" +
>			"        fileStream.close();\n" +
>			"    }\n" +
>			"    void inline() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream;\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(fileStream = new FileInputStream(file));\n" +
>			"        System.out.println(bis.available());\n" +
>			"        fileStream.close();\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        try {\n" +
>			"            new X().foo();\n" +
>			"        } catch (IOException ex) {" +
>			"            System.out.println(\"Got IO Exception\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"Got IO Exception",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a closeable without OS resource is not closed
>public void test061b() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.StringReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        StringReader string  = new StringReader(\"content\");\n" +
>			"        System.out.println(string.read());\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"99", // character 'c'
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a resource wrapper is not closed but the underlying closeable is resource-free
>public void test061c() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.BufferedReader;\n" +
>			"import java.io.StringReader;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        StringReader input = new StringReader(\"content\");\n" +
>			"        BufferedReader br = new BufferedReader(input);\n" +
>			"        BufferedReader doubleWrap = new BufferedReader(br);\n" +
>			"        System.out.println(br.read());\n" +
>			"    }\n" +
>			"    void inline() throws IOException {\n" +
>			"        BufferedReader br = new BufferedReader(new StringReader(\"content\"));\n" +
>			"        System.out.println(br.read());\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        new X().foo();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"99",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a resource wrapper is not closed neither is the underlying resource
>public void test061d() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.WARNING);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream  = new FileInputStream(file);\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(fileStream);\n" +
>			"        BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>			"        System.out.println(bis.available());\n" +
>			"    }\n" +
>			"    void inline() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        BufferedInputStream bis2 = new BufferedInputStream(new FileInputStream(file));\n" +
>			"        System.out.println(bis2.available());\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        try {\n" +
>			"            new X().foo();\n" +
>			"        } catch (IOException ex) {" +
>			"            System.out.println(\"Got IO Exception\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 10)\n" +
>		"	BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>		"	                    ^^^^^^^^^^\n" +
>		"Resource leak: \'doubleWrap\' is never closed\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 15)\n" +
>		"	BufferedInputStream bis2 = new BufferedInputStream(new FileInputStream(file));\n" +
>		"	                    ^^^^\n" +
>		"Resource leak: \'bis2\' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// Bug 361073 - Avoid resource leak warning when the top level resource is closed explicitly
>// a resource wrapper is closed closing also the underlying resource
>public void test061e() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    FileInputStream fis;" +
>			"    void foo() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream  = new FileInputStream(file);\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(fileStream);\n" +
>			"        BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>			"        System.out.println(bis.available());\n" +
>			"        bis.close();\n" +
>			"    }\n" +
>			"    void inline() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        BufferedInputStream bis2 = new BufferedInputStream(fis = new FileInputStream(file));\n" + // field assignment
>			"        System.out.println(bis2.available());\n" +
>			"        bis2.close();\n" +
>			"        FileInputStream fileStream  = null;\n" +
>			"        BufferedInputStream bis3 = new BufferedInputStream(fileStream = new FileInputStream(file));\n" +
>			"        System.out.println(bis3.available());\n" +
>			"        bis3.close();\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        try {\n" +
>			"            new X().foo();\n" +
>			"        } catch (IOException ex) {" +
>			"            System.out.println(\"Got IO Exception\");\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"Got IO Exception",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// Bug 361073 - Avoid resource leak warning when the top level resource is closed explicitly
>// a resource wrapper is closed closing also the underlying resource - original test case
>public void test061f() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	URL url = FileLocator.toFileURL(FileLocator.find(Platform.getBundle("org.eclipse.jdt.core.tests.compiler"), new Path("META-INF/MANIFEST.MF"), null));
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.InputStream;\n" +
>			"import java.io.InputStreamReader;\n" +
>			"import java.io.BufferedReader;\n" +
>			"import java.io.IOException;\n" +
>			"import java.net.URL;\n" +
>			"public class X {\n" +
>			"    boolean loadURL(final URL url) throws IOException {\n" +
>			"        InputStream stream = null;\n" +
>			"        BufferedReader reader = null;\n" +
>			"        try {\n" +
>			"            stream = url.openStream();\n" +
>			"            reader = new BufferedReader(new InputStreamReader(stream));\n" +
>			"            System.out.println(reader.readLine());\n" +
>			"        } finally {\n" +
>			"            try {\n" +
>			"                if (reader != null)\n" +
>			"                    reader.close();\n" +
>			"            } catch (IOException x) {\n" +
>			"            }\n" +
>			"        }\n" +
>			"        return false; // 'stream' may not be closed at this location\n" +
>			"    }\n" +
>			"    public static void main(String[] args) throws IOException {\n" +
>			"        try {\n" +
>			"            new X().loadURL(new URL(\""+url.toString()+"\"));\n" +
>			"        } catch (IOException ex) {\n" +
>			"            System.out.println(\"Got IO Exception\"+ex);\n" +
>			"        }\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"Manifest-Version: 1.0",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// Bug 360908 - Avoid resource leak warning when the underlying/chained resource is closed explicitly
>// Different points in a resource chain are closed
>public void test061g() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void closeMiddle() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream  = new FileInputStream(file);\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(fileStream);\n" +
>			"        BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>			"        System.out.println(bis.available());\n" +
>			"        bis.close();\n" +
>			"    }\n" +
>			"    void closeOuter() throws IOException {\n" +
>			"        File file2 = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream2  = new FileInputStream(file2);\n" +
>			"        BufferedInputStream bis2 = new BufferedInputStream(fileStream2);\n" +
>			"        BufferedInputStream doubleWrap2 = new BufferedInputStream(bis2);\n" +
>			"        System.out.println(bis2.available());\n" +
>			"        doubleWrap2.close();\n" +
>			"    }\n" +
>			"    void neverClosed() throws IOException {\n" +
>			"        File file3 = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream3  = new FileInputStream(file3);\n" +
>			"        BufferedInputStream bis3 = new BufferedInputStream(fileStream3);\n" +
>			"        BufferedInputStream doubleWrap3 = new BufferedInputStream(bis3);\n" +
>			"        System.out.println(doubleWrap3.available());\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 26)\n" +
>		"	BufferedInputStream doubleWrap3 = new BufferedInputStream(bis3);\n" +
>		"	                    ^^^^^^^^^^^\n" +
>		"Resource leak: \'doubleWrap3\' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// Bug 360908 - Avoid resource leak warning when the underlying/chained resource is closed explicitly
>// Different points in a resource chain are potentially closed
>public void test061h() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void closeMiddle(boolean b) throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream  = new FileInputStream(file);\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(fileStream);\n" +
>			"        BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>			"        System.out.println(bis.available());\n" +
>			"        if (b)\n" +
>			"            bis.close();\n" +
>			"    }\n" +
>			"    void closeOuter(boolean b) throws IOException {\n" +
>			"        File file2 = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream2  = new FileInputStream(file2);\n" +
>			"        BufferedInputStream dummy;\n" +
>			"        BufferedInputStream bis2 = (dummy = new BufferedInputStream(fileStream2));\n" +
>			"        BufferedInputStream doubleWrap2 = new BufferedInputStream(bis2);\n" +
>			"        System.out.println(bis2.available());\n" +
>			"        if (b)\n" +
>			"            doubleWrap2.close();\n" +
>			"    }\n" +
>			"    void potAndDef(boolean b) throws IOException {\n" +
>			"        File file3 = new File(\"somefile\");\n" +
>			"        FileInputStream fileStream3  = new FileInputStream(file3);\n" +
>			"        BufferedInputStream bis3 = new BufferedInputStream(fileStream3);\n" +
>			"        BufferedInputStream doubleWrap3 = new BufferedInputStream(bis3);\n" +
>			"        System.out.println(doubleWrap3.available());\n" +
>			"        if (b) bis3.close();\n" +
>			"        fileStream3.close();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 10)\n" +
>		"	BufferedInputStream doubleWrap = new BufferedInputStream(bis);\n" +
>		"	                    ^^^^^^^^^^\n" +
>		"Potential resource leak: \'doubleWrap\' may not be closed\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 20)\n" +
>		"	BufferedInputStream doubleWrap2 = new BufferedInputStream(bis2);\n" +
>		"	                    ^^^^^^^^^^^\n" +
>		"Potential resource leak: \'doubleWrap2\' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// local var is re-used for two levels of wrappers
>public void test061i() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.InputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void closeMiddle() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        InputStream stream  = new FileInputStream(file);\n" +
>			"        stream = new BufferedInputStream(stream);\n" +
>			"        InputStream middle;\n" +
>			"        stream = new BufferedInputStream(middle = stream);\n" +
>			"        System.out.println(stream.available());\n" +
>			"        middle.close();\n" +
>			"    }\n" +
>			"    void closeOuter() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        InputStream stream2  = new FileInputStream(file);\n" +
>			"        stream2 = new BufferedInputStream(stream2);\n" +
>			"        stream2 = new BufferedInputStream(stream2);\n" +
>			"        System.out.println(stream2.available());\n" +
>			"        stream2.close();\n" +
>			"    }\n" +
>			"    void neverClosed() throws IOException {\n" +
>			"        File file = new File(\"somefile\");\n" +
>			"        InputStream stream3  = new FileInputStream(file);\n" +
>			"        stream3 = new BufferedInputStream(stream3);\n" +
>			"        stream3 = new BufferedInputStream(stream3);\n" +
>			"        System.out.println(stream3.available());\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 26)\n" +
>		"	InputStream stream3  = new FileInputStream(file);\n" +
>		"	            ^^^^^^^\n" +
>		"Resource leak: \'stream3\' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// self-wrapping a method argument (caused NPE UnconditionalFlowInfo.markAsDefinitelyNull(..)).
>public void test061j() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.InputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo(InputStream stream) throws IOException {\n" +
>			"        stream = new BufferedInputStream(stream);\n" +
>			"        System.out.println(stream.available());\n" +
>			"        stream.close();\n" +
>			"    }\n" +
>			"    void boo(InputStream stream2) throws IOException {\n" +
>			"        stream2 = new BufferedInputStream(stream2);\n" +
>			"        System.out.println(stream2.available());\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a wrapper is created in a return statement
>public void test061k() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    BufferedInputStream getReader(File file) throws IOException {\n" +
>			"        FileInputStream stream = new FileInputStream(file);\n" +
>			"        return new BufferedInputStream(stream);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a closeable is assigned to a field
>public void test061l() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    BufferedInputStream stream;\n" +
>			"    void foo(File file) throws IOException {\n" +
>			"        FileInputStream s = new FileInputStream(file);\n" +
>			"        stream = new BufferedInputStream(s);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a closeable is passed to another method in a return statement
>// example constructed after org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository#getArtifact(..)
>public void test061m() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.InputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    BufferedInputStream stream;\n" +
>			"    BufferedInputStream foo(File file) throws IOException {\n" +
>			"        FileInputStream s = new FileInputStream(file);\n" +
>			"        return check(new BufferedInputStream(s));\n" +
>			"    }\n" +
>			"    BufferedInputStream foo2(FileInputStream s, File file) throws IOException {\n" +
>			"        s = new FileInputStream(file);\n" +
>			"        return check(s);\n" +
>			"    }\n" +
>			"    BufferedInputStream foo3(InputStream s) throws IOException {\n" +
>			"        s = check(s);\n" +
>			"        return check(s);\n" +
>			"    }\n" +
>			"    BufferedInputStream check(InputStream s) { return null; }\n" +
>			"}\n"
>		},
>		// TODO: also these warnings *might* be avoidable by detecting check(s) as a wrapper creation??
>		"----------\n" +
>		"1. ERROR in X.java (at line 14)\n" +
>		"	return check(s);\n" +
>		"	^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: \'s\' may not be closed at this location\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 18)\n" +
>		"	return check(s);\n" +
>		"	^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: \'s\' may not be closed at this location\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 358903 - Filter practically unimportant resource leak warnings
>// a resource wrapper does not wrap a provided resource
>public void test061n() {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.PrintWriter;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        PrintWriter writer = new PrintWriter(\"filename\");\n" +
>			"        writer.write(1);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" + 
>		"1. ERROR in X.java (at line 5)\n" + 
>		"	PrintWriter writer = new PrintWriter(\"filename\");\n" + 
>		"	            ^^^^^^\n" + 
>		"Resource leak: \'writer\' is never closed\n" + 
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 362331 - Resource leak not detected when closeable not assigned to variable
>// a resource is never assigned
>public void test062a() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileOutputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        new FileOutputStream(new File(\"C:\\temp\\foo.txt\")).write(1);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 6)\n" +
>		"	new FileOutputStream(new File(\"C:\\temp\\foo.txt\")).write(1);\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: \'<unassigned Closeable value>\' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 362331 - Resource leak not detected when closeable not assigned to variable
>// a freshly allocated resource is immediately closed
>public void test062b() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileOutputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        new FileOutputStream(new File(\"C:\\temp\\foo.txt\")).close();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 362331 - Resource leak not detected when closeable not assigned to variable
>// a resource is directly passed to another method
>public void test062c() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileOutputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        writeIt(new FileOutputStream(new File(\"C:\\temp\\foo.txt\")));\n" +
>			"    }\n" +
>			"    void writeIt(FileOutputStream fos) throws IOException {\n" +
>			"        fos.write(1);\n" +
>			"        fos.close();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 362331 - Resource leak not detected when closeable not assigned to variable
>// a resource is not used
>public void test062d() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileOutputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo() throws IOException {\n" +
>			"        new FileOutputStream(new File(\"C:\\temp\\foo.txt\"));\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 6)\n" +
>		"	new FileOutputStream(new File(\"C:\\temp\\foo.txt\"));\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Resource leak: \'<unassigned Closeable value>\' is never closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 362332 - Only report potential leak when closeable not created in the local scope
>// a wrapper is obtained from another method
>public void test063a() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runNegativeTest(
>		new String[] {
>			"X.java",
>			"import java.io.File;\n" +
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void read(File file) throws IOException {\n" +
>			"        FileInputStream stream = new FileInputStream(file);\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(stream); // never since reassigned\n" +
>			"        FileInputStream stream2 = new FileInputStream(file); // unsure since passed to method\n" +
>			"        bis = getReader(stream2); // unsure since obtained from method\n" +
>			"        bis.available();\n" +
>			"    }\n" +
>			"    BufferedInputStream getReader(FileInputStream stream) throws IOException {\n" +
>			"        return new BufferedInputStream(stream);\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 8)\n" +
>		"	BufferedInputStream bis = new BufferedInputStream(stream); // never since reassigned\n" +
>		"	                    ^^^\n" +
>		"Resource leak: \'bis\' is never closed\n" +
>		"----------\n" +
>		"2. ERROR in X.java (at line 9)\n" +
>		"	FileInputStream stream2 = new FileInputStream(file); // unsure since passed to method\n" +
>		"	                ^^^^^^^\n" +
>		"Potential resource leak: \'stream2\' may not be closed\n" +
>		"----------\n" +
>		"3. ERROR in X.java (at line 10)\n" +
>		"	bis = getReader(stream2); // unsure since obtained from method\n" +
>		"	^^^^^^^^^^^^^^^^^^^^^^^^\n" +
>		"Potential resource leak: \'bis\' may not be closed\n" +
>		"----------\n",
>		null,
>		true,
>		options);
>}
>// Bug 362332 - Only report potential leak when closeable not created in the local scope
>// a wrapper is obtained from a field read
>public void test063b() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    FileInputStream stream;\n" +
>			"    void read() throws IOException {\n" +
>			"        FileInputStream s = this.stream;\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(s); // don't complain since s is obtained from a field\n" +
>			"        bis.available();\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 362332 - Only report potential leak when closeable not created in the local scope
>// a wrapper is assigned to a field
>public void test063c() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	this.runConformTest(
>		new String[] {
>			"X.java",
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    BufferedInputStream stream;\n" +
>			"    void read() throws IOException {\n" +
>			"        FileInputStream s = new FileInputStream(\"somefile\");\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(s);\n" +
>			"        this.stream = bis;\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"",
>		null,
>		true,
>		null,
>		options,
>		null);
>}
>// Bug 362332 - Only report potential leak when closeable not created in the local scope
>// a resource is obtained as a method argument and/or assigned with a cast
>public void test063d() throws IOException {
>	Map options = getCompilerOptions();
>	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
>	options.put(CompilerOptions.OPTION_ReportExplicitlyClosedAutoCloseable, CompilerOptions.ERROR);
>	runTestsExpectingErrorsOnlyIn17(
>		new String[] {
>			"X.java",
>			"import java.io.FileInputStream;\n" +
>			"import java.io.BufferedInputStream;\n" +
>			"import java.io.InputStream;\n" +
>			"import java.io.IOException;\n" +
>			"public class X {\n" +
>			"    void foo( InputStream input) throws IOException {\n" +
>			"        FileInputStream input1  = (FileInputStream)input;\n" +
>			"        System.out.println(input1.read());\n" +
>			"        input.close();\n" + // don't propose t-w-r for argument
>			"    }\n" +
>			"    void foo() throws IOException {\n" +
>			"        InputStream input = new FileInputStream(\"somefile\");\n" +
>			"        FileInputStream input1  = (FileInputStream)input;\n" +
>			"        System.out.println(input1.read());\n" +
>			"        input.close();\n" + // do propose t-w-r, not from a method argument
>			"    }\n" +
>			"    void foo3( InputStream input, InputStream input2) throws IOException {\n" +
>			"        FileInputStream input1  = (FileInputStream)input;\n" + // still don't claim because obtained from outside
>			"        System.out.println(input1.read());\n" +
>			"        BufferedInputStream bis = new BufferedInputStream(input2);\n" +
>			"        System.out.println(bis.read());\n" +
>			"    }\n" +
>			"}\n"
>		},
>		"----------\n" +
>		"1. ERROR in X.java (at line 12)\n" +
>		"	InputStream input = new FileInputStream(\"somefile\");\n" +
>		"	            ^^^^^\n" +
>		"Resource \'input\' should be managed by try-with-resource\n" +
>		"----------\n",
>		options);
>}
>
>}

Actions: View

Attachments on bug 358903: 208899 | 209082 | 209107 | 209169 | 209179 | 209232 | 209234 | 209276 | 209373 | 209374 | 209384 | 209409 | 209457 | 209460 | 209464 | 209472 | 209482