Attachment 205953 Details for Bug 361922 – Update the ValidateClasspathEntry test to set up an invalid jars rather than non-existing jars

Update the ValidateClasspathEntry test to set up an invalid jars rather than non-existing jars

ValidateClasspathEntryTest.txt (text/plain), 4.56 KB, created by Terry Parker

on 2011-10-25 17:40:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Terry Parker

Created: 2011-10-25 17:40:46 EDT

Size: 4.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.model
>Index: src/org/eclipse/jdt/core/tests/model/ClasspathTests.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ClasspathTests.java,v
>retrieving revision 1.226
>diff -u -r1.226 ClasspathTests.java
>--- src/org/eclipse/jdt/core/tests/model/ClasspathTests.java	4 May 2011 14:47:25 -0000	1.226
>+++ src/org/eclipse/jdt/core/tests/model/ClasspathTests.java	25 Oct 2011 21:29:25 -0000
>@@ -249,6 +249,7 @@
> 	suite.addTest(new ClasspathTests("testInvalidClasspath2"));
> 	suite.addTest(new ClasspathTests("testInvalidExternalClassFolder"));
> 	suite.addTest(new ClasspathTests("testInvalidExternalJar"));
>+	suite.addTest(new ClasspathTests("testTransitionFromInvalidToValidJar"));
> 	suite.addTest(new ClasspathTests("testInvalidInternalJar1"));
> 	suite.addTest(new ClasspathTests("testInvalidInternalJar2"));
> 	suite.addTest(new ClasspathTests("testInvalidSourceFolder"));
>@@ -334,6 +335,7 @@
> 	suite.addTest(new ClasspathTests("testBug321170"));
> 	suite.addTest(new ClasspathTests("testBug229042"));
> 	suite.addTest(new ClasspathTests("testBug274737"));
>+	suite.addTest(new ClasspathTests("testBug357425"));
> 	return suite;
> }
> public void setUpSuite() throws Exception {
>@@ -4201,6 +4203,43 @@
> 	}
> }
> /*
>+ * Ensures that validateClasspathEntry() sees a transition from an invalid/missing jar to a valid jar.
>+ */
>+public void testTransitionFromInvalidToValidJar() throws CoreException, IOException {
>+	String transitioningJarName = "transitioningJar.jar";
>+	String transitioningJar = getExternalPath() + transitioningJarName;
>+	String invalidJar = getExternalPath() + "invalidJar.jar";
>+	IClasspathEntry transitioningEntry = JavaCore.newLibraryEntry(new Path(transitioningJar), null, null);
>+	IClasspathEntry nonExistingEntry = JavaCore.newLibraryEntry(new Path(invalidJar), null, null);
>+
>+	try {
>+		Util.createFile(transitioningJar, "");
>+		Util.createFile(invalidJar, "");
>+		IJavaProject proj = createJavaProject("P", new String[] {}, new String[] {transitioningJar, invalidJar}, "bin");
>+		
>+		IJavaModelStatus status1 = ClasspathEntry.validateClasspathEntry(proj, transitioningEntry, false, false);
>+		IJavaModelStatus status2 = ClasspathEntry.validateClasspathEntry(proj, nonExistingEntry, false, false);
>+		assertFalse("Non-existing jar should be invalid", status1.isOK());
>+		assertFalse("Non-existing jar should be invalid", status2.isOK());
>+
>+		Util.createJar(	
>+			new String[0],
>+			new String[] {
>+				"META-INF/MANIFEST.MF",
>+				"Manifest-Version: 1.0\n"
>+			},
>+			transitioningJar,
>+			JavaCore.VERSION_1_4);
>+		status1 = ClasspathEntry.validateClasspathEntry(proj, transitioningEntry, false, false);
>+		status2 = ClasspathEntry.validateClasspathEntry(proj, nonExistingEntry, false, false);
>+		assertTrue("Existing jar should be valid", status1.isOK());
>+		assertFalse("Non-existing jar should be invalid", status2.isOK());
>+	} finally {
>+		deleteExternalResource(transitioningJarName);
>+		deleteProject("P");
>+	}
>+}
>+/*
>  * Ensures that a non existing internal jar cannot be put on the classpath.
>  */
> public void testInvalidInternalJar1() throws CoreException {
>@@ -7190,4 +7229,46 @@
> 	}
> }
> 
>+/*
>+ * Ensures that the correct delta is reported when changing the Class-Path: clause 
>+ * of an external jar from not containing a chained jar to containing a chained jar.
>+ * (regression test for https://bugs.eclipse.org/bugs/show_bug.cgi?id=357425)
>+ */
>+public void testBug357425() throws Exception {
>+	try {
>+		IJavaProject p = createJavaProject("P");
>+		addExternalLibrary(p, getExternalResourcePath("lib357425_a.jar"), new String[0], 
>+			new String[] {
>+				"META-INF/MANIFEST.MF",
>+				"Manifest-Version: 1.0\n"
>+			},
>+			JavaCore.VERSION_1_4);
>+		refreshExternalArchives(p);		
>+
>+		startDeltas();
>+		org.eclipse.jdt.core.tests.util.Util.createJar(new String[0],
>+			new String[] {
>+				"META-INF/MANIFEST.MF",
>+				"Manifest-Version: 1.0\n" +
>+				"Class-Path: lib357425_b.jar\n",
>+			},
>+			getExternalResourcePath("lib357425_a.jar"),
>+			JavaCore.VERSION_1_4);
>+		createExternalFile("lib357425_b.jar", "");
>+
>+		refreshExternalArchives(p);
>+		assertDeltas(
>+			"Unexpected delta",
>+			"P[*]: {CHILDREN | RESOLVED CLASSPATH CHANGED}\n" + 
>+			"	"+ getExternalPath() + "lib357425_a.jar[*]: {CONTENT | REORDERED | ARCHIVE CONTENT CHANGED}\n" + 
>+			"	"+ getExternalPath() + "lib357425_b.jar[+]: {}"
>+				);
>+	} finally {
>+		stopDeltas();
>+		deleteProject("P");
>+		deleteExternalResource("lib357425_a.jar");
>+		deleteExternalResource("lib357425_b.jar");
>+	}
>+}
>+
> }

Flags:

amj87.iitr: iplog+

Actions: View

Attachments on bug 361922: 205953 | 206201