Attachment #204806 for bug #360328




// Only the highest compliance level is run; add the VM argument
// -Dcompliance=1.4 (for example) to lower it if needed
static {
//		TESTS_NAMES = new String[] { "testBug360328" };
//		TESTS_NUMBERS = new int[] { 561 };
//		TESTS_RANGE = new int[] { 1, 2049 };
}

			true,
			compilerOptions);
}
// Bug 360328 - [compiler][null] detect null problems in nested code (local class inside a loop)
public void testBug360328() {
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportNullReference, CompilerOptions.ERROR);
	customOptions.put(CompilerOptions.OPTION_ReportRedundantNullCheck, CompilerOptions.ERROR);
	runNegativeTest(
		true, /* flushOutputDir */
		new String[] {
			"X.java",
			"public class X {\n" +
			"    void print4() {\n" +
			"        final String s1 = \"\";\n" +
			"        for (int i=0; i<4; i++)\n" +
			"            new Runnable() {\n" +
			"                public void run() {\n" +
			"                     if (s1 != null)\n" +
			"                         s1.toString();\n" +
			"                }\n" +
			"            }.run();\n" + 
			"    }\n" +
			"    void print16(boolean b) {\n" +
			"        final String s3 = b ? null : \"\";\n" +
			"        for (int i=0; i<16; i++)\n" +
			"            new Runnable() {\n" +
			"                public void run() {\n" +
			"                     s3.toString();\n" +
			"                }\n" +
			"            }.run();\n" + 
			"    }\n" +
			"    void print23() {\n" +
			"        final String s23 = null;\n" +
			"        for (int i=0; i<23; i++)\n" +
			"            new Runnable() {\n" +
			"                public void run() {\n" +
			"                     s23.toString();\n" +
			"                }\n" +
			"            }.run();\n" + 
			"    }\n" +
			"}\n",

		},
		null, /* classLibs */
		customOptions,
		"----------\n" + 
		"1. ERROR in X.java (at line 7)\n" + 
		"	if (s1 != null)\n" + 
		"	    ^^\n" + 
		"Redundant null check: The variable s1 cannot be null at this location\n" + 
		"----------\n" + 
		"2. ERROR in X.java (at line 17)\n" + 
		"	s3.toString();\n" + 
		"	^^\n" + 
		"Potential null pointer access: The variable s3 may be null at this location\n" + 
		"----------\n" + 
		"3. ERROR in X.java (at line 26)\n" + 
		"	s23.toString();\n" + 
		"	^^^\n" + 
		"Null pointer access: The variable s23 can only be null at this location\n" + 
		"----------\n",
		"",/* expected output */
		"",/* expected error */
	    JavacTestOptions.Excuse.EclipseWarningConfiguredAsError);
}
}





import org.eclipse.jdt.core.compiler.*;
import org.eclipse.jdt.internal.compiler.*;
import org.eclipse.jdt.internal.compiler.flow.FlowInfo;
import org.eclipse.jdt.internal.compiler.flow.InitializationFlowContext;
import org.eclipse.jdt.internal.compiler.impl.*;
import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
import org.eclipse.jdt.internal.compiler.codegen.*;

				throw new AbortMethod(this.compilationResult, problem);
		}
	}

	public abstract void analyseCode(ClassScope classScope, InitializationFlowContext initializationContext, FlowInfo info);

	/**
	 * Bind and add argument's binding into the scope of the method




import org.eclipse.jdt.internal.compiler.CompilationResult;
import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
import org.eclipse.jdt.internal.compiler.flow.ExceptionHandlingFlowContext;
import org.eclipse.jdt.internal.compiler.flow.FlowContext;
import org.eclipse.jdt.internal.compiler.flow.FlowInfo;
import org.eclipse.jdt.internal.compiler.flow.InitializationFlowContext;
import org.eclipse.jdt.internal.compiler.impl.CompilerOptions;
import org.eclipse.jdt.internal.compiler.lookup.Binding;
import org.eclipse.jdt.internal.compiler.lookup.ClassScope;

		super(compilationResult);
	}

	public void analyseCode(ClassScope classScope, FlowContext flowContext, FlowInfo flowInfo) {
		// starting of the code analysis for methods
		if (this.ignoreFurtherInvestigation)
			return;


			ExceptionHandlingFlowContext methodContext =
				new ExceptionHandlingFlowContext(
					flowContext,
					this,
					this.binding.thrownExceptions,
					null,

Lines 684-691 Link Here

(-)a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java (-2 / +5 lines)
684	if (method.ignoreFurtherInvestigation)	684	if (method.ignoreFurtherInvestigation)
685	continue;	685	continue;
686	if (method.isInitializationMethod()) {	686	if (method.isInitializationMethod()) {
		687	// pass down the appropriate initializerContext:
687	if (method.isStatic()) { // <clinit>	688	if (method.isStatic()) { // <clinit>
688	method.analyseCode(	689	((Clinit)method).analyseCode(
689	this.scope,	690	this.scope,
690	staticInitializerContext,	691	staticInitializerContext,
691	staticFieldInfo.unconditionalInits().discardNonFieldInitializations().addInitializationsFrom(outerInfo));	692	staticFieldInfo.unconditionalInits().discardNonFieldInitializations().addInitializationsFrom(outerInfo));
Lines 693-699 Link Here
693	((ConstructorDeclaration)method).analyseCode(this.scope, initializerContext, constructorInfo.copy(), flowInfo.reachMode());	694	((ConstructorDeclaration)method).analyseCode(this.scope, initializerContext, constructorInfo.copy(), flowInfo.reachMode());
694	}	695	}
695	} else { // regular method	696	} else { // regular method
696	method.analyseCode(this.scope, null, flowInfo.copy());	697	// pass down the parent flowContext UNLESS it is an initializer context:
		698	FlowContext parentContext = (flowContext instanceof InitializationFlowContext) ? null : flowContext;
		699	((MethodDeclaration)method).analyseCode(this.scope, parentContext, flowInfo.copy());
697	}	700	}
698	}	701	}
699	}	702	}

Return to bug 360328

Lines 47-53 Link Here

(-)a/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/NullReferenceTest.java (-1 / +64 lines)
47	// Only the highest compliance level is run; add the VM argument	47	// Only the highest compliance level is run; add the VM argument
48	// -Dcompliance=1.4 (for example) to lower it if needed	48	// -Dcompliance=1.4 (for example) to lower it if needed
49	static {	49	static {
50	// TESTS_NAMES = new String[] { "test358827" };	50	// TESTS_NAMES = new String[] { "testBug360328" };
51	// TESTS_NUMBERS = new int[] { 561 };	51	// TESTS_NUMBERS = new int[] { 561 };
52	// TESTS_RANGE = new int[] { 1, 2049 };	52	// TESTS_RANGE = new int[] { 1, 2049 };
53	}	53	}
Lines 15124-15127 Link Here
15124	true,	15124	true,
15125	compilerOptions);	15125	compilerOptions);
15126	}	15126	}
		15127	// Bug 360328 - [compiler][null] detect null problems in nested code (local class inside a loop)
		15128	public void testBug360328() {
		15129	Map customOptions = getCompilerOptions();
		15130	customOptions.put(CompilerOptions.OPTION_ReportNullReference, CompilerOptions.ERROR);
		15131	customOptions.put(CompilerOptions.OPTION_ReportRedundantNullCheck, CompilerOptions.ERROR);
		15132	runNegativeTest(
		15133	true, /* flushOutputDir */
		15134	new String[] {
		15135	"X.java",
		15136	"public class X {\n" +
		15137	" void print4() {\n" +
		15138	" final String s1 = \"\";\n" +
		15139	" for (int i=0; i<4; i++)\n" +
		15140	" new Runnable() {\n" +
		15141	" public void run() {\n" +
		15142	" if (s1 != null)\n" +
		15143	" s1.toString();\n" +
		15144	" }\n" +
		15145	" }.run();\n" +
		15146	" }\n" +
		15147	" void print16(boolean b) {\n" +
		15148	" final String s3 = b ? null : \"\";\n" +
		15149	" for (int i=0; i<16; i++)\n" +
		15150	" new Runnable() {\n" +
		15151	" public void run() {\n" +
		15152	" s3.toString();\n" +
		15153	" }\n" +
		15154	" }.run();\n" +
		15155	" }\n" +
		15156	" void print23() {\n" +
		15157	" final String s23 = null;\n" +
		15158	" for (int i=0; i<23; i++)\n" +
		15159	" new Runnable() {\n" +
		15160	" public void run() {\n" +
		15161	" s23.toString();\n" +
		15162	" }\n" +
		15163	" }.run();\n" +
		15164	" }\n" +
		15165	"}\n",
		15166
		15167	},
		15168	null, /* classLibs */
		15169	customOptions,
		15170	"----------\n" +
		15171	"1. ERROR in X.java (at line 7)\n" +
		15172	" if (s1 != null)\n" +
		15173	" ^^\n" +
		15174	"Redundant null check: The variable s1 cannot be null at this location\n" +
		15175	"----------\n" +
		15176	"2. ERROR in X.java (at line 17)\n" +
		15177	" s3.toString();\n" +
		15178	" ^^\n" +
		15179	"Potential null pointer access: The variable s3 may be null at this location\n" +
		15180	"----------\n" +
		15181	"3. ERROR in X.java (at line 26)\n" +
		15182	" s23.toString();\n" +
		15183	" ^^^\n" +
		15184	"Null pointer access: The variable s23 can only be null at this location\n" +
		15185	"----------\n",
		15186	"",/* expected output */
		15187	"",/* expected error */
		15188	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError);
		15189	}
15127	}	15190	}

Lines 12-19 Link Here

(-)a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/AbstractMethodDeclaration.java (-4 lines)
12		12
13	import org.eclipse.jdt.core.compiler.*;	13	import org.eclipse.jdt.core.compiler.*;
14	import org.eclipse.jdt.internal.compiler.*;	14	import org.eclipse.jdt.internal.compiler.*;
15	import org.eclipse.jdt.internal.compiler.flow.FlowInfo;
16	import org.eclipse.jdt.internal.compiler.flow.InitializationFlowContext;
17	import org.eclipse.jdt.internal.compiler.impl.*;	15	import org.eclipse.jdt.internal.compiler.impl.*;
18	import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;	16	import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
19	import org.eclipse.jdt.internal.compiler.codegen.*;	17	import org.eclipse.jdt.internal.compiler.codegen.*;
Lines 68-75 Link Here
68	throw new AbortMethod(this.compilationResult, problem);	66	throw new AbortMethod(this.compilationResult, problem);
69	}	67	}
70	}	68	}
71
72	public abstract void analyseCode(ClassScope classScope, InitializationFlowContext initializationContext, FlowInfo info);
73		69
74	/**	70	/**
75	* Bind and add argument's binding into the scope of the method	71	* Bind and add argument's binding into the scope of the method