Attachment #193589 for bug #328281

Lines 1-5 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/lookup/ClassScope.java (-1 / +5 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2010 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 7-12 Link Here
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 328281 - visibility leaks not detected when analyzing unused field in private class
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.internal.compiler.lookup;	12	package org.eclipse.jdt.internal.compiler.lookup;
12		13
Lines 148-153 Link Here
148	buildMethods();	149	buildMethods();
149		150
150	SourceTypeBinding sourceType = this.referenceContext.binding;	151	SourceTypeBinding sourceType = this.referenceContext.binding;
		152	if (!sourceType.isPrivate() && sourceType.superclass instanceof SourceTypeBinding && sourceType.superclass.isPrivate())
		153	((SourceTypeBinding) sourceType.superclass).tagIndirectlyAccessibleMembers();
		154
151	if (sourceType.isMemberType() && !sourceType.isLocalType())	155	if (sourceType.isMemberType() && !sourceType.isLocalType())
152	((MemberTypeBinding) sourceType).checkSyntheticArgsAndFields();	156	((MemberTypeBinding) sourceType).checkSyntheticArgsAndFields();
153		157

Lines 1-5 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/lookup/ExtraCompilerModifiers.java (-2 / +6 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2009 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 7-12 Link Here
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 328281 - visibility leaks not detected when analyzing unused field in private class
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.internal.compiler.lookup;	12	package org.eclipse.jdt.internal.compiler.lookup;
12		13
Lines 31-37 Link Here
31	final int AccUnresolved = ASTNode.Bit26;	32	final int AccUnresolved = ASTNode.Bit26;
32	final int AccBlankFinal = ASTNode.Bit27; // for blank final variables	33	final int AccBlankFinal = ASTNode.Bit27; // for blank final variables
33	final int AccIsDefaultConstructor = ASTNode.Bit27; // for default constructor	34	final int AccIsDefaultConstructor = ASTNode.Bit27; // for default constructor
34	final int AccLocallyUsed = ASTNode.Bit28; // used to diagnose unused private/local members	35	final int AccLocallyUsed = ASTNode.Bit28; // used to diagnose unused (a) private/local members or (b) members of private classes
		36	// generally set when actual usage has been detected
		37	// or, (b) when member of a private class is exposed via a non-private subclass
		38	// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=328281
35	final int AccVisibilityMASK = ClassFileConstants.AccPublic \| ClassFileConstants.AccProtected \| ClassFileConstants.AccPrivate;	39	final int AccVisibilityMASK = ClassFileConstants.AccPublic \| ClassFileConstants.AccProtected \| ClassFileConstants.AccPrivate;
36		40
37	final int AccOverriding = ASTNode.Bit29; // record fact a method overrides another one	41	final int AccOverriding = ASTNode.Bit29; // record fact a method overrides another one




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 328281 - visibility leaks not detected when analyzing unused field in private class
 *******************************************************************************/
package org.eclipse.jdt.internal.compiler.lookup;


public FieldBinding[] unResolvedFields() {
	return this.fields;
}

public void tagIndirectlyAccessibleMembers() {
	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=328281
	for (int i = 0; i < this.fields.length; i++) {
		if (!this.fields[i].isPrivate())
			this.fields[i].modifiers |= ExtraCompilerModifiers.AccLocallyUsed;
	}
	for (int i = 0; i < this.memberTypes.length; i++) {
		if (!this.memberTypes[i].isPrivate())
			this.memberTypes[i].modifiers |= ExtraCompilerModifiers.AccLocallyUsed;
	}
	if (this.superclass.isPrivate()) 
		if (this.superclass instanceof SourceTypeBinding)  // should always be true because private super type can only be accessed in same CU
			((SourceTypeBinding) this.superclass).tagIndirectlyAccessibleMembers();
}
}




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 328281 - visibility leaks not detected when analyzing unused field in private class
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=296660
// check independence of textual order
public void test099a() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public class X {\n" +
			"   public class C extends B {\n" +
		    "		public void foo(int a) {\n" +
			"			System.out.println(\"Hello\");\n" +    
			"		}\n" +
		    "		public void foo(double a) {\n" +
			"			System.out.println(\"Hello\");\n" +    
			"		}\n" +
			"		public void foo(boolean a) {\n" +
			"			System.out.println(\"Hello\");\n" +    
			"		}\n" +
			"		public void foo(byte a) {\n" +
			"			System.out.println(\"Hello\");\n" +     
			"		}\n" +
		    "   }\n" +
			"   private class B extends A {\n" +
			"		public void foo(int a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"		public void foo(float a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   	public void foo(double a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   	public void foo(char a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   }\n" +
			"   private class A {\n" +
			"    	public void foo(int a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"    	}\n" +
			"	    public void foo(float a) {\n" +
			"   		System.out.println(\"Hello\");\n" + 
			"   	}\n" +
			"   	public void foo(boolean a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"      	public void foo(Integer a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   }\n" + 
			"}\n"
		},
		"----------\n" + 
		"1. WARNING in X.java (at line 2)\n" + 
		"	public class C extends B {\n" + 
		"	             ^\n" + 
		"Access to enclosing constructor X.B() is emulated by a synthetic accessor method\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 16)\n" + 
		"	private class B extends A {\n" + 
		"	              ^\n" + 
		"Access to enclosing constructor X.A() is emulated by a synthetic accessor method\n" + 
		"----------\n" + 
		"3. WARNING in X.java (at line 23)\n" + 
		"	public void foo(double a) {\n" + 
		"	            ^^^^^^^^^^^^^\n" + 
		"The method foo(double) from the type X.B is never used locally\n" + 
		"----------\n" + 
		"4. WARNING in X.java (at line 31)\n" + 
		"	public void foo(int a) {\n" + 
		"	            ^^^^^^^^^^\n" + 
		"The method foo(int) from the type X.A is never used locally\n" + 
		"----------\n" + 
		"5. WARNING in X.java (at line 34)\n" + 
		"	public void foo(float a) {\n" + 
		"	            ^^^^^^^^^^^^\n" + 
		"The method foo(float) from the type X.A is never used locally\n" + 
		"----------\n" + 
		"6. WARNING in X.java (at line 37)\n" + 
		"	public void foo(boolean a) {\n" + 
		"	            ^^^^^^^^^^^^^^\n" + 
		"The method foo(boolean) from the type X.A is never used locally\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=296660
// check usage via super-call
public void test099b() {
	this.runNegativeTest(
		new String[] {
			"X.java",
			"public class X {\n" +
			"    private class A {\n" +
			"    	public void foo(int a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"    	}\n" +
			"	    public void foo(float a) {\n" +
			"   		System.out.println(\"Hello\");\n" + 
			"   	}\n" +
			"   	public void foo(boolean a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"      	public void foo(Integer a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   }\n" + 
			"   private class B extends A {\n" +
			"		public void foo(int a) {\n" +
			"   		super.foo(a);\n" +    
			"   	}\n" +
			"		public void foo(float a) {\n" +
			"   		super.foo(a);\n" +    
			"   	}\n" +
			"   	public void foo(double a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   	public void foo(char a) {\n" +
			"   		System.out.println(\"Hello\");\n" +    
			"   	}\n" +
			"   }\n" +
			"   public class C extends B {\n" +
		    "		public void foo(int a) {\n" +
			"			System.out.println(\"Hello\");\n" +    
			"		}\n" +
		    "		public void foo(double a) {\n" +
			"			super.foo(a);\n" +    
			"		}\n" +
			"		public void foo(boolean a) {\n" +
			"			super.foo(a);\n" +    
			"		}\n" +
			"		public void foo(byte a) {\n" +
			"			System.out.println(\"Hello\");\n" +     
			"		}\n" +
		    "   }\n" +
			"}\n"
		},
		"----------\n" + 
		"1. WARNING in X.java (at line 16)\n" + 
		"	private class B extends A {\n" + 
		"	              ^\n" + 
		"Access to enclosing constructor X.A() is emulated by a synthetic accessor method\n" + 
		"----------\n" + 
		"2. WARNING in X.java (at line 30)\n" + 
		"	public class C extends B {\n" + 
		"	             ^\n" + 
		"Access to enclosing constructor X.B() is emulated by a synthetic accessor method\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=296660
public void test100() {
	this.runNegativeTest(
		new String[] {

Lines 7-13 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/ProgrammingProblemsTest.java (-2 / +77 lines)
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read	10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contributions for
		11	* bug 185682 - Increment/decrement operators mark local variables as read
		12	* bug 328281 - visibility leaks not detected when analyzing unused field in private class
11	*******************************************************************************/	13	*******************************************************************************/
12	package org.eclipse.jdt.core.tests.compiler.regression;	14	package org.eclipse.jdt.core.tests.compiler.regression;
13		15
Lines 36-42 Link Here
36	// Only the highest compliance level is run; add the VM argument	38	// Only the highest compliance level is run; add the VM argument
37	// -Dcompliance=1.4 (for example) to lower it if needed	39	// -Dcompliance=1.4 (for example) to lower it if needed
38	static {	40	static {
39	// TESTS_NAMES = new String[] { "test0055" };	41	// TESTS_NAMES = new String[] { "test0052" };
40	// TESTS_NUMBERS = new int[] { 56 };	42	// TESTS_NUMBERS = new int[] { 56 };
41	// TESTS_RANGE = new int[] { 1, -1 };	43	// TESTS_RANGE = new int[] { 1, -1 };
42	}	44	}
Lines 2125-2130 Link Here
2125	true/shouldFlushOutputDirectory/,	2127	true/shouldFlushOutputDirectory/,
2126	customOptions);	2128	customOptions);
2127	}	2129	}
		2130	//https://bugs.eclipse.org/bugs/show_bug.cgi?id=328281
		2131	public void test0052() {
		2132	Map customOptions = getCompilerOptions();
		2133	customOptions.put(CompilerOptions.OPTION_ReportUnusedPrivateMember, CompilerOptions.ERROR);
		2134	this.runConformTest(
		2135	new String[] {
		2136	"X.java",
		2137	"class X {\n" +
		2138	" Y y = new Y();\n" +
		2139	" private class Y {\n" +
		2140	" int abc;\n" +
		2141	" Y() {\n" +
		2142	" abc++;\n" + // not a relevant usage
		2143	" }\n" +
		2144	" }\n" +
		2145	" class Z extends Y {}\n" + // makes 'abc' externally accessible
		2146	"}"
		2147	},
		2148	"",
		2149	null/classLibraries/,
		2150	true/shouldFlushOutputDirectory/,
		2151	null/vmArguments/,
		2152	customOptions,
		2153	null/requestor/);
		2154	}
		2155	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=328281
		2156	// multi-level inheritance
		2157	public void test0052a() {
		2158	Map customOptions = getCompilerOptions();
		2159	customOptions.put(CompilerOptions.OPTION_ReportUnusedPrivateMember, CompilerOptions.ERROR);
		2160	customOptions.put(CompilerOptions.OPTION_ReportSyntheticAccessEmulation, CompilerOptions.IGNORE);
		2161	this.runConformTest(
		2162	new String[] {
		2163	"Outer.java",
		2164	"class Outer {\n" +
		2165	" private class Inner1 {\n" +
		2166	" int foo;\n" +
		2167	" }\n" +
		2168	" private class Inner2 extends Inner1 { }\n" +
		2169	" class Inner3 extends Inner2 { }\n" + // foo is exposed here
		2170	"}\n"
		2171	},
		2172	"",
		2173	null/classLibraries/,
		2174	true/shouldFlushOutputDirectory/,
		2175	null/vmArguments/,
		2176	customOptions,
		2177	null/requestor/);
		2178	}
		2179	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=328281
		2180	// member type of private
		2181	public void test0052b() {
		2182	Map customOptions = getCompilerOptions();
		2183	customOptions.put(CompilerOptions.OPTION_ReportUnusedPrivateMember, CompilerOptions.ERROR);
		2184	customOptions.put(CompilerOptions.OPTION_ReportSyntheticAccessEmulation, CompilerOptions.IGNORE);
		2185	this.runConformTest(
		2186	new String[] {
		2187	"Outer.java",
		2188	"class Outer {\n" +
		2189	" private class Inner1 {\n" +
		2190	" class Foo{}\n" +
		2191	" }\n" +
		2192	" private class Inner2 extends Inner1 { }\n" +
		2193	" class Inner3 extends Inner2 { }\n" + // Foo is exposed here
2194	"}\n"
2195	},
2196	"",
2197	null/classLibraries/,
2198	true/shouldFlushOutputDirectory/,
2199	null/vmArguments/,
2200	customOptions,
2201	null/requestor/);
2202	}
2128	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=328519	2203	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=328519
2129	public void test0053() throws Exception {	2204	public void test0053() throws Exception {
2130	Map customOptions = getCompilerOptions();	2205	Map customOptions = getCompilerOptions();

Return to bug 328281