Attachment #189260 for bug #222188




						}
					}
				}
				if (typeReference instanceof JavadocQualifiedTypeReference && !scope.isDefinedInSameUnit(resolvedType)) {
					// https://bugs.eclipse.org/bugs/show_bug.cgi?id=222188
					// partially qualified references from a different CU should be warned
					char[][] typeRefName = ((JavadocQualifiedTypeReference) typeReference).getTypeName();
					int skipLength = 0;
					if (topLevelScope.getCurrentPackage() == resolvedType.getPackage()
							&& typeRefName.length < computedCompoundName.length) {
						// https://bugs.eclipse.org/bugs/show_bug.cgi?id=221539: references can be partially qualified
						// in same package and hence if the package name is not given, ignore package name check
						skipLength = resolvedType.fPackage.compoundName.length;
					}
					boolean valid = true;
					if (typeRefName.length == computedCompoundName.length - skipLength) {
						checkQualification: for (int i = 0; i < typeRefName.length; i++) {
							if (!CharOperation.equals(typeRefName[i], computedCompoundName[i + skipLength])) {
								valid = false;
								break checkQualification;
							}
						}
					} else {
						valid = false;
					}
					// report invalid reference
					if (!valid) {
						if (scopeModifiers == -1) scopeModifiers = scope.getDeclarationModifiers();
						scope.problemReporter().javadocInvalidMemberTypeQualification(typeReference.sourceStart, typeReference.sourceEnd, scopeModifiers);
						return;
					}
				}
			}
			/*
			 * https://bugs.eclipse.org/bugs/show_bug.cgi?id=286918




				"}\n"
		});
}
/**
 * @bug 222188: [javadoc] Incorrect usage of inner type not reported
 * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=222188"
 */
public void testBug222188a() {
	// case 1: partially qualified reference in another package
	String[] units = new String[] {
		"pack/Test.java",
		"package pack;\n" +
		"public class Test {\n" +
		"        public interface Inner { }\n" +
		"}\n"
		,
		"pack2/X.java",
		"package pack2;\n" +
		"import pack.Test;\n" +
		"public class X {\n" +
		"/**\n" +
		" * See also {@link Test.Inner} -- error/warning \n" +
		" */\n" +
		"     public void m() { }\n" +
		"}\n"
	};
	runNegativeTest(units,
		// warning - Tag @link: reference not found: Test.Inner
		"----------\n" + 
		"1. ERROR in pack2\\X.java (at line 5)\n" + 
		"	* See also {@link Test.Inner} -- error/warning \n" + 
		"	                  ^^^^^^^^^^\n" + 
		"Javadoc: Invalid member type qualification\n" + 
		"----------\n",
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
	);
}
public void testBug222188b() {
	// case 2: fully but invalid qualified reference in another package
	String[] units = new String[] {
		"pack/Test.java",
		"package pack;\n" +
		"public class Test {\n" +
		"        public interface Inner { }\n" +
		"}\n"
		,
		"pack2/X.java",
		"package pack2;\n" +
		"public class X {\n" +
		"/**\n" +
		" * See also {@link pack.Test.Inners} -- error/warning \n" +
		" */\n" +
		"     public void m() { }\n" +
		"}\n"
	};
	runNegativeTest(units,
		// warning - Tag @link: reference not found: Test.Inner
		"----------\n" + 
		"1. ERROR in pack2\\X.java (at line 4)\n" + 
		"	* See also {@link pack.Test.Inners} -- error/warning \n" + 
		"	                  ^^^^^^^^^^^^^^^^\n" + 
		"Javadoc: pack.Test.Inners cannot be resolved to a type\n" + 
		"----------\n",
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
	);
}

/**
 * @bug 221539: [javadoc] doesn't detect non visible inner class
 * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=221539"
 */
public void testBug221539a() {
	// partially qualified reference in the same package
	String[] units = new String[] {
		"p/Test.java",
		"package p;\n" +
		"/**\n" + 
		" * {@link Test.Inner} not ok for Javadoc\n" + 
		" * {@link Foo.Inner} ok for Javadoc\n" + 
		" */\n" +
		"public class Test extends Foo {\n" +
		"}\n"
		,
		"p/Foo.java",
		"package p;\n" +
		"public class Foo {\n" +
		"	static class Inner {}\n" +
		"}\n"
	};
	runNegativeTest(units,
		// warning - Tag @link: reference not found: Test.Inner
		"----------\n" + 
		"1. ERROR in p\\Test.java (at line 3)\n" + 
		"	* {@link Test.Inner} not ok for Javadoc\n" + 
		"	         ^^^^^^^^^^\n" + 
		"Javadoc: Invalid member type qualification\n" + 
		"----------\n",
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
	);
}
public void testBug221539b() {
	// partially qualified reference in different package
	String[] units = new String[] {
		"p1/Test.java",
		"package p1;\n" +
		"import p2.Foo;\n" + 
		"/**\n" + 
		" * {@link Test.Inner} not ok for Javadoc\n" + 
		" * {@link Foo.Inner} not ok Javadoc\n" + 
		" * {@link p2.Foo.Inner} ok for Javadoc as fully qualified\n" + 
		" */\n" +
		"public class Test extends Foo {\n" +
		"}\n"
		,
		"p2/Foo.java",
		"package p2;\n" +
		"public class Foo {\n" +
		"	public static class Inner {}\n" +
		"}\n"
	};
	runNegativeTest(units,
		// warning - Tag @link: reference not found: Test.Inner
		// warning - Tag @link: reference not found: Foo.Inner
		"----------\n" + 
		"1. ERROR in p1\\Test.java (at line 4)\n" + 
		"	* {@link Test.Inner} not ok for Javadoc\n" + 
		"	         ^^^^^^^^^^\n" + 
		"Javadoc: Invalid member type qualification\n" + 
		"----------\n" + 
		"2. ERROR in p1\\Test.java (at line 5)\n" + 
		"	* {@link Foo.Inner} not ok Javadoc\n" + 
		"	         ^^^^^^^^^\n" + 
		"Javadoc: Invalid member type qualification\n" + 
		"----------\n",
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
	);
}

public void testBug221539c() {
	// case 3: partially qualified references are valid within the same CU
	this.reportInvalidJavadocVisibility = CompilerOptions.PRIVATE;
	runConformTest(
		new String[] {
			"pack/Test.java",
			"package pack;\n" +
			"/**\n" + 
			" * @see Inner.Level2.Level3\n" + 
			" * @see Test.Inner.Level2.Level3\n" + 
			" */\n" + 
			"public class Test {\n" + 
			"	public class Inner {\n" + 
			"		/**\n" + 
			"		 * @see Level3\n" + 
			"		 * @see Level2.Level3\n" + 
			"		 * @see Inner.Level2.Level3\n" + 
			"		 * @see Test.Inner.Level2.Level3\n" + 
			"		 */\n" + 
			"		public class Level2 {\n" + 
			"			class Level3 {\n" + 
			"			}\n" + 
			"		}\n" + 
			"	}\n" + 
			"}\n"
		}
	);
}
}





/*******************************************************************************
 * Copyright (c) 2000, 2011 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at

					+ "	 *\n"
					+ "	 * @see Visibility Valid ref: local class \n"
					+ "	 * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.Visibility Valid ref: local class \n"
					+ "	 * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 */\n"
					+ "public class X {\n"
					+ "	public void s_foo() {\n"

				"	/**\n" +
				"	 * Valid other package visible class fields references\n" +
				"	 *\n" +
				"	 * @see VisibilityPublic#vf_public Valid ref to visible field of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to visible field of other package public inner class\n" +
				"	 */\n" +
				"public class X {\n" +
				"	public void s_foo() {\n" +

					+ "	 * @see VisibilityPackage#unknown Invalid ref to non existent field of other package non visible class\n"
					+ "	 * @see VisibilityPublic#unknown Invalid ref to non existent field of other package class\n"
					+ "	 * @see VisibilityPublic#vf_private Invalid ref to not visible field of other package class\n"
					+ "	 * @see VisibilityPublic.VpPrivate#unknown Invalid ref to a non visible other package private inner class (non existent field)\n"	
					+ "	 * @see VisibilityPublic.VpPublic#unknown Invalid ref to non existent field of other package public inner class\n"
					+ "	 * @see VisibilityPublic.VpPublic#vf_private Invalid ref to not visible field of other package public inner class\n"
					+ "	 */\n"

				"	 * Valid other package visible class methods references \n" +
				"	 * \n" +
				"	 * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
				"	 */\n" +
				"public class X {\n" +
				"	public void s_foo() {\n" +




/*******************************************************************************
 * Copyright (c) 2000, 2011 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at

					+ "	 *\n"
					+ "	 * @see Visibility Valid ref: local class \n"
					+ "	 * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.Visibility Valid ref: local class \n"
					+ "	 * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 */\n"
					+ "	public X() {\n"
					+ "	}\n"

				"	 * Valid other package visible class fields references\n" +
				"	 *\n" +
				"	 * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
				"	 */\n" +
				"	public X() {\n" +
				"	}\n" +

					+ "	 * @see VisibilityPackage#unknown Invalid ref to non existent field of other package non visible class\n"
					+ "	 * @see VisibilityPublic#unknown Invalid ref to non existent field of other package class\n"
					+ "	 * @see VisibilityPublic#vf_private Invalid ref to not visible field of other package class\n"
					+ "	 * @see VisibilityPublic.VpPrivate#unknown Invalid ref to a non visible other package private inner class (non existent field)\n"	
					+ "	 * @see VisibilityPublic.VpPublic#unknown Invalid ref to non existent field of other package public inner class\n"
					+ "	 * @see VisibilityPublic.VpPublic#vf_private Invalid ref to not visible field of other package public inner class\n"
					+ "	 */\n"

				"	 * Valid other package visible class methods references \n" +
				"	 * \n" +
				"	 * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
				"	 */\n" +
				"	public X() {\n" +
				"	}\n" +




/*******************************************************************************
 * Copyright (c) 2000, 2011 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at

					+ "	 *\n"
					+ "	 * @see Visibility Valid ref: local class \n"
					+ "	 * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see AbstractVisibility.AvcPublic Valid ref: visible inherited inner class of local class \n"
					+ "	 * @see test.Visibility Valid ref: local class \n"
					+ "	 * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.AbstractVisibility.AvcPublic Valid ref: visible inherited inner class of local class \n"
					+ "	 */\n"
					+ "	public int x;\n"
					+ "}\n" });

				"	 * Invalid other package non visible class fields references\n" +
				"	 *\n" +
				"	 * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
				"	 */\n" +
				"	public int x;\n" +
				"}\n"

				"	 * Valid other package visible class methods references \n" +
				"	 * \n" +
				"	 * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
				"	 */\n" +
				"	public int x;\n" +
				"}\n"




					+ "	 *\n"
					+ "	 * @see Visibility Valid ref: local class \n"
					+ "	 * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.Visibility Valid ref: local class \n"
					+ "	 * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 */\n"
					+ "public interface IX {\n"
					+ "	public void foo();\n"

				"	 * Valid other package visible class fields references\n" +
				"	 *\n" +
				"	 * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
				"	 */\n" +
				"public interface IX {\n" +
				"	public void foo();\n" +

					+ "	 * @see VisibilityPackage#unknown Invalid ref to non existent field of other package non visible class\n"
					+ "	 * @see VisibilityPublic#unknown Invalid ref to non existent field of other package class\n"
					+ "	 * @see VisibilityPublic#vf_private Invalid ref to not visible field of other package class\n"
					+ "	 * @see VisibilityPublic.VpPrivate#unknown Invalid ref to a non visible other package private inner class (non existent field)\n"	
					+ "	 * @see VisibilityPublic.VpPublic#unknown Invalid ref to non existent field of other package public inner class\n"
					+ "	 * @see VisibilityPublic.VpPublic#vf_private Invalid ref to not visible field of other package public inner class\n"
					+ "	 */\n"

				"	 * Valid other package visible class methods references \n" +
				"	 * \n" +
				"	 * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
				"	 */\n" +
				"public interface IX {\n" +
				"	public void foo();\n" +

					+ "	 *\n"
					+ "	 * @see Visibility Valid ref: local class \n"
					+ "	 * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.Visibility Valid ref: local class \n"
					+ "	 * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 */\n"
					+ "	public void foo();\n"
					+ "}\n" });

				"	 * Invalid other package non visible class fields references\n" +
				"	 *\n" +
				"	 * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
				"	 */\n" +
				"	public void foo();\n" +
				"}\n"

				"	 * Valid other package visible class methods references \n" +
				"	 * \n" +
				"	 * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
				"	 */\n" +
				"	public void foo();\n" +
				"}\n"




					+ "	 *\n"
					+ "	 * @see Visibility Valid ref: local class \n"
					+ "	 * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.Visibility Valid ref: local class \n"
					+ "	 * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
					+ "	 * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
					+ "	 */\n"
					+ "	public void s_foo() {\n"
					+ "	}\n"

				"	 * Valid external classes references \n" +
				"	 *\n" +
				"	 * @see VisibilityPublic Valid ref: visible class through import => no warning on import\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic Valid ref: visible inner class in visible class \n" +
				"	 */\n" +
				"	public void s_foo() {\n" +
				"	}\n" +

					+ "	 * Valid super class field references in the same package\n"
					+ "	 *\n"
					+ "	 * @see Visibility#avf_public Valid ref: visible inherited field\n"
					+ "	 * @see AbstractVisibility.AvcPublic#avf_public Valid ref: visible field of visible inner class\n"
					+ "	 */\n"
					+ "	public void s_foo() {\n"
					+ "	}\n"

				"	/**\n" +
				"	 * Invalid other package non visible class fields references\n" +
				"	 *\n" +
				"	 * @see VisibilityPublic#vf_public Valid ref to visible field of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vf_public Fully Qualified valid ref to visible field of other package public inner class\n" +
				"	 */\n" +
				"	public void s_foo() {\n" +
				"	}\n" +

					+ "	 * Valid package super class methods references\n"
					+ "	 * \n"
					+ "	 * @see Visibility#avm_public() Valid ref: visible inherited method\n"
					+ "	 * @see AbstractVisibility.AvcPublic#avm_public() Valid ref: visible method in visible inner class\n"
					+ "	 * @see test.Visibility#avm_public() Valid ref: visible inherited method\n"
					+ "	 * @see test.AbstractVisibility.AvcPublic#avm_public() Valid ref: visible method in visible inner class\n"
					+ "	 */  \n"
					+ "	public void s_foo() {\n"
					+ "	}\n"

				"	 * Valid other package visible class methods references \n" +
				"	 * \n" +
				"	 * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
				"	 * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
				"	 */\n" +
				"	public void s_foo() {\n" +
				"	}\n" +

Lines 1-5 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTest_1_3.java (-1 / +13 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2010 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 2441-2446 Link Here
2441	" * See also {@link Inner}\n" +	2441	" * See also {@link Inner}\n" +
2442	" ^^^^^\n" +	2442	" ^^^^^\n" +
2443	"Javadoc: Invalid member type qualification\n" +	2443	"Javadoc: Invalid member type qualification\n" +
		2444	"----------\n" +
		2445	"----------\n" +
		2446	"1. ERROR in comment6a\\test\\Invalid2.java (at line 4)\n" +
		2447	" * @see Test.Inner\n" +
		2448	" ^^^^^^^^^^\n" +
		2449	"Javadoc: Invalid member type qualification\n" +
2444	"----------\n"	2450	"----------\n"
2445	);	2451	);
2446	}	2452	}
Lines 2762-2767 Link Here
2762	" * See also {@link Inner}\n" +	2768	" * See also {@link Inner}\n" +
2763	" ^^^^^\n" +	2769	" ^^^^^\n" +
2764	"Javadoc: Invalid member type qualification\n" +	2770	"Javadoc: Invalid member type qualification\n" +
		2771	"----------\n" +
		2772	"----------\n" +
		2773	"1. ERROR in comment6a\\test\\Invalid2.java (at line 4)\n" +
		2774	" * @see Test.Inner\n" +
		2775	" ^^^^^^^^^^\n" +
		2776	"Javadoc: Invalid member type qualification\n" +
2765	"----------\n"	2777	"----------\n"
2766	);	2778	);
2767	}	2779	}

Lines 1-5 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTest_1_4.java (-2 / +14 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2010 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 2661-2667 Link Here
2661	" * See also {@link Inner}\n" +	2661	" * See also {@link Inner}\n" +
2662	" ^^^^^\n" +	2662	" ^^^^^\n" +
2663	"Javadoc: Invalid member type qualification\n" +	2663	"Javadoc: Invalid member type qualification\n" +
2664	"----------\n"	2664	"----------\n" +
		2665	"----------\n" +
		2666	"1. ERROR in comment6a\\test\\Invalid2.java (at line 4)\n" +
		2667	" * @see Test.Inner\n" +
		2668	" ^^^^^^^^^^\n" +
		2669	"Javadoc: Invalid member type qualification\n" +
		2670	"----------\n"
2665	);	2671	);
2666	}	2672	}
2667	public void testBug96237_Public04() {	2673	public void testBug96237_Public04() {
Lines 2982-2987 Link Here
2982	" * See also {@link Inner}\n" +	2988	" * See also {@link Inner}\n" +
2983	" ^^^^^\n" +	2989	" ^^^^^\n" +
2984	"Javadoc: Invalid member type qualification\n" +	2990	"Javadoc: Invalid member type qualification\n" +
		2991	"----------\n" +
		2992	"----------\n" +
		2993	"1. ERROR in comment6a\\test\\Invalid2.java (at line 4)\n" +
		2994	" * @see Test.Inner\n" +
		2995	" ^^^^^^^^^^\n" +
		2996	"Javadoc: Invalid member type qualification\n" +
2985	"----------\n"	2997	"----------\n"
2986	);	2998	);
2987	}	2999	}

Lines 1-5 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTest_1_5.java (-15 / +24 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2010 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 2014-2019 Link Here
2014	" * See also {@link Inner}\n" +	2014	" * See also {@link Inner}\n" +
2015	" ^^^^^\n" +	2015	" ^^^^^\n" +
2016	"Javadoc: Invalid member type qualification\n" +	2016	"Javadoc: Invalid member type qualification\n" +
		2017	"----------\n" +
		2018	"----------\n" +
		2019	"1. ERROR in comment6a\\test\\Invalid2.java (at line 4)\n" +
		2020	" * @see Test.Inner\n" +
		2021	" ^^^^^^^^^^\n" +
		2022	"Javadoc: Invalid member type qualification\n" +
2017	"----------\n",	2023	"----------\n",
2018	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError	2024	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
2019	);	2025	);
Lines 2322-2327 Link Here
2322	" * See also {@link Inner}\n" +	2328	" * See also {@link Inner}\n" +
2323	" ^^^^^\n" +	2329	" ^^^^^\n" +
2324	"Javadoc: Invalid member type qualification\n" +	2330	"Javadoc: Invalid member type qualification\n" +
		2331	"----------\n" +
		2332	"----------\n" +
		2333	"1. ERROR in comment6a\\test\\Invalid2.java (at line 4)\n" +
		2334	" * @see Test.Inner\n" +
		2335	" ^^^^^^^^^^\n" +
		2336	"Javadoc: Invalid member type qualification\n" +
2325	"----------\n",	2337	"----------\n",
2326	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError	2338	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
2327	);	2339	);
Lines 3399-3405 Link Here
3399	" /**\n" +	3411	" /**\n" +
3400	// qualified single type reference	3412	// qualified single type reference
3401	" * @see A3.A4#foo(V)\n" +	3413	" * @see A3.A4#foo(V)\n" +
3402	" * @see A3.A4#foo(Object)\n" +	3414	" * @see p1.A.A1.A2.A3.A4#foo(Object)\n" +
3403	" */\n" +	3415	" */\n" +
3404	" public void foo(V v) {}\n" +	3416	" public void foo(V v) {}\n" +
3405	" }\n" +	3417	" }\n" +
Lines 3445-3452 Link Here
3445	" public class X4<V> extends A4<V> {\n" +	3457	" public class X4<V> extends A4<V> {\n" +
3446	" /**\n" +	3458	" /**\n" +
3447	// fully qualified type reference	3459	// fully qualified type reference
3448	" * @see A.A1.A2.A3.A4#foo(V)\n" +	3460	" * @see p1.A.A1.A2.A3.A4#foo(V)\n" +
3449	" * @see A.A1.A2.A3.A4#foo(Object)\n" +	3461	" * @see p1.A.A1.A2.A3.A4#foo(Object)\n" +
3450	" */\n" +	3462	" */\n" +
3451	" public void foo(V v) {}\n" +	3463	" public void foo(V v) {}\n" +
3452	" }\n" +	3464	" }\n" +
Lines 3457-3464 Link Here
3457	},	3469	},
3458	"----------\n" +	3470	"----------\n" +
3459	"1. ERROR in p2\\X.java (at line 9)\n" +	3471	"1. ERROR in p2\\X.java (at line 9)\n" +
3460	" * @see A.A1.A2.A3.A4#foo(V)\n" +	3472	" * @see p1.A.A1.A2.A3.A4#foo(V)\n" +
3461	" ^^^\n" +	3473	" ^^^\n" +
3462	"Javadoc: The method foo(Object) in the type A.A1.A2.A3.A4 is not applicable for the arguments (V)\n" +	3474	"Javadoc: The method foo(Object) in the type A.A1.A2.A3.A4 is not applicable for the arguments (V)\n" +
3463	"----------\n",	3475	"----------\n",
3464	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError	3476	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
Lines 3754-3762 Link Here
3754	" public class X4 extends A4 {\n" +	3766	" public class X4 extends A4 {\n" +
3755	" /**\n" +	3767	" /**\n" +
3756	// qualified single type reference	3768	// qualified single type reference
3757	" * @see A3.A4#foo(Object)\n" +	3769	" * @see p1.A.A1.A2.A3.A4#foo(Object)\n" +
3758	" * @see A2.A3.A4#foo(Object)\n" +
3759	" * @see A1.A2.A3.A4#foo(Object)\n" +
3760	" */\n" +	3770	" */\n" +
3761	" public void foo(S s) {}\n" +	3771	" public void foo(S s) {}\n" +
3762	" }\n" +	3772	" }\n" +
Lines 3803-3810 Link Here
3803	" public class X6 extends A6 {\n" +	3813	" public class X6 extends A6 {\n" +
3804	" /**\n" +	3814	" /**\n" +
3805	// qualified single type reference	3815	// qualified single type reference
3806	" * @see A5.A6#foo(Object)\n" +	3816	" * @see p1.A.A1.A2.A3.A4.A5.A6#foo(Object)\n" +
3807	" * @see A4.A5.A6#foo(Object)\n" +
3808	" */\n" +	3817	" */\n" +
3809	" public void foo(S s) {}\n" +	3818	" public void foo(S s) {}\n" +
3810	" }\n" +	3819	" }\n" +
Lines 3846-3853 Link Here
3846	" public class X4 extends A4 {\n" +	3855	" public class X4 extends A4 {\n" +
3847	" /**\n" +	3856	" /**\n" +
3848	// fully qualified type reference	3857	// fully qualified type reference
3849	" * @see A.A1.A2.A3.A4#foo(Object)\n" +	3858	" * @see p1.A.A1.A2.A3.A4#foo(Object)\n" +
3850	" * @see A.A1.A2.A3.A4#foo(R)\n" +	3859	" * @see p1.A.A1.A2.A3.A4#foo(R)\n" +
3851	" */\n" +	3860	" */\n" +
3852	" public void foo(R r) {}\n" +	3861	" public void foo(R r) {}\n" +
3853	" }\n" +	3862	" }\n" +
Lines 3858-3865 Link Here
3858	},	3867	},
3859	"----------\n" +	3868	"----------\n" +
3860	"1. ERROR in p2\\X.java (at line 10)\r\n" +	3869	"1. ERROR in p2\\X.java (at line 10)\r\n" +
3861	" * @see A.A1.A2.A3.A4#foo(R)\r\n" +	3870	" * @see p1.A.A1.A2.A3.A4#foo(R)\r\n" +
3862	" ^^^\n" +	3871	" ^^^\n" +
3863	"Javadoc: The method foo(Object) in the type A.A1.A2.A3.A4 is not applicable for the arguments (R)\n" +	3872	"Javadoc: The method foo(Object) in the type A.A1.A2.A3.A4 is not applicable for the arguments (R)\n" +
3864	"----------\n",	3873	"----------\n",
3865	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError	3874	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError

Return to bug 222188

Lines 8653-8656 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocBugsTest.java (-1 / +165 lines)
8653	"}\n"	8653	"}\n"
8654	});	8654	});
8655	}	8655	}
8656	}	8656	/**
		8657	* @bug 222188: [javadoc] Incorrect usage of inner type not reported
		8658	* @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=222188"
		8659	*/
		8660	public void testBug222188a() {
		8661	// case 1: partially qualified reference in another package
		8662	String[] units = new String[] {
		8663	"pack/Test.java",
		8664	"package pack;\n" +
		8665	"public class Test {\n" +
		8666	" public interface Inner { }\n" +
		8667	"}\n"
		8668	,
		8669	"pack2/X.java",
		8670	"package pack2;\n" +
		8671	"import pack.Test;\n" +
		8672	"public class X {\n" +
		8673	"/**\n" +
		8674	" * See also {@link Test.Inner} -- error/warning \n" +
		8675	" */\n" +
		8676	" public void m() { }\n" +
		8677	"}\n"
		8678	};
		8679	runNegativeTest(units,
		8680	// warning - Tag @link: reference not found: Test.Inner
		8681	"----------\n" +
		8682	"1. ERROR in pack2\\X.java (at line 5)\n" +
		8683	" * See also {@link Test.Inner} -- error/warning \n" +
		8684	" ^^^^^^^^^^\n" +
		8685	"Javadoc: Invalid member type qualification\n" +
		8686	"----------\n",
		8687	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
		8688	);
		8689	}
		8690	public void testBug222188b() {
		8691	// case 2: fully but invalid qualified reference in another package
		8692	String[] units = new String[] {
		8693	"pack/Test.java",
		8694	"package pack;\n" +
		8695	"public class Test {\n" +
		8696	" public interface Inner { }\n" +
		8697	"}\n"
		8698	,
		8699	"pack2/X.java",
		8700	"package pack2;\n" +
		8701	"public class X {\n" +
		8702	"/**\n" +
		8703	" * See also {@link pack.Test.Inners} -- error/warning \n" +
		8704	" */\n" +
		8705	" public void m() { }\n" +
		8706	"}\n"
		8707	};
		8708	runNegativeTest(units,
		8709	// warning - Tag @link: reference not found: Test.Inner
		8710	"----------\n" +
		8711	"1. ERROR in pack2\\X.java (at line 4)\n" +
		8712	" * See also {@link pack.Test.Inners} -- error/warning \n" +
		8713	" ^^^^^^^^^^^^^^^^\n" +
		8714	"Javadoc: pack.Test.Inners cannot be resolved to a type\n" +
		8715	"----------\n",
		8716	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
		8717	);
		8718	}
		8719
		8720	/**
8721	* @bug 221539: [javadoc] doesn't detect non visible inner class
8722	* @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=221539"
8723	*/
8724	public void testBug221539a() {
8725	// partially qualified reference in the same package
8726	String[] units = new String[] {
8727	"p/Test.java",
8728	"package p;\n" +
8729	"/**\n" +
8730	" * {@link Test.Inner} not ok for Javadoc\n" +
8731	" * {@link Foo.Inner} ok for Javadoc\n" +
8732	" */\n" +
8733	"public class Test extends Foo {\n" +
8734	"}\n"
8735	,
8736	"p/Foo.java",
8737	"package p;\n" +
8738	"public class Foo {\n" +
8739	" static class Inner {}\n" +
8740	"}\n"
8741	};
8742	runNegativeTest(units,
8743	// warning - Tag @link: reference not found: Test.Inner
8744	"----------\n" +
8745	"1. ERROR in p\\Test.java (at line 3)\n" +
8746	" * {@link Test.Inner} not ok for Javadoc\n" +
8747	" ^^^^^^^^^^\n" +
8748	"Javadoc: Invalid member type qualification\n" +
8749	"----------\n",
8750	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
8751	);
8752	}
8753	public void testBug221539b() {
8754	// partially qualified reference in different package
8755	String[] units = new String[] {
8756	"p1/Test.java",
8757	"package p1;\n" +
8758	"import p2.Foo;\n" +
8759	"/**\n" +
8760	" * {@link Test.Inner} not ok for Javadoc\n" +
8761	" * {@link Foo.Inner} not ok Javadoc\n" +
8762	" * {@link p2.Foo.Inner} ok for Javadoc as fully qualified\n" +
8763	" */\n" +
8764	"public class Test extends Foo {\n" +
8765	"}\n"
8766	,
8767	"p2/Foo.java",
8768	"package p2;\n" +
8769	"public class Foo {\n" +
8770	" public static class Inner {}\n" +
8771	"}\n"
8772	};
8773	runNegativeTest(units,
8774	// warning - Tag @link: reference not found: Test.Inner
8775	// warning - Tag @link: reference not found: Foo.Inner
8776	"----------\n" +
8777	"1. ERROR in p1\\Test.java (at line 4)\n" +
8778	" * {@link Test.Inner} not ok for Javadoc\n" +
8779	" ^^^^^^^^^^\n" +
8780	"Javadoc: Invalid member type qualification\n" +
8781	"----------\n" +
8782	"2. ERROR in p1\\Test.java (at line 5)\n" +
8783	" * {@link Foo.Inner} not ok Javadoc\n" +
8784	" ^^^^^^^^^\n" +
8785	"Javadoc: Invalid member type qualification\n" +
8786	"----------\n",
8787	JavacTestOptions.Excuse.EclipseWarningConfiguredAsError
8788	);
8789	}
8790
8791	public void testBug221539c() {
8792	// case 3: partially qualified references are valid within the same CU
8793	this.reportInvalidJavadocVisibility = CompilerOptions.PRIVATE;
8794	runConformTest(
8795	new String[] {
8796	"pack/Test.java",
8797	"package pack;\n" +
8798	"/**\n" +
8799	" * @see Inner.Level2.Level3\n" +
8800	" * @see Test.Inner.Level2.Level3\n" +
8801	" */\n" +
8802	"public class Test {\n" +
8803	" public class Inner {\n" +
8804	" /**\n" +
8805	" * @see Level3\n" +
8806	" * @see Level2.Level3\n" +
8807	" * @see Inner.Level2.Level3\n" +
8808	" * @see Test.Inner.Level2.Level3\n" +
8809	" */\n" +
8810	" public class Level2 {\n" +
8811	" class Level3 {\n" +
8812	" }\n" +
8813	" }\n" +
8814	" }\n" +
8815	"}\n"
8816	}
8817	);
8818	}
8819	}
8820

Lines 1-5 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTestForField.java (-5 / +5 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2008 IBM Corporation and others.	2	* Copyright (c) 2000, 2011 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 360-369 Link Here
360	+ " *\n"	360	+ " *\n"
361	+ " * @see Visibility Valid ref: local class \n"	361	+ " * @see Visibility Valid ref: local class \n"
362	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"	362	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
363	+ " * @see Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	363	+ " * @see AbstractVisibility.AvcPublic Valid ref: visible inherited inner class of local class \n"
364	+ " * @see test.Visibility Valid ref: local class \n"	364	+ " * @see test.Visibility Valid ref: local class \n"
365	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"	365	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
366	+ " * @see test.Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	366	+ " * @see test.AbstractVisibility.AvcPublic Valid ref: visible inherited inner class of local class \n"
367	+ " */\n"	367	+ " */\n"
368	+ " public int x;\n"	368	+ " public int x;\n"
369	+ "}\n" });	369	+ "}\n" });
Lines 562-568 Link Here
562	" * Invalid other package non visible class fields references\n" +	562	" * Invalid other package non visible class fields references\n" +
563	" *\n" +	563	" *\n" +
564	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +	564	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
565	" * @see VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +	565	" * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
566	" */\n" +	566	" */\n" +
567	" public int x;\n" +	567	" public int x;\n" +
568	"}\n"	568	"}\n"
Lines 1000-1006 Link Here
1000	" * Valid other package visible class methods references \n" +	1000	" * Valid other package visible class methods references \n" +
1001	" * \n" +	1001	" * \n" +
1002	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +	1002	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
1003	" * @see VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +	1003	" * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
1004	" */\n" +	1004	" */\n" +
1005	" public int x;\n" +	1005	" public int x;\n" +
1006	"}\n"	1006	"}\n"

Lines 314-323 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTestForInterface.java (-9 / +9 lines)
314	+ " *\n"	314	+ " *\n"
315	+ " * @see Visibility Valid ref: local class \n"	315	+ " * @see Visibility Valid ref: local class \n"
316	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"	316	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
317	+ " * @see Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	317	+ " * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
318	+ " * @see test.Visibility Valid ref: local class \n"	318	+ " * @see test.Visibility Valid ref: local class \n"
319	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"	319	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
320	+ " * @see test.Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	320	+ " * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
321	+ " */\n"	321	+ " */\n"
322	+ "public interface IX {\n"	322	+ "public interface IX {\n"
323	+ " public void foo();\n"	323	+ " public void foo();\n"
Lines 514-520 Link Here
514	" * Valid other package visible class fields references\n" +	514	" * Valid other package visible class fields references\n" +
515	" *\n" +	515	" *\n" +
516	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +	516	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
517	" * @see VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +	517	" * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
518	" */\n" +	518	" */\n" +
519	"public interface IX {\n" +	519	"public interface IX {\n" +
520	" public void foo();\n" +	520	" public void foo();\n" +
Lines 535-541 Link Here
535	+ " * @see VisibilityPackage#unknown Invalid ref to non existent field of other package non visible class\n"	535	+ " * @see VisibilityPackage#unknown Invalid ref to non existent field of other package non visible class\n"
536	+ " * @see VisibilityPublic#unknown Invalid ref to non existent field of other package class\n"	536	+ " * @see VisibilityPublic#unknown Invalid ref to non existent field of other package class\n"
537	+ " * @see VisibilityPublic#vf_private Invalid ref to not visible field of other package class\n"	537	+ " * @see VisibilityPublic#vf_private Invalid ref to not visible field of other package class\n"
538	+ " * @see VisibilityPublic.VpPrivate#unknown Invalid ref to a non visible other package private inner class (non existent field)\n"	538	+ " * @see VisibilityPublic.VpPrivate#unknown Invalid ref to a non visible other package private inner class (non existent field)\n"
539	+ " * @see VisibilityPublic.VpPublic#unknown Invalid ref to non existent field of other package public inner class\n"	539	+ " * @see VisibilityPublic.VpPublic#unknown Invalid ref to non existent field of other package public inner class\n"
540	+ " * @see VisibilityPublic.VpPublic#vf_private Invalid ref to not visible field of other package public inner class\n"	540	+ " * @see VisibilityPublic.VpPublic#vf_private Invalid ref to not visible field of other package public inner class\n"
541	+ " */\n"	541	+ " */\n"
Lines 932-938 Link Here
932	" * Valid other package visible class methods references \n" +	932	" * Valid other package visible class methods references \n" +
933	" * \n" +	933	" * \n" +
934	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +	934	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
935	" * @see VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +	935	" * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
936	" */\n" +	936	" */\n" +
937	"public interface IX {\n" +	937	"public interface IX {\n" +
938	" public void foo();\n" +	938	" public void foo();\n" +
Lines 1600-1609 Link Here
1600	+ " *\n"	1600	+ " *\n"
1601	+ " * @see Visibility Valid ref: local class \n"	1601	+ " * @see Visibility Valid ref: local class \n"
1602	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"	1602	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
1603	+ " * @see Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	1603	+ " * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
1604	+ " * @see test.Visibility Valid ref: local class \n"	1604	+ " * @see test.Visibility Valid ref: local class \n"
1605	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"	1605	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
1606	+ " * @see test.Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	1606	+ " * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
1607	+ " */\n"	1607	+ " */\n"
1608	+ " public void foo();\n"	1608	+ " public void foo();\n"
1609	+ "}\n" });	1609	+ "}\n" });
Lines 1800-1806 Link Here
1800	" * Invalid other package non visible class fields references\n" +	1800	" * Invalid other package non visible class fields references\n" +
1801	" *\n" +	1801	" *\n" +
1802	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +	1802	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +
1803	" * @see VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +	1803	" * @see test.copy.VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +
1804	" */\n" +	1804	" */\n" +
1805	" public void foo();\n" +	1805	" public void foo();\n" +
1806	"}\n"	1806	"}\n"
Lines 2221-2227 Link Here
2221	" * Valid other package visible class methods references \n" +	2221	" * Valid other package visible class methods references \n" +
2222	" * \n" +	2222	" * \n" +
2223	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +	2223	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
2224	" * @see VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +	2224	" * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
2225	" */\n" +	2225	" */\n" +
2226	" public void foo();\n" +	2226	" public void foo();\n" +
2227	"}\n"	2227	"}\n"

Lines 2006-2015 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTestForMethod.java (-9 / +9 lines)
2006	+ " *\n"	2006	+ " *\n"
2007	+ " * @see Visibility Valid ref: local class \n"	2007	+ " * @see Visibility Valid ref: local class \n"
2008	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"	2008	+ " * @see Visibility.VcPublic Valid ref: visible inner class of local class \n"
2009	+ " * @see Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	2009	+ " * @see AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
2010	+ " * @see test.Visibility Valid ref: local class \n"	2010	+ " * @see test.Visibility Valid ref: local class \n"
2011	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"	2011	+ " * @see test.Visibility.VcPublic Valid ref: visible inner class of local class \n"
2012	+ " * @see test.Visibility.AvcPublic Valid ref: visible inherited inner class of local class \n"	2012	+ " * @see test.AbstractVisibility.AvcPublic Valid ref: visible inner class of local class \n"
2013	+ " */\n"	2013	+ " */\n"
2014	+ " public void s_foo() {\n"	2014	+ " public void s_foo() {\n"
2015	+ " }\n"	2015	+ " }\n"
Lines 2073-2079 Link Here
2073	" * Valid external classes references \n" +	2073	" * Valid external classes references \n" +
2074	" *\n" +	2074	" *\n" +
2075	" * @see VisibilityPublic Valid ref: visible class through import => no warning on import\n" +	2075	" * @see VisibilityPublic Valid ref: visible class through import => no warning on import\n" +
2076	" * @see VisibilityPublic.VpPublic Valid ref: visible inner class in visible class \n" +	2076	" * @see test.copy.VisibilityPublic.VpPublic Valid ref: visible inner class in visible class \n" +
2077	" */\n" +	2077	" */\n" +
2078	" public void s_foo() {\n" +	2078	" public void s_foo() {\n" +
2079	" }\n" +	2079	" }\n" +
Lines 2270-2276 Link Here
2270	+ " * Valid super class field references in the same package\n"	2270	+ " * Valid super class field references in the same package\n"
2271	+ " *\n"	2271	+ " *\n"
2272	+ " * @see Visibility#avf_public Valid ref: visible inherited field\n"	2272	+ " * @see Visibility#avf_public Valid ref: visible inherited field\n"
2273	+ " * @see Visibility.AvcPublic#avf_public Valid ref: visible field of inherited visible inner class\n"	2273	+ " * @see AbstractVisibility.AvcPublic#avf_public Valid ref: visible field of visible inner class\n"
2274	+ " */\n"	2274	+ " */\n"
2275	+ " public void s_foo() {\n"	2275	+ " public void s_foo() {\n"
2276	+ " }\n"	2276	+ " }\n"
Lines 2538-2545 Link Here
2538	" /**\n" +	2538	" /**\n" +
2539	" * Invalid other package non visible class fields references\n" +	2539	" * Invalid other package non visible class fields references\n" +
2540	" *\n" +	2540	" *\n" +
2541	" * @see VisibilityPublic#vf_public Valid ref to not visible field of other package class\n" +	2541	" * @see VisibilityPublic#vf_public Valid ref to visible field of other package class\n" +
2542	" * @see VisibilityPublic.VpPublic#vf_public Valid ref to not visible field of other package public inner class\n" +	2542	" * @see test.copy.VisibilityPublic.VpPublic#vf_public Fully Qualified valid ref to visible field of other package public inner class\n" +
2543	" */\n" +	2543	" */\n" +
2544	" public void s_foo() {\n" +	2544	" public void s_foo() {\n" +
2545	" }\n" +	2545	" }\n" +
Lines 4024-4032 Link Here
4024	+ " * Valid package super class methods references\n"	4024	+ " * Valid package super class methods references\n"
4025	+ " * \n"	4025	+ " * \n"
4026	+ " * @see Visibility#avm_public() Valid ref: visible inherited method\n"	4026	+ " * @see Visibility#avm_public() Valid ref: visible inherited method\n"
4027	+ " * @see Visibility.AvcPublic#avm_public() Valid ref: visible inherited method in visible inner class\n"	4027	+ " * @see AbstractVisibility.AvcPublic#avm_public() Valid ref: visible method in visible inner class\n"
4028	+ " * @see test.Visibility#avm_public() Valid ref: visible inherited method\n"	4028	+ " * @see test.Visibility#avm_public() Valid ref: visible inherited method\n"
4029	+ " * @see test.Visibility.AvcPublic#avm_public() Valid ref: visible inherited method in visible inner class\n"	4029	+ " * @see test.AbstractVisibility.AvcPublic#avm_public() Valid ref: visible method in visible inner class\n"
4030	+ " */ \n"	4030	+ " */ \n"
4031	+ " public void s_foo() {\n"	4031	+ " public void s_foo() {\n"
4032	+ " }\n"	4032	+ " }\n"
Lines 4518-4524 Link Here
4518	" * Valid other package visible class methods references \n" +	4518	" * Valid other package visible class methods references \n" +
4519	" * \n" +	4519	" * \n" +
4520	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +	4520	" * @see VisibilityPublic#vm_public() Valid ref to not visible method of other package class\n" +
4521	" * @see VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +	4521	" * @see test.copy.VisibilityPublic.VpPublic#vm_public() Valid ref to visible method of other package public inner class\n" +
4522	" */\n" +	4522	" */\n" +
4523	" public void s_foo() {\n" +	4523	" public void s_foo() {\n" +
4524	" }\n" +	4524	" }\n" +

Lines 835-840 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/Javadoc.java (+29 lines)
835	}	835	}
836	}	836	}
837	}	837	}
		838	if (typeReference instanceof JavadocQualifiedTypeReference && !scope.isDefinedInSameUnit(resolvedType)) {
		839	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=222188
		840	// partially qualified references from a different CU should be warned
		841	char[][] typeRefName = ((JavadocQualifiedTypeReference) typeReference).getTypeName();
		842	int skipLength = 0;
		843	if (topLevelScope.getCurrentPackage() == resolvedType.getPackage()
		844	&& typeRefName.length < computedCompoundName.length) {
		845	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=221539: references can be partially qualified
		846	// in same package and hence if the package name is not given, ignore package name check
		847	skipLength = resolvedType.fPackage.compoundName.length;
		848	}
		849	boolean valid = true;
		850	if (typeRefName.length == computedCompoundName.length - skipLength) {
		851	checkQualification: for (int i = 0; i < typeRefName.length; i++) {
		852	if (!CharOperation.equals(typeRefName[i], computedCompoundName[i + skipLength])) {
		853	valid = false;
		854	break checkQualification;
		855	}
		856	}
		857	} else {
		858	valid = false;
		859	}
		860	// report invalid reference
		861	if (!valid) {
		862	if (scopeModifiers == -1) scopeModifiers = scope.getDeclarationModifiers();
		863	scope.problemReporter().javadocInvalidMemberTypeQualification(typeReference.sourceStart, typeReference.sourceEnd, scopeModifiers);
		864	return;
		865	}
		866	}
838	}	867	}
839	/*	868	/*
840	* https://bugs.eclipse.org/bugs/show_bug.cgi?id=286918	869	* https://bugs.eclipse.org/bugs/show_bug.cgi?id=286918