Attachment 188566 Details for Bug 313870 – possible fix

[patch] possible fix

patch313870.txt (text/plain), 1.66 KB, created by Ayushman Jain

on 2011-02-09 02:39:12 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ayushman Jain

Created: 2011-02-09 02:39:12 EST

Size: 1.66 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/flow/LoopingFlowContext.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/flow/LoopingFlowContext.java,v
>retrieving revision 1.51
>diff -u -r1.51 LoopingFlowContext.java
>--- compiler/org/eclipse/jdt/internal/compiler/flow/LoopingFlowContext.java	23 Aug 2010 08:41:25 -0000	1.51
>+++ compiler/org/eclipse/jdt/internal/compiler/flow/LoopingFlowContext.java	9 Feb 2011 07:36:21 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2010 IBM Corporation and others.
>+ * Copyright (c) 2000, 2011 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -519,7 +519,7 @@
> 						flowInfo.initsWhenTrue().setReachMode(FlowInfo.UNREACHABLE);
> 					}
> 				}
>-			} else if (this.upstreamNullFlowInfo.isDefinitelyNonNull(local) && !flowInfo.isPotentiallyNull(local)) {    // https://bugs.eclipse.org/bugs/show_bug.cgi?id=291418
>+			} else if (this.upstreamNullFlowInfo.isDefinitelyNonNull(local) && !flowInfo.isPotentiallyNull(local) && !flowInfo.isPotentiallyUnknown(local)) {    // https://bugs.eclipse.org/bugs/show_bug.cgi?id=291418
> 				flowInfo.markAsDefinitelyNonNull(local);
> 				if ((this.tagBits & FlowContext.HIDE_NULL_COMPARISON_WARNING) == 0) {
> 					recordNullReference(local, reference, checkType);

Actions: View | Diff

Attachments on bug 313870: 169480 | 188566 | 188605