Attachment 186766 Details for Bug 333956 – final patch

[patch] final patch

patch333956.txt (text/plain), 7.69 KB, created by Ayushman Jain

on 2011-01-13 13:14:30 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ayushman Jain

Created: 2011-01-13 13:14:30 EST

Size: 7.69 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java,v
>retrieving revision 1.238
>diff -u -r1.238 CompilerOptions.java
>--- compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	11 Jan 2011 14:22:15 -0000	1.238
>+++ compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	13 Jan 2011 18:11:56 -0000
>@@ -136,11 +136,6 @@
> 	public static final String OPTION_IncludeNullInfoFromAsserts = "org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts";  //$NON-NLS-1$
> 	public static final String OPTION_ReportMethodCanBeStatic = "org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic";  //$NON-NLS-1$
> 	public static final String OPTION_ReportMethodCanBePotentiallyStatic = "org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic";  //$NON-NLS-1$
>-	// Backward compatibility
>-	public static final String OPTION_ReportInvalidAnnotation = "org.eclipse.jdt.core.compiler.problem.invalidAnnotation"; //$NON-NLS-1$
>-	public static final String OPTION_ReportMissingAnnotation = "org.eclipse.jdt.core.compiler.problem.missingAnnotation"; //$NON-NLS-1$
>-	public static final String OPTION_ReportMissingJavadoc = "org.eclipse.jdt.core.compiler.problem.missingJavadoc"; //$NON-NLS-1$
>-
> 	/**
> 	 * Possible values for configurable options
> 	 */
>@@ -626,15 +621,18 @@
> 	/**
> 	 * Return all warning option names for use as keys in compiler options maps.
> 	 * @return all warning option names
>-	 * TODO (maxime) revise for ensuring completeness
> 	 */
> 	public static String[] warningOptionNames() {
> 		String[] result = {
> 			OPTION_ReportAnnotationSuperInterface,
> 			OPTION_ReportAssertIdentifier,
> 			OPTION_ReportAutoboxing,
>+			OPTION_ReportComparingIdentical,
> 			OPTION_ReportDeadCode,
>+			OPTION_ReportDeadCodeInTrivialIfStatement,
> 			OPTION_ReportDeprecation,
>+			OPTION_ReportDeprecationInDeprecatedCode,
>+			OPTION_ReportDeprecationWhenOverridingDeprecatedMethod,
> 			OPTION_ReportDiscouragedReference,
> 			OPTION_ReportEmptyStatement,
> 			OPTION_ReportEnumIdentifier,
>@@ -648,16 +646,28 @@
> 			OPTION_ReportIncompleteEnumSwitch,
> 			OPTION_ReportIndirectStaticAccess,
> 			OPTION_ReportInvalidJavadoc,
>+			OPTION_ReportInvalidJavadocTags,
>+			OPTION_ReportInvalidJavadocTagsDeprecatedRef,
>+			OPTION_ReportInvalidJavadocTagsNotVisibleRef,
>+			OPTION_ReportInvalidJavadocTagsVisibility,
> 			OPTION_ReportLocalVariableHiding,
> 			OPTION_ReportMethodCanBePotentiallyStatic,
> 			OPTION_ReportMethodCanBeStatic,
> 			OPTION_ReportMethodWithConstructorName,
> 			OPTION_ReportMissingDeprecatedAnnotation,
>+			OPTION_ReportMissingHashCodeMethod,
> 			OPTION_ReportMissingJavadocComments,
>+			OPTION_ReportMissingJavadocCommentsOverriding,
>+			OPTION_ReportMissingJavadocCommentsVisibility,
> 			OPTION_ReportMissingJavadocTagDescription,
> 			OPTION_ReportMissingJavadocTags,
>+			OPTION_ReportMissingJavadocTagsMethodTypeParameters,
>+			OPTION_ReportMissingJavadocTagsOverriding,
>+			OPTION_ReportMissingJavadocTagsVisibility,
> 			OPTION_ReportMissingOverrideAnnotation,
>+			OPTION_ReportMissingOverrideAnnotationForInterfaceMethodImplementation,
> 			OPTION_ReportMissingSerialVersion,
>+			OPTION_ReportMissingSynchronizedOnInheritedMethod,
> 			OPTION_ReportNoEffectAssignment,
> 			OPTION_ReportNoImplicitStringConversion,
> 			OPTION_ReportNonExternalizedStringLiteral,
>@@ -668,10 +678,14 @@
> 			OPTION_ReportParameterAssignment,
> 			OPTION_ReportPossibleAccidentalBooleanAssignment,
> 			OPTION_ReportPotentialNullReference,
>+			OPTION_ReportRawTypeReference,
> 			OPTION_ReportRedundantNullCheck,
> 			OPTION_ReportRedundantSuperinterface,
>+			OPTION_ReportSpecialParameterHidingField,
> 			OPTION_ReportSyntheticAccessEmulation,
>+			OPTION_ReportTasks,
> 			OPTION_ReportTypeParameterHiding,
>+			OPTION_ReportUnavoidableGenericTypeProblems,
> 			OPTION_ReportUncheckedTypeOperation,
> 			OPTION_ReportUndocumentedEmptyBlock,
> 			OPTION_ReportUnhandledWarningToken,
>@@ -679,10 +693,17 @@
> 			OPTION_ReportUnnecessaryTypeCheck,
> 			OPTION_ReportUnqualifiedFieldAccess,
> 			OPTION_ReportUnusedDeclaredThrownException,
>+			OPTION_ReportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable,
>+			OPTION_ReportUnusedDeclaredThrownExceptionIncludeDocCommentReference,
>+			OPTION_ReportUnusedDeclaredThrownExceptionWhenOverriding,
> 			OPTION_ReportUnusedImport,
>+			OPTION_ReportUnusedLabel,
> 			OPTION_ReportUnusedLocal,
> 			OPTION_ReportUnusedObjectAllocation,
> 			OPTION_ReportUnusedParameter,
>+			OPTION_ReportUnusedParameterIncludeDocCommentReference,
>+			OPTION_ReportUnusedParameterWhenImplementingAbstract,
>+			OPTION_ReportUnusedParameterWhenOverridingConcrete,
> 			OPTION_ReportUnusedPrivateMember,
> 			OPTION_ReportUnusedTypeArgumentsForMethodInvocation,
> 			OPTION_ReportUnusedWarningToken,
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/parser/SelectionJavadocTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/SelectionJavadocTest.java,v
>retrieving revision 1.8
>diff -u -r1.8 SelectionJavadocTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/parser/SelectionJavadocTest.java	27 Jun 2008 16:04:46 -0000	1.8
>+++ src/org/eclipse/jdt/core/tests/compiler/parser/SelectionJavadocTest.java	13 Jan 2011 18:11:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2011 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -173,7 +173,6 @@
> 		optionsMap.put(CompilerOptions.OPTION_DocCommentSupport, CompilerOptions.ENABLED);
> 		optionsMap.put(CompilerOptions.OPTION_ReportInvalidJavadoc, CompilerOptions.WARNING);
> 		optionsMap.put(CompilerOptions.OPTION_ReportInvalidJavadocTags, CompilerOptions.ENABLED);
>-		optionsMap.put(CompilerOptions.OPTION_ReportMissingJavadoc, CompilerOptions.WARNING);
> 	    return optionsMap;
>     }
> 
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/DeprecatedTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/DeprecatedTest.java,v
>retrieving revision 1.41
>diff -u -r1.41 DeprecatedTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/DeprecatedTest.java	18 Mar 2010 16:22:37 -0000	1.41
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/DeprecatedTest.java	13 Jan 2011 18:11:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2010 IBM Corporation and others.
>+ * Copyright (c) 2000, 2011 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -348,7 +348,6 @@
> public void test010() {
> 	Map customOptions = getCompilerOptions();
> 	customOptions.put(CompilerOptions.OPTION_DocCommentSupport, CompilerOptions.ENABLED);
>-	customOptions.put(CompilerOptions.OPTION_ReportInvalidAnnotation, CompilerOptions.WARNING);
> 	this.runNegativeTest(
> 		new String[] {
>             "X.java",

Actions: View | Diff

Attachments on bug 333956: 186496 | 186497 | 186601 | 186766