Attachment 186601 Details for Bug 333956 – proposed fix with few more options

[patch] proposed fix with few more options

patch333956.txt (text/plain), 7.01 KB, created by Ayushman Jain

on 2011-01-12 03:54:09 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ayushman Jain

Created: 2011-01-12 03:54:09 EST

Size: 7.01 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java,v
>retrieving revision 1.238
>diff -u -r1.238 CompilerOptions.java
>--- compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	11 Jan 2011 14:22:15 -0000	1.238
>+++ compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	12 Jan 2011 08:52:04 -0000
>@@ -626,68 +626,97 @@
> 	/**
> 	 * Return all warning option names for use as keys in compiler options maps.
> 	 * @return all warning option names
>-	 * TODO (maxime) revise for ensuring completeness
> 	 */
> 	public static String[] warningOptionNames() {
> 		String[] result = {
>-			OPTION_ReportAnnotationSuperInterface,
>-			OPTION_ReportAssertIdentifier,
>-			OPTION_ReportAutoboxing,
>-			OPTION_ReportDeadCode,
>-			OPTION_ReportDeprecation,
>-			OPTION_ReportDiscouragedReference,
>-			OPTION_ReportEmptyStatement,
>-			OPTION_ReportEnumIdentifier,
>-			OPTION_ReportFallthroughCase,
>-			OPTION_ReportFieldHiding,
>-			OPTION_ReportFinallyBlockNotCompletingNormally,
>-			OPTION_ReportFinalParameterBound,
>-			OPTION_ReportForbiddenReference,
>-			OPTION_ReportHiddenCatchBlock,
>-			OPTION_ReportIncompatibleNonInheritedInterfaceMethod,
>-			OPTION_ReportIncompleteEnumSwitch,
>-			OPTION_ReportIndirectStaticAccess,
>-			OPTION_ReportInvalidJavadoc,
>-			OPTION_ReportLocalVariableHiding,
>-			OPTION_ReportMethodCanBePotentiallyStatic,
>-			OPTION_ReportMethodCanBeStatic,
>-			OPTION_ReportMethodWithConstructorName,
>-			OPTION_ReportMissingDeprecatedAnnotation,
>-			OPTION_ReportMissingJavadocComments,
>-			OPTION_ReportMissingJavadocTagDescription,
>-			OPTION_ReportMissingJavadocTags,
>-			OPTION_ReportMissingOverrideAnnotation,
>-			OPTION_ReportMissingSerialVersion,
>-			OPTION_ReportNoEffectAssignment,
>-			OPTION_ReportNoImplicitStringConversion,
>-			OPTION_ReportNonExternalizedStringLiteral,
>-			OPTION_ReportNonStaticAccessToStatic,
>-			OPTION_ReportNullReference,
>-			OPTION_ReportOverridingMethodWithoutSuperInvocation,
>-			OPTION_ReportOverridingPackageDefaultMethod,
>-			OPTION_ReportParameterAssignment,
>-			OPTION_ReportPossibleAccidentalBooleanAssignment,
>-			OPTION_ReportPotentialNullReference,
>-			OPTION_ReportRedundantNullCheck,
>-			OPTION_ReportRedundantSuperinterface,
>-			OPTION_ReportSyntheticAccessEmulation,
>-			OPTION_ReportTypeParameterHiding,
>-			OPTION_ReportUncheckedTypeOperation,
>-			OPTION_ReportUndocumentedEmptyBlock,
>-			OPTION_ReportUnhandledWarningToken,
>-			OPTION_ReportUnnecessaryElse,
>-			OPTION_ReportUnnecessaryTypeCheck,
>-			OPTION_ReportUnqualifiedFieldAccess,
>-			OPTION_ReportUnusedDeclaredThrownException,
>-			OPTION_ReportUnusedImport,
>-			OPTION_ReportUnusedLocal,
>-			OPTION_ReportUnusedObjectAllocation,
>-			OPTION_ReportUnusedParameter,
>-			OPTION_ReportUnusedPrivateMember,
>-			OPTION_ReportUnusedTypeArgumentsForMethodInvocation,
>-			OPTION_ReportUnusedWarningToken,
>-			OPTION_ReportVarargsArgumentNeedCast,
>-		};
>+				OPTION_ReportMethodWithConstructorName,
>+				OPTION_ReportOverridingPackageDefaultMethod,
>+				OPTION_ReportDeprecation,
>+				OPTION_ReportDeprecationInDeprecatedCode,
>+				OPTION_ReportDeprecationWhenOverridingDeprecatedMethod,
>+				OPTION_ReportHiddenCatchBlock,
>+				OPTION_ReportUnusedLocal,
>+				OPTION_ReportUnusedParameter,
>+				OPTION_ReportUnusedParameterWhenImplementingAbstract,
>+				OPTION_ReportUnusedParameterWhenOverridingConcrete,
>+				OPTION_ReportUnusedParameterIncludeDocCommentReference,
>+				OPTION_ReportUnusedImport,
>+				OPTION_ReportSyntheticAccessEmulation,
>+				OPTION_ReportNoEffectAssignment,
>+				OPTION_ReportLocalVariableHiding,
>+				OPTION_ReportSpecialParameterHidingField,
>+				OPTION_ReportFieldHiding,
>+				OPTION_ReportTypeParameterHiding,
>+				OPTION_ReportPossibleAccidentalBooleanAssignment,
>+				OPTION_ReportNonExternalizedStringLiteral,
>+				OPTION_ReportIncompatibleNonInheritedInterfaceMethod,
>+				OPTION_ReportUnusedPrivateMember,
>+				OPTION_ReportNoImplicitStringConversion,
>+				OPTION_ReportAssertIdentifier,
>+				OPTION_ReportEnumIdentifier,
>+				OPTION_ReportNonStaticAccessToStatic,
>+				OPTION_ReportIndirectStaticAccess,
>+				OPTION_ReportEmptyStatement,
>+				OPTION_ReportUnnecessaryTypeCheck,
>+				OPTION_ReportUnnecessaryElse,
>+				OPTION_ReportUndocumentedEmptyBlock,
>+				OPTION_ReportInvalidJavadoc,
>+				OPTION_ReportInvalidJavadocTags,
>+				OPTION_ReportInvalidJavadocTagsDeprecatedRef,
>+				OPTION_ReportInvalidJavadocTagsNotVisibleRef,
>+				OPTION_ReportInvalidJavadocTagsVisibility,
>+				OPTION_ReportMissingJavadocTags,
>+				OPTION_ReportMissingJavadocTagsVisibility,
>+				OPTION_ReportMissingJavadocTagsOverriding,
>+				OPTION_ReportMissingJavadocTagsMethodTypeParameters,
>+				OPTION_ReportMissingJavadocComments,
>+				OPTION_ReportMissingJavadocTagDescription,
>+				OPTION_ReportMissingJavadocCommentsVisibility,
>+				OPTION_ReportMissingJavadocCommentsOverriding,
>+				OPTION_ReportFinallyBlockNotCompletingNormally,
>+				OPTION_ReportUnusedDeclaredThrownException,
>+				OPTION_ReportUnusedDeclaredThrownExceptionWhenOverriding,
>+				OPTION_ReportUnusedDeclaredThrownExceptionIncludeDocCommentReference,
>+				OPTION_ReportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable,
>+				OPTION_ReportUnqualifiedFieldAccess,
>+				OPTION_ReportUnavoidableGenericTypeProblems,
>+				OPTION_ReportUncheckedTypeOperation,
>+				OPTION_ReportRawTypeReference,
>+				OPTION_ReportFinalParameterBound,
>+				OPTION_ReportMissingSerialVersion,
>+				OPTION_ReportVarargsArgumentNeedCast,
>+				OPTION_ReportUnusedTypeArgumentsForMethodInvocation,
>+				OPTION_ReportNullReference,
>+				OPTION_ReportPotentialNullReference,
>+				OPTION_ReportRedundantNullCheck,
>+				OPTION_ReportAutoboxing,
>+				OPTION_ReportAnnotationSuperInterface,
>+				OPTION_ReportMissingOverrideAnnotation,
>+				OPTION_ReportMissingOverrideAnnotationForInterfaceMethodImplementation,
>+				OPTION_ReportMissingDeprecatedAnnotation,
>+				OPTION_ReportIncompleteEnumSwitch,
>+				OPTION_ReportForbiddenReference,
>+				OPTION_ReportDiscouragedReference,
>+				OPTION_ReportUnhandledWarningToken,
>+				OPTION_ReportUnusedWarningToken,
>+				OPTION_ReportUnusedLabel,
>+				OPTION_ReportParameterAssignment,
>+				OPTION_ReportFallthroughCase,
>+				OPTION_ReportOverridingMethodWithoutSuperInvocation,
>+				OPTION_ReportRedundantSuperinterface,
>+				OPTION_ReportComparingIdentical,
>+				OPTION_ReportMissingSynchronizedOnInheritedMethod,
>+				OPTION_ReportMissingHashCodeMethod,
>+				OPTION_ReportDeadCode,
>+				OPTION_ReportDeadCodeInTrivialIfStatement,
>+				OPTION_ReportTasks,
>+				OPTION_ReportUnusedObjectAllocation,
>+				OPTION_ReportMethodCanBeStatic,
>+				OPTION_ReportMethodCanBePotentiallyStatic,
>+				OPTION_ReportInvalidAnnotation,
>+				OPTION_ReportMissingAnnotation,
>+				OPTION_ReportMissingJavadoc
>+			};
> 		return result;
> 	}
>

Actions: View | Diff

Attachments on bug 333956: 186496 | 186497 | 186601 | 186766