Attachment 186497 Details for Bug 333956 – Proposed fix

[patch] Proposed fix

patch_333956.txt (text/plain), 4.03 KB, created by Olivier Thomann

on 2011-01-11 09:26:18 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2011-01-11 09:26:18 EST

Size: 4.03 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java,v
>retrieving revision 1.238
>diff -u -r1.238 CompilerOptions.java
>--- compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	11 Jan 2011 14:22:15 -0000	1.238
>+++ compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	11 Jan 2011 14:25:19 -0000
>@@ -626,15 +626,18 @@
> 	/**
> 	 * Return all warning option names for use as keys in compiler options maps.
> 	 * @return all warning option names
>-	 * TODO (maxime) revise for ensuring completeness
> 	 */
> 	public static String[] warningOptionNames() {
> 		String[] result = {
> 			OPTION_ReportAnnotationSuperInterface,
> 			OPTION_ReportAssertIdentifier,
> 			OPTION_ReportAutoboxing,
>+			OPTION_ReportComparingIdentical,
> 			OPTION_ReportDeadCode,
>+			OPTION_ReportDeadCodeInTrivialIfStatement,
> 			OPTION_ReportDeprecation,
>+			OPTION_ReportDeprecationInDeprecatedCode,
>+			OPTION_ReportDeprecationWhenOverridingDeprecatedMethod,
> 			OPTION_ReportDiscouragedReference,
> 			OPTION_ReportEmptyStatement,
> 			OPTION_ReportEnumIdentifier,
>@@ -648,16 +651,28 @@
> 			OPTION_ReportIncompleteEnumSwitch,
> 			OPTION_ReportIndirectStaticAccess,
> 			OPTION_ReportInvalidJavadoc,
>+			OPTION_ReportInvalidJavadocTags,
>+			OPTION_ReportInvalidJavadocTagsDeprecatedRef,
>+			OPTION_ReportInvalidJavadocTagsNotVisibleRef,
>+			OPTION_ReportInvalidJavadocTagsVisibility,
> 			OPTION_ReportLocalVariableHiding,
> 			OPTION_ReportMethodCanBePotentiallyStatic,
> 			OPTION_ReportMethodCanBeStatic,
> 			OPTION_ReportMethodWithConstructorName,
> 			OPTION_ReportMissingDeprecatedAnnotation,
>+			OPTION_ReportMissingHashCodeMethod,
> 			OPTION_ReportMissingJavadocComments,
>+			OPTION_ReportMissingJavadocCommentsOverriding,
>+			OPTION_ReportMissingJavadocCommentsVisibility,
> 			OPTION_ReportMissingJavadocTagDescription,
> 			OPTION_ReportMissingJavadocTags,
>+			OPTION_ReportMissingJavadocTagsMethodTypeParameters,
>+			OPTION_ReportMissingJavadocTagsOverriding,
>+			OPTION_ReportMissingJavadocTagsVisibility,
> 			OPTION_ReportMissingOverrideAnnotation,
>+			OPTION_ReportMissingOverrideAnnotationForInterfaceMethodImplementation,
> 			OPTION_ReportMissingSerialVersion,
>+			OPTION_ReportMissingSynchronizedOnInheritedMethod,
> 			OPTION_ReportNoEffectAssignment,
> 			OPTION_ReportNoImplicitStringConversion,
> 			OPTION_ReportNonExternalizedStringLiteral,
>@@ -668,10 +683,14 @@
> 			OPTION_ReportParameterAssignment,
> 			OPTION_ReportPossibleAccidentalBooleanAssignment,
> 			OPTION_ReportPotentialNullReference,
>+			OPTION_ReportRawTypeReference,
> 			OPTION_ReportRedundantNullCheck,
> 			OPTION_ReportRedundantSuperinterface,
>+			OPTION_ReportSpecialParameterHidingField,
> 			OPTION_ReportSyntheticAccessEmulation,
>+			OPTION_ReportTasks,
> 			OPTION_ReportTypeParameterHiding,
>+			OPTION_ReportUnavoidableGenericTypeProblems,
> 			OPTION_ReportUncheckedTypeOperation,
> 			OPTION_ReportUndocumentedEmptyBlock,
> 			OPTION_ReportUnhandledWarningToken,
>@@ -679,10 +698,17 @@
> 			OPTION_ReportUnnecessaryTypeCheck,
> 			OPTION_ReportUnqualifiedFieldAccess,
> 			OPTION_ReportUnusedDeclaredThrownException,
>+			OPTION_ReportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable,
>+			OPTION_ReportUnusedDeclaredThrownExceptionIncludeDocCommentReference,
>+			OPTION_ReportUnusedDeclaredThrownExceptionWhenOverriding,
> 			OPTION_ReportUnusedImport,
>+			OPTION_ReportUnusedLabel,
> 			OPTION_ReportUnusedLocal,
> 			OPTION_ReportUnusedObjectAllocation,
> 			OPTION_ReportUnusedParameter,
>+			OPTION_ReportUnusedParameterIncludeDocCommentReference,
>+			OPTION_ReportUnusedParameterWhenImplementingAbstract,
>+			OPTION_ReportUnusedParameterWhenOverridingConcrete,
> 			OPTION_ReportUnusedPrivateMember,
> 			OPTION_ReportUnusedTypeArgumentsForMethodInvocation,
> 			OPTION_ReportUnusedWarningToken,

Actions: View | Diff

Attachments on bug 333956: 186496 | 186497 | 186601 | 186766