Attachment 186496 Details for Bug 333956 – Proposed fix

[patch] Proposed fix

patch_333956.txt (text/plain), 5.81 KB, created by Olivier Thomann

on 2011-01-11 09:18:24 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2011-01-11 09:18:24 EST

Size: 5.81 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java,v
>retrieving revision 1.237
>diff -u -r1.237 CompilerOptions.java
>--- compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	17 Dec 2010 09:38:52 -0000	1.237
>+++ compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java	11 Jan 2011 14:17:54 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2010 IBM Corporation and others.
>+ * Copyright (c) 2000, 2011 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -630,63 +630,111 @@
> 	 */
> 	public static String[] warningOptionNames() {
> 		String[] result = {
>+			OPTION_Compliance,
>+			OPTION_DocCommentSupport,
>+			OPTION_Encoding,
>+			OPTION_FatalOptionalError,
>+			OPTION_GenerateClassFiles,
>+			OPTION_IncludeNullInfoFromAsserts,
>+			OPTION_InlineJsr,
>+			OPTION_LineNumberAttribute,
>+			OPTION_LocalVariableAttribute,
>+			OPTION_MaxProblemPerUnit,
>+			OPTION_PreserveUnusedLocal,
>+			OPTION_Process_Annotations,
> 			OPTION_ReportAnnotationSuperInterface,
> 			OPTION_ReportAssertIdentifier,
> 			OPTION_ReportAutoboxing,
>+			OPTION_ReportComparingIdentical,
> 			OPTION_ReportDeadCode,
>+			OPTION_ReportDeadCodeInTrivialIfStatement,
> 			OPTION_ReportDeprecation,
>+			OPTION_ReportDeprecationInDeprecatedCode,
>+			OPTION_ReportDeprecationWhenOverridingDeprecatedMethod,
> 			OPTION_ReportDiscouragedReference,
> 			OPTION_ReportEmptyStatement,
> 			OPTION_ReportEnumIdentifier,
> 			OPTION_ReportFallthroughCase,
> 			OPTION_ReportFieldHiding,
>-			OPTION_ReportFinalParameterBound,
> 			OPTION_ReportFinallyBlockNotCompletingNormally,
>+			OPTION_ReportFinalParameterBound,
> 			OPTION_ReportForbiddenReference,
> 			OPTION_ReportHiddenCatchBlock,
> 			OPTION_ReportIncompatibleNonInheritedInterfaceMethod,
> 			OPTION_ReportIncompleteEnumSwitch,
>+			OPTION_ReportIncompleteEnumSwitch,
> 			OPTION_ReportIndirectStaticAccess,
> 			OPTION_ReportInvalidJavadoc,
>+			OPTION_ReportInvalidJavadocTags,
>+			OPTION_ReportInvalidJavadocTagsDeprecatedRef,
>+			OPTION_ReportInvalidJavadocTagsNotVisibleRef,
>+			OPTION_ReportInvalidJavadocTagsVisibility,
> 			OPTION_ReportLocalVariableHiding,
>-			OPTION_ReportMethodWithConstructorName,
>-			OPTION_ReportMethodCanBeStatic,
> 			OPTION_ReportMethodCanBePotentiallyStatic,
>+			OPTION_ReportMethodCanBeStatic,
>+			OPTION_ReportMethodWithConstructorName,
> 			OPTION_ReportMissingDeprecatedAnnotation,
>+			OPTION_ReportMissingHashCodeMethod,
> 			OPTION_ReportMissingJavadocComments,
>+			OPTION_ReportMissingJavadocCommentsOverriding,
>+			OPTION_ReportMissingJavadocCommentsVisibility,
> 			OPTION_ReportMissingJavadocTagDescription,
> 			OPTION_ReportMissingJavadocTags,
>+			OPTION_ReportMissingJavadocTagsMethodTypeParameters,
>+			OPTION_ReportMissingJavadocTagsOverriding,
>+			OPTION_ReportMissingJavadocTagsVisibility,
> 			OPTION_ReportMissingOverrideAnnotation,
>+			OPTION_ReportMissingOverrideAnnotationForInterfaceMethodImplementation,
> 			OPTION_ReportMissingSerialVersion,
>+			OPTION_ReportMissingSynchronizedOnInheritedMethod,
> 			OPTION_ReportNoEffectAssignment,
> 			OPTION_ReportNoImplicitStringConversion,
> 			OPTION_ReportNonExternalizedStringLiteral,
> 			OPTION_ReportNonStaticAccessToStatic,
> 			OPTION_ReportNullReference,
>-			OPTION_ReportPotentialNullReference,
>-			OPTION_ReportRedundantNullCheck,
>-			OPTION_ReportRedundantSuperinterface,
>+			OPTION_ReportOverridingMethodWithoutSuperInvocation,
> 			OPTION_ReportOverridingPackageDefaultMethod,
> 			OPTION_ReportParameterAssignment,
> 			OPTION_ReportPossibleAccidentalBooleanAssignment,
>+			OPTION_ReportPotentialNullReference,
>+			OPTION_ReportRawTypeReference,
>+			OPTION_ReportRedundantNullCheck,
>+			OPTION_ReportRedundantSuperinterface,
>+			OPTION_ReportSpecialParameterHidingField,
> 			OPTION_ReportSyntheticAccessEmulation,
>+			OPTION_ReportTasks,
> 			OPTION_ReportTypeParameterHiding,
>+			OPTION_ReportUnavoidableGenericTypeProblems,
> 			OPTION_ReportUncheckedTypeOperation,
> 			OPTION_ReportUndocumentedEmptyBlock,
>+			OPTION_ReportUnhandledWarningToken,
> 			OPTION_ReportUnnecessaryElse,
> 			OPTION_ReportUnnecessaryTypeCheck,
> 			OPTION_ReportUnqualifiedFieldAccess,
> 			OPTION_ReportUnusedDeclaredThrownException,
>+			OPTION_ReportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable,
>+			OPTION_ReportUnusedDeclaredThrownExceptionIncludeDocCommentReference,
>+			OPTION_ReportUnusedDeclaredThrownExceptionWhenOverriding,
> 			OPTION_ReportUnusedImport,
>+			OPTION_ReportUnusedLabel,
> 			OPTION_ReportUnusedLocal,
> 			OPTION_ReportUnusedObjectAllocation,
> 			OPTION_ReportUnusedParameter,
>+			OPTION_ReportUnusedParameterIncludeDocCommentReference,
>+			OPTION_ReportUnusedParameterWhenImplementingAbstract,
>+			OPTION_ReportUnusedParameterWhenOverridingConcrete,
> 			OPTION_ReportUnusedPrivateMember,
>-			OPTION_ReportVarargsArgumentNeedCast,
>-			OPTION_ReportUnhandledWarningToken,
>-			OPTION_ReportUnusedWarningToken,
>-			OPTION_ReportOverridingMethodWithoutSuperInvocation,
> 			OPTION_ReportUnusedTypeArgumentsForMethodInvocation,
>+			OPTION_ReportUnusedWarningToken,
>+			OPTION_ReportVarargsArgumentNeedCast,
>+			OPTION_Source,
>+			OPTION_SourceFileAttribute,
>+			OPTION_SuppressOptionalErrors,
>+			OPTION_SuppressWarnings,
>+			OPTION_TargetPlatform,
>+			OPTION_TaskCaseSensitive,
>+			OPTION_TaskPriorities,
>+			OPTION_TaskTags,
> 		};
> 		return result;
> 	}

Actions: View | Diff

Attachments on bug 333956: 186496 | 186497 | 186601 | 186766