Attachment 185321 Details for Bug 332451 – Proposed fix

[patch] Proposed fix

patch_332451.txt (text/plain), 5.44 KB, created by Olivier Thomann

on 2010-12-16 09:25:07 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2010-12-16 09:25:07 EST

Size: 5.44 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: search/org/eclipse/jdt/core/search/SearchEngine.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/search/org/eclipse/jdt/core/search/SearchEngine.java,v
>retrieving revision 1.152
>diff -u -r1.152 SearchEngine.java
>--- search/org/eclipse/jdt/core/search/SearchEngine.java	28 May 2010 14:31:38 -0000	1.152
>+++ search/org/eclipse/jdt/core/search/SearchEngine.java	16 Dec 2010 14:24:10 -0000
>@@ -245,16 +245,16 @@
> 	 * The Java elements resulting from a search with this scope will
> 	 * be children of the given elements.
> 	 * 
>-	 * If an element is an IJavaProject, then the project's source folders,
>+	 * If an element is an {@link IJavaProject}, then the project's source folders,
> 	 * its jars (external and internal) and its referenced projects (with their source
>-	 * folders and jars, recursively) will be included.
>-	 * If an element is an IPackageFragmentRoot, then only the package fragments of
>-	 * this package fragment root will be included.
>-	 * If an element is an IPackageFragment, then only the compilation unit and class
>+	 * folders and jars, recursively) will be included.
>+	 * If an element is an {@link IPackageFragmentRoot}, then only the package fragments of
>+	 * this package fragment root will be included.
>+	 * If an element is an {@link IPackageFragment}, then only the compilation unit and class
> 	 * files of this package fragment will be included. Subpackages will NOT be
> 	 * included.
>-	 * 
>-	 * In other words, this is equivalent to using SearchEngine.createJavaSearchScope(elements, true).
>+	 *
>+	 * In other words, this is equivalent to using SearchEngine.createJavaSearchScope(elements, true).
> 	 *
> 	 * @param elements the Java elements the scope is limited to
> 	 * @return a new Java search scope
>@@ -269,14 +269,14 @@
> 	 * The Java elements resulting from a search with this scope will
> 	 * be children of the given elements.
> 	 *
>-	 * If an element is an IJavaProject, then the project's source folders,
>+	 * If an element is an {@link IJavaProject}, then the project's source folders,
> 	 * its jars (external and internal) and - if specified - its referenced projects
>-	 * (with their source folders and jars, recursively) will be included.
>-	 * If an element is an IPackageFragmentRoot, then only the package fragments of
>-	 * this package fragment root will be included.
>-	 * If an element is an IPackageFragment, then only the compilation unit and class
>+	 * (with their source folders and jars, recursively) will be included.
>+	 * If an element is an {@link IPackageFragmentRoot}, then only the package fragments of
>+	 * this package fragment root will be included.
>+	 * If an element is an {@link IPackageFragment}, then only the compilation unit and class
> 	 * files of this package fragment will be included. Subpackages will NOT be
>-	 * included.
>+	 * included.
> 	 *
> 	 * @param elements the Java elements the scope is limited to
> 	 * @param includeReferencedProjects a flag indicating if referenced projects must be
>@@ -293,22 +293,24 @@
> 	 * The Java elements resulting from a search with this scope will
> 	 * be children of the given elements.
> 	 *
>-	 * If an element is an IJavaProject, then it includes:
>-	 * - its source folders if IJavaSearchScope.SOURCES is specified,
>-	 * - its application libraries (internal and external jars, class folders that are on the raw classpath,
>+	 * If an element is an IJavaProject, then it includes:
>+	 * <ul>
>+	 * <li>its source folders if {@link IJavaSearchScope#SOURCES} is specified,</li>
>+	 * <li>its application libraries (internal and external jars, class folders that are on the raw classpath,
> 	 * or the ones that are coming from a classpath path variable,
> 	 * or the ones that are coming from a classpath container with the K_APPLICATION kind)
>-	 * if IJavaSearchScope.APPLICATION_LIBRARIES is specified
>-	 * - its system libraries (internal and external jars, class folders that are coming from an
>+	 * if {@link IJavaSearchScope#APPLICATION_LIBRARIES} is specified</li>
>+	 * <li>its system libraries (internal and external jars, class folders that are coming from an
> 	 * IClasspathContainer with the K_SYSTEM kind)
>-	 * if IJavaSearchScope.APPLICATION_LIBRARIES is specified
>-	 * - its referenced projects (with their source folders and jars, recursively)
>-	 * if IJavaSearchScope.REFERENCED_PROJECTS is specified.
>-	 * If an element is an IPackageFragmentRoot, then only the package fragments of
>-	 * this package fragment root will be included.
>-	 * If an element is an IPackageFragment, then only the compilation unit and class
>+	 * if {@link IJavaSearchScope#APPLICATION_LIBRARIES} is specified</li>
>+	 * <li>its referenced projects (with their source folders and jars, recursively)
>+	 * if {@link IJavaSearchScope#REFERENCED_PROJECTS} is specified.</li>
>+	 * </ul>
>+	 * If an element is an {@link IPackageFragmentRoot}, then only the package fragments of
>+	 * this package fragment root will be included.
>+	 * If an element is an {@link IPackageFragment}, then only the compilation unit and class
> 	 * files of this package fragment will be included. Subpackages will NOT be
>-	 * included.
>+	 * included.
> 	 *
> 	 * @param elements the Java elements the scope is limited to
> 	 * @param includeMask the bit-wise OR of all include types of interest

Actions: View | Diff

Attachments on bug 332451: 185321 | 185331