Attachment 184122 Details for Bug 329671 – Proposed fix

[patch] Proposed fix

patch_329671.txt (text/plain), 1.29 KB, created by Olivier Thomann

on 2010-11-30 08:47:13 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2010-11-30 08:47:13 EST

Size: 1.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/BinaryMethod.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/BinaryMethod.java,v
>retrieving revision 1.109
>diff -u -r1.109 BinaryMethod.java
>--- model/org/eclipse/jdt/internal/core/BinaryMethod.java	29 Nov 2010 05:24:37 -0000	1.109
>+++ model/org/eclipse/jdt/internal/core/BinaryMethod.java	30 Nov 2010 13:45:18 -0000
>@@ -223,7 +223,7 @@
> 			}
> 			if (timeOut == 0) {
> 				// don't try to fetch the values
>-				return this.parameterNames = getRawParameterNames(paramCount);
>+				return getRawParameterNames(paramCount);
> 			}
> 			final class ParametersNameCollector {
> 				String javadoc;
>@@ -304,8 +304,8 @@
> 			return this.parameterNames = names;
> 		}
> 	}
>-	// if still no parameter names, produce fake ones
>-	return this.parameterNames = getRawParameterNames(paramCount);
>+	// If still no parameter names, produce fake ones, but don't cache them (https://bugs.eclipse.org/bugs/show_bug.cgi?id=329671)
>+	return getRawParameterNames(paramCount);
> }
> private char[][] splitParameters(char[] parametersSource, int paramCount) {
> 	// we have generic types as one of the parameter types

Actions: View | Diff

Attachments on bug 329671: 183576 | 183820 | 183821 | 183835 | 184103 | 184122 | 184129