Attachment #181481 for bug #185682

Lines 117-122 Link Here

(-)compiler/org/eclipse/jdt/core/compiler/IProblem.java (+3 lines)
117	* MissingSynchronizedModifierInInheritedMethod	117	* MissingSynchronizedModifierInInheritedMethod
118	* Stephan Herrmann - added the following constants	118	* Stephan Herrmann - added the following constants
119	* UnusedObjectAllocation	119	* UnusedObjectAllocation
		120	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
120	*******************************************************************************/	121	*******************************************************************************/
121	package org.eclipse.jdt.core.compiler;	122	package org.eclipse.jdt.core.compiler;
122		123
Lines 359-364 Link Here
359	int DuplicateBlankFinalFieldInitialization = FieldRelated + 82;	360	int DuplicateBlankFinalFieldInitialization = FieldRelated + 82;
360	/** @since 3.6 */	361	/** @since 3.6 */
361	int UnresolvedVariable = FieldRelated + 83;	362	int UnresolvedVariable = FieldRelated + 83;
		363	/** @since 3.7 */
		364	int UnusedScopedField = Internal + FieldRelated + 84;
362		365
363	// variable hiding	366	// variable hiding
364	/** @since 3.0 */	367	/** @since 3.0 */




 *     IBM Corporation - initial API and implementation
 *     Matt McCutchen - partial fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=122995
 *     Karen Moore - fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=207411
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.internal.compiler.ast;


		return this;
	}

	public final boolean isFieldUseDeprecated(FieldBinding field, Scope scope, int filteredBits) {
		if ((this.bits & ASTNode.InsideJavadoc) == 0			// ignore references inside Javadoc comments 
				&& (filteredBits & IsStrictlyAssigned) == 0 	// ignore write access
				&& field.isOrEnclosedByPrivateType() 
				&& !scope.isDefinedInField(field)) 				// ignore cases where field is used from inside itself 
		{		
			if (((filteredBits & IsCompoundAssigned) != 0))
				// used, but usage may not be relevant
				field.original().compoundUseFlag++;
			else
				field.original().modifiers |= ExtraCompilerModifiers.AccLocallyUsed;
		}

		if ((field.modifiers & ExtraCompilerModifiers.AccRestrictedAccess) != 0) {

Lines 7-12 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/FieldReference.java (-1 / +6 lines)
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.internal.compiler.ast;	12	package org.eclipse.jdt.internal.compiler.ast;
12		13
Lines 290-295 Link Here
290		291
291	public void generateCompoundAssignment(BlockScope currentScope, CodeStream codeStream, Expression expression, int operator, int assignmentImplicitConversion, boolean valueRequired) {	292	public void generateCompoundAssignment(BlockScope currentScope, CodeStream codeStream, Expression expression, int operator, int assignmentImplicitConversion, boolean valueRequired) {
292	boolean isStatic;	293	boolean isStatic;
		294	// check if compound assignment is the only usage of a private field
		295	reportOnlyUselesslyReadPrivateField(currentScope, this.binding, valueRequired);
293	FieldBinding codegenBinding = this.binding.original();	296	FieldBinding codegenBinding = this.binding.original();
294	this.receiver.generateCode(currentScope, codeStream, !(isStatic = codegenBinding.isStatic()));	297	this.receiver.generateCode(currentScope, codeStream, !(isStatic = codegenBinding.isStatic()));
295	if (isStatic) {	298	if (isStatic) {
Lines 337-342 Link Here
337		340
338	public void generatePostIncrement(BlockScope currentScope, CodeStream codeStream, CompoundAssignment postIncrement, boolean valueRequired) {	341	public void generatePostIncrement(BlockScope currentScope, CodeStream codeStream, CompoundAssignment postIncrement, boolean valueRequired) {
339	boolean isStatic;	342	boolean isStatic;
		343	// check if postIncrement is the only usage of a private field
		344	reportOnlyUselesslyReadPrivateField(currentScope, this.binding, valueRequired);
340	FieldBinding codegenBinding = this.binding.original();	345	FieldBinding codegenBinding = this.binding.original();
341	this.receiver.generateCode(currentScope, codeStream, !(isStatic = codegenBinding.isStatic()));	346	this.receiver.generateCode(currentScope, codeStream, !(isStatic = codegenBinding.isStatic()));
342	if (isStatic) {	347	if (isStatic) {
Lines 577-583 Link Here
577	if (this.actualReceiverType != oldReceiverType && this.receiver.postConversionType(scope) != this.actualReceiverType) { // record need for explicit cast at codegen since receiver could not handle it	582	if (this.actualReceiverType != oldReceiverType && this.receiver.postConversionType(scope) != this.actualReceiverType) { // record need for explicit cast at codegen since receiver could not handle it
578	this.bits \|= NeedReceiverGenericCast;	583	this.bits \|= NeedReceiverGenericCast;
579	}	584	}
580	if (isFieldUseDeprecated(fieldBinding, scope, (this.bits & ASTNode.IsStrictlyAssigned) !=0)) {	585	if (isFieldUseDeprecated(fieldBinding, scope, this.bits)) {
581	scope.problemReporter().deprecatedField(fieldBinding, this);	586	scope.problemReporter().deprecatedField(fieldBinding, this);
582	}	587	}
583	boolean isImplicitThisRcv = this.receiver.isImplicitThis();	588	boolean isImplicitThisRcv = this.receiver.isImplicitThis();




/*******************************************************************************
 * Copyright (c) 2000, 2010 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at

 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.internal.compiler.ast;


import org.eclipse.jdt.internal.compiler.flow.FlowContext;
import org.eclipse.jdt.internal.compiler.flow.FlowInfo;
import org.eclipse.jdt.internal.compiler.lookup.BlockScope;
import org.eclipse.jdt.internal.compiler.lookup.ExtraCompilerModifiers;
import org.eclipse.jdt.internal.compiler.lookup.FieldBinding;
import org.eclipse.jdt.internal.compiler.lookup.LocalVariableBinding;
import org.eclipse.jdt.internal.compiler.lookup.MethodBinding;
import org.eclipse.jdt.internal.compiler.lookup.MethodScope;
import org.eclipse.jdt.internal.compiler.lookup.Scope;
import org.eclipse.jdt.internal.compiler.lookup.TypeBinding;
import org.eclipse.jdt.internal.compiler.lookup.TypeIds;

public abstract void generateCompoundAssignment(BlockScope currentScope, CodeStream codeStream, Expression expression, int operator, int assignmentImplicitConversion, boolean valueRequired);

public abstract void generatePostIncrement(BlockScope currentScope, CodeStream codeStream, CompoundAssignment postIncrement, boolean valueRequired);

/* report if a private field is only read from a 'special operator',
 * i.e., in a postIncrement expression or a compound assignment,
 * where the information is never flowing out off the field. */
void reportOnlyUselesslyReadPrivateField(BlockScope currentScope, FieldBinding fieldBinding, boolean valueRequired) {
	if (valueRequired) {
		// access is relevant, turn compound use into real use:
		fieldBinding.compoundUseFlag = 0;
		fieldBinding.modifiers |= ExtraCompilerModifiers.AccLocallyUsed;
	} else {
		if (fieldBinding.isUsedOnlyInCompound()) {
			fieldBinding.compoundUseFlag--; // consume one
			if (fieldBinding.compoundUseFlag == 0					// report only the last usage
					&& fieldBinding.isOrEnclosedByPrivateType() 
					&& (this.implicitConversion & TypeIds.UNBOXING) == 0) // don't report if unboxing is involved (might cause NPE)
			{
				// compoundAssignment/postIncrement is the only usage of this field
				currentScope.problemReporter().unusedPrivateField(fieldBinding.sourceField());
				fieldBinding.modifiers |= ExtraCompilerModifiers.AccLocallyUsed; // don't report again
			}
		}
	}
}
/* report a local/arg that is only read from a 'special operator',
 * i.e., in a postIncrement expression or a compound assignment,
 * where the information is never flowing out off the local/arg. */
static void reportOnlyUselesslyReadLocal(BlockScope currentScope, LocalVariableBinding localBinding, boolean valueRequired) {
	if (localBinding.declaration == null)
		return;  // secret local
	if ((localBinding.declaration.bits & ASTNode.IsLocalDeclarationReachable) == 0)
		return;  // declaration is unreachable
	if (localBinding.useFlag >= LocalVariableBinding.USED)
		return;  // we're only interested in cases with only compound access (negative count)

	if (valueRequired) {
		// access is relevant
		localBinding.useFlag = LocalVariableBinding.USED;
		return;
	} else {
		localBinding.useFlag++;
		if (localBinding.useFlag != 0)
			return; // still waiting to see more usages of this kind
	}
	// at this point we know we have something to report
	if (localBinding.declaration instanceof Argument) {
		// check compiler options to report against unused arguments
		MethodScope methodScope = currentScope.methodScope();
		if (methodScope != null) {
			MethodBinding method = ((AbstractMethodDeclaration)methodScope.referenceContext()).binding;
			
			boolean shouldReport = !method.isMain();
			if (method.isImplementing()) {
				shouldReport &= currentScope.compilerOptions().reportUnusedParameterWhenImplementingAbstract;
			} else if (method.isOverriding()) {
				shouldReport &= currentScope.compilerOptions().reportUnusedParameterWhenOverridingConcrete;
			}
			
			if (shouldReport) {
				// report the case of an argument that is unread except through a special operator
				currentScope.problemReporter().unusedArgument(localBinding.declaration);
			}
		}
	} else {
		// report the case of a local variable that is unread except for a special operator
		currentScope.problemReporter().unusedLocalVariable(localBinding.declaration);
	}
	localBinding.useFlag = LocalVariableBinding.USED; // don't report again
}
}

Lines 7-13 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/ast/SingleNameReference.java (-7 / +33 lines)
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 292478 - Report potentially null across variable assignment	10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 292478 - Report potentially null across variable assignment,
		11	* Contribution for bug 185682 - Increment/decrement operators mark local variables as read
11	*******************************************************************************/	12	*******************************************************************************/
12	package org.eclipse.jdt.internal.compiler.ast;	13	package org.eclipse.jdt.internal.compiler.ast;
13		14
Lines 78-87 Link Here
78	currentScope.problemReporter().uninitializedLocalVariable(localBinding, this);	79	currentScope.problemReporter().uninitializedLocalVariable(localBinding, this);
79	// we could improve error msg here telling "cannot use compound assignment on final local variable"	80	// we could improve error msg here telling "cannot use compound assignment on final local variable"
80	}	81	}
81	if (isReachable) {	82	if (localBinding.useFlag != LocalVariableBinding.USED) {
82	localBinding.useFlag = LocalVariableBinding.USED;	83	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
83	} else if (localBinding.useFlag == LocalVariableBinding.UNUSED) {	84	// access from compound assignment does not prevent "unused" warning, unless unboxing is involved:
84	localBinding.useFlag = LocalVariableBinding.FAKE_USED;	85	if (isReachable && (this.implicitConversion & TypeIds.UNBOXING) != 0) {
		86	localBinding.useFlag = LocalVariableBinding.USED;
		87	} else {
		88	// use values < 0 to count the number of compound uses:
		89	if (localBinding.useFlag <= LocalVariableBinding.UNUSED)
		90	localBinding.useFlag--;
		91	}
85	}	92	}
86	}	93	}
87	}	94	}
Lines 204-210 Link Here
204	}	211	}
205	}	212	}
206		213
207	if (isFieldUseDeprecated(fieldBinding, scope, (this.bits & ASTNode.IsStrictlyAssigned) !=0))	214	if (isFieldUseDeprecated(fieldBinding, scope, this.bits))
208	scope.problemReporter().deprecatedField(fieldBinding, this);	215	scope.problemReporter().deprecatedField(fieldBinding, this);
209		216
210	if ((this.bits & ASTNode.IsStrictlyAssigned) == 0	217	if ((this.bits & ASTNode.IsStrictlyAssigned) == 0
Lines 462-467 Link Here
462	* are optimized in one access: e.g "a = a + 1" optimized into "a++".	469	* are optimized in one access: e.g "a = a + 1" optimized into "a++".
463	*/	470	*/
464	public void generateCompoundAssignment(BlockScope currentScope, CodeStream codeStream, Expression expression, int operator, int assignmentImplicitConversion, boolean valueRequired) {	471	public void generateCompoundAssignment(BlockScope currentScope, CodeStream codeStream, Expression expression, int operator, int assignmentImplicitConversion, boolean valueRequired) {
		472	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
		473	switch (this.bits & ASTNode.RestrictiveFlagMASK) {
		474	case Binding.LOCAL:
		475	LocalVariableBinding localBinding = (LocalVariableBinding) this.binding;
		476	// check if compound assignment is the only usage of this local
		477	Reference.reportOnlyUselesslyReadLocal(currentScope, localBinding, valueRequired);
		478	break;
		479	case Binding.FIELD:
		480	// check if compound assignment is the only usage of a private field
		481	reportOnlyUselesslyReadPrivateField(currentScope, (FieldBinding)this.binding, valueRequired);
		482	}
465	this.generateCompoundAssignment(	483	this.generateCompoundAssignment(
466	currentScope,	484	currentScope,
467	codeStream,	485	codeStream,
Lines 599-605 Link Here
599	public void generatePostIncrement(BlockScope currentScope, CodeStream codeStream, CompoundAssignment postIncrement, boolean valueRequired) {	617	public void generatePostIncrement(BlockScope currentScope, CodeStream codeStream, CompoundAssignment postIncrement, boolean valueRequired) {
600	switch (this.bits & ASTNode.RestrictiveFlagMASK) {	618	switch (this.bits & ASTNode.RestrictiveFlagMASK) {
601	case Binding.FIELD : // assigning to a field	619	case Binding.FIELD : // assigning to a field
602	FieldBinding codegenField = (((FieldBinding)this.binding).original());	620	FieldBinding fieldBinding = (FieldBinding)this.binding;
		621	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
		622	// check if postIncrement is the only usage of a private field
		623	reportOnlyUselesslyReadPrivateField(currentScope, fieldBinding, valueRequired);
		624	FieldBinding codegenField = fieldBinding.original();
603	if (codegenField.isStatic()) {	625	if (codegenField.isStatic()) {
604	if ((this.syntheticAccessors == null) \|\| (this.syntheticAccessors[SingleNameReference.READ] == null)) {	626	if ((this.syntheticAccessors == null) \|\| (this.syntheticAccessors[SingleNameReference.READ] == null)) {
605	TypeBinding constantPoolDeclaringClass = CodeStream.getConstantPoolDeclaringClass(currentScope, codegenField, this.actualReceiverType, true /* implicit this */);	627	TypeBinding constantPoolDeclaringClass = CodeStream.getConstantPoolDeclaringClass(currentScope, codegenField, this.actualReceiverType, true /* implicit this */);
Lines 662-667 Link Here
662	return;	684	return;
663	case Binding.LOCAL : // assigning to a local variable	685	case Binding.LOCAL : // assigning to a local variable
664	LocalVariableBinding localBinding = (LocalVariableBinding) this.binding;	686	LocalVariableBinding localBinding = (LocalVariableBinding) this.binding;
		687	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
		688	// check if postIncrement is the only usage of this local
		689	Reference.reportOnlyUselesslyReadLocal(currentScope, localBinding, valueRequired);
		690
665	// using incr bytecode if possible	691	// using incr bytecode if possible
666	if (localBinding.type == TypeBinding.INT) {	692	if (localBinding.type == TypeBinding.INT) {
667	if (valueRequired) {	693	if (valueRequired) {

Lines 1-5 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/lookup/FieldBinding.java (-2 / +11 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2009 IBM Corporation and others.	2	* Copyright (c) 2000, 2010 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 7-12 Link Here
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.internal.compiler.lookup;	12	package org.eclipse.jdt.internal.compiler.lookup;
12		13
Lines 19-24 Link Here
19		20
20	public class FieldBinding extends VariableBinding {	21	public class FieldBinding extends VariableBinding {
21	public ReferenceBinding declaringClass;	22	public ReferenceBinding declaringClass;
		23	public int compoundUseFlag = 0; // number or accesses via postIncrement or compoundAssignment
		24
22	protected FieldBinding() {	25	protected FieldBinding() {
23	super(null, null, 0, null);	26	super(null, null, 0, null);
24	// for creating problem field	27	// for creating problem field
Lines 332-338 Link Here
332	*/	335	*/
333		336
334	public final boolean isUsed() {	337	public final boolean isUsed() {
335	return (this.modifiers & ExtraCompilerModifiers.AccLocallyUsed) != 0;	338	return (this.modifiers & ExtraCompilerModifiers.AccLocallyUsed) != 0 \|\| this.compoundUseFlag > 0;
		339	}
		340	/* Answer true if the only use of this field is in compound assignment or post increment
		341	*/
		342
		343	public final boolean isUsedOnlyInCompound() {
		344	return (this.modifiers & ExtraCompilerModifiers.AccLocallyUsed) == 0 && this.compoundUseFlag > 0;
336	}	345	}
337	/* Answer true if the receiver has protected visibility	346	/* Answer true if the receiver has protected visibility
338	*/	347	*/

Lines 9-14 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java (-2 / +7 lines)
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
10	* Benjamin Muskalla - Contribution for bug 239066	10	* Benjamin Muskalla - Contribution for bug 239066
11	* Stephan Herrmann - Contribution for bug 236385	11	* Stephan Herrmann - Contribution for bug 236385
		12	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
12	*******************************************************************************/	13	*******************************************************************************/
13	package org.eclipse.jdt.internal.compiler.problem;	14	package org.eclipse.jdt.internal.compiler.problem;
14		15
Lines 194-199 Link Here
194	case IProblem.UnusedPrivateConstructor:	195	case IProblem.UnusedPrivateConstructor:
195	case IProblem.UnusedPrivateMethod:	196	case IProblem.UnusedPrivateMethod:
196	case IProblem.UnusedPrivateField:	197	case IProblem.UnusedPrivateField:
		198	case IProblem.UnusedScopedField:
197	case IProblem.UnusedPrivateType:	199	case IProblem.UnusedPrivateType:
198	return CompilerOptions.UnusedPrivateMember;	200	return CompilerOptions.UnusedPrivateMember;
199		201
Lines 7250-7256 Link Here
7250	}	7252	}
7251	public void unusedPrivateField(FieldDeclaration fieldDecl) {	7253	public void unusedPrivateField(FieldDeclaration fieldDecl) {
7252		7254
7253	int severity = computeSeverity(IProblem.UnusedPrivateField);	7255	int problemId = (fieldDecl.modifiers & ClassFileConstants.AccPrivate) != 0
		7256	? IProblem.UnusedPrivateField
		7257	: IProblem.UnusedScopedField;
		7258	int severity = computeSeverity(problemId);
7254	if (severity == ProblemSeverities.Ignore) return;	7259	if (severity == ProblemSeverities.Ignore) return;
7255		7260
7256	FieldBinding field = fieldDecl.binding;	7261	FieldBinding field = fieldDecl.binding;
Lines 7269-7275 Link Here
7269	return; // do not report unused serialPersistentFields field	7274	return; // do not report unused serialPersistentFields field
7270	}	7275	}
7271	this.handle(	7276	this.handle(
7272	IProblem.UnusedPrivateField,	7277	problemId,
7273	new String[] {	7278	new String[] {
7274	new String(field.declaringClass.readableName()),	7279	new String(field.declaringClass.readableName()),
7275	new String(field.name),	7280	new String(field.name),




# Contributors:
#     IBM Corporation - initial API and implementation
#		Benjamin Muskalla - Contribution for bug 239066
#		Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
###############################################################################
0 = {0}
1 = super cannot be used in java.lang.Object

58 = The final local variable {0} cannot be assigned. It must be blank and not using a compound assignment
59 = The parameter {0} should not be assigned
60 = The final local variable {0} cannot be assigned, since it is defined in an enclosing type
61 = The local variable {0} is never used
62 = The parameter {0} is never used
63 = The code of method {0}({1}) is exceeding the 65535 bytes limit
64 = The code for the static initializer is exceeding the 65535 bytes limit
65 = Too many parameters, parameter {0} is exceeding the limit of 255 words eligible for method parameters

74 = Cannot make a static reference to the non-static field {0}
75 = Cannot reference a field before it is defined
76 = The static field {0}.{1} should be accessed in a static way
77 = The private field {0}.{1} is never used
78 = The static field {0}.{1} should be accessed directly
79 = Unqualified access to the field {0}.{1} 
80 = The final field {0}.{1} cannot be assigned
81 = The blank final field {0} may not have been initialized
82 = The final field {0} may already have been assigned
83 = {0} cannot be resolved to a variable
84 = The field {0}.{1} is never used locally

90 = The local variable {0} is hiding another local variable defined in an enclosing type scope
91 = The local variable {0} is hiding a field from type {1}

Lines 1-5 Link Here

(-)eval/org/eclipse/jdt/internal/eval/CodeSnippetFieldReference.java (-2 / +3 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2009 IBM Corporation and others.	2	* Copyright (c) 2000, 2010 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 7-12 Link Here
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.internal.eval;	12	package org.eclipse.jdt.internal.eval;
12		13
Lines 325-331 Link Here
325	return null;	326	return null;
326	}	327	}
327		328
328	if (isFieldUseDeprecated(this.binding, scope, (this.bits & IsStrictlyAssigned) !=0)) {	329	if (isFieldUseDeprecated(this.binding, scope, this.bits)) {
329	scope.problemReporter().deprecatedField(this.binding, this);	330	scope.problemReporter().deprecatedField(this.binding, this);
330	}	331	}
331	// check for this.x in static is done in the resolution of the receiver	332	// check for this.x in static is done in the resolution of the receiver




/*******************************************************************************
 * Copyright (c) 2000, 2010 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at

 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.internal.eval;


			}
		}
		// only last field is actually a write access if any
		if (isFieldUseDeprecated((FieldBinding) this.binding, scope, this.indexOfFirstFieldBinding == length ? this.bits : 0)) {
			scope.problemReporter().deprecatedField((FieldBinding) this.binding, this);
		}
	}

		}
		if (field.isValidBinding()) {
			// only last field is actually a write access if any
			if (isFieldUseDeprecated(field, scope, index+1 == length ? this.bits : 0)) {
				scope.problemReporter().deprecatedField(field, this);
			}
			// constant propagation can only be performed as long as the previous one is a constant too.

Lines 1-5 Link Here

(-)eval/org/eclipse/jdt/internal/eval/CodeSnippetSingleNameReference.java (-2 / +3 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2009 IBM Corporation and others.	2	* Copyright (c) 2000, 2010 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 7-12 Link Here
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.internal.eval;	12	package org.eclipse.jdt.internal.eval;
12		13
Lines 101-107 Link Here
101	}	102	}
102	this.constant = fieldBinding.constant();	103	this.constant = fieldBinding.constant();
103		104
104	if (isFieldUseDeprecated(fieldBinding, scope, (this.bits & IsStrictlyAssigned) !=0)) {	105	if (isFieldUseDeprecated(fieldBinding, scope, this.bits)) {
105	scope.problemReporter().deprecatedField(fieldBinding, this);	106	scope.problemReporter().deprecatedField(fieldBinding, this);
106	}	107	}
107	return fieldBinding.type;	108	return fieldBinding.type;

Lines 8-13 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/AnnotationTest.java (-1 / +2 lines)
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
10	* Stephan Herrmann - Contribution for bug 295551	10	* Stephan Herrmann - Contribution for bug 295551
		11	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
11	*******************************************************************************/	12	*******************************************************************************/
12	package org.eclipse.jdt.core.tests.compiler.regression;	13	package org.eclipse.jdt.core.tests.compiler.regression;
13		14
Lines 9355-9361 Link Here
9355	"1. ERROR in A.java (at line 3)\n" +	9356	"1. ERROR in A.java (at line 3)\n" +
9356	" private int i;\n" +	9357	" private int i;\n" +
9357	" ^\n" +	9358	" ^\n" +
9358	"The field A.i is never read locally\n" +	9359	"The private field A.i is never used\n" +
9359	"----------\n";	9360	"----------\n";
9360	runNegativeTest(	9361	runNegativeTest(
9361	true,	9362	true,




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"1. WARNING in X.java (at line 4)\n" +
		"	private final Object o;\n" +
		"	                     ^\n" +
		"The private field X.Test1.o is never used\n" +
		"----------\n" +
		"2. WARNING in X.java (at line 13)\n" +
		"	private final Object o;\n" +
		"	                     ^\n" +
		"The private field X.Test2.o is never used\n" +
		"----------\n" +
		"3. ERROR in X.java (at line 25)\n" +
		"	System.out.println(o); // illegal; o is not definitely assigned\n" +

		"4. WARNING in X.java (at line 42)\n" +
		"	private final Object o;\n" +
		"	                     ^\n" +
		"The private field X.Test5.o is never used\n" +
		"----------\n" +
		"5. ERROR in X.java (at line 44)\n" +
		"	Test5() {\n" +

		"7. WARNING in X.java (at line 52)\n" +
		"	private final Object o;\n" +
		"	                     ^\n" +
		"The private field X.Test6.o is never used\n" +
		"----------\n" +
		"8. ERROR in X.java (at line 59)\n" +
		"	other.o = new Object(); // illegal!  other.o is not assignable\n" +




 *     Benjamin Muskalla - Contribution for bug 239066
 *     Stephan Herrmann  - Contribution for bug 236385
 *     Stephan Herrmann  - Contribution for bug 295551
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


	        "7. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/Z.java (at line 58)\n" +
	        "	final XX<?, XY> l1 = (XX<?, XY>) i.getKey();\n" +
	        "	                ^^\n" +
	        "The local variable l1 is never used\n" +
	        "----------\n" +
	        "8. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/Z.java (at line 58)\n" +
	        "	final XX<?, XY> l1 = (XX<?, XY>) i.getKey();\n" +

        "7. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/Z.java (at line 58)\n" +
        "	final XX<?, XY> l1 = (XX<?, XY>) i.getKey();\n" +
        "	                ^^\n" +
        "The local variable l1 is never used\n" +
        "----------\n" +
        "8. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/Z.java (at line 58)\n" +
        "	final XX<?, XY> l1 = (XX<?, XY>) i.getKey();\n" +

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"2 problems (2 warnings)",
		true);

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"2 problems (2 warnings)",
		true);

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"2 problems (2 warnings)",
		true);

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	String u;\n" +
		"	       ^\n" +
		"The local variable u is never used\n" +
		"----------\n" +
		"2 problems (2 warnings)",
		true);

		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +

		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"6. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +

		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +

		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"6. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +

		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	this.<String>bar();\n" +

		"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +
		"	                     ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"4. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" +
		"	private void foo(int i) throws java.io.IOException {\n" +

		"5. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 4)\n" +
		"	int j;\n" +
		"	    ^\n" +
		"The local variable j is never used\n" +
		"----------\n" +
		"6. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 6)\n" +
		"	next: for (;;) {\n" +

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	public void foo(int i) {\n" +
		"	                    ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	public void foo(int i) {\n" +
		"	                    ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"2 problems (2 warnings)",
		true);

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	public void foo(int i) {\n" +
		"	                    ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 5)\n" +
		"	public void foo(int i) {\n" +
		"	                    ^\n" +
		"The parameter i is never used\n" +
		"----------\n" +
		"1 problem (1 warning)",
		true);

		"2. ERROR in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" + 
		"	private int i;\n" + 
		"	            ^\n" + 
		"The private field X.i is never used\n" + 
		"----------\n" + 
		"2 problems (1 error, 1 warning)",
		true);

		"1. ERROR in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" + 
		"	private int i;\n" + 
		"	            ^\n" + 
		"The private field X.i is never used\n" + 
		"----------\n" + 
		"1 problem (1 error)",
		true);

		"1. ERROR in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" + 
		"	private int i;\n" + 
		"	            ^\n" + 
		"The private field X.i is never used\n" + 
		"----------\n" + 
		"1 problem (1 error)",
		true);

		"2. ERROR in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" + 
		"	private int i;\n" + 
		"	            ^\n" + 
		"The private field X.i is never used\n" + 
		"----------\n" + 
		"2 problems (1 error, 1 warning)",
		true);

		"1. ERROR in ---OUTPUT_DIR_PLACEHOLDER---/X.java (at line 3)\n" + 
		"	private int i;\n" + 
		"	            ^\n" + 
		"The private field X.i is never used\n" + 
		"----------\n" + 
		"1 problem (1 error)",
		true);




 *     IBM Corporation - initial API and implementation
 *     Benjamin Muskalla - Contribution for bug 239066
 *     Stephan Herrmann  - Contribution for bug 236385
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		expectedProblemAttributes.put("UnusedObjectAllocation", new ProblemAttributes(CategorizedProblem.CAT_POTENTIAL_PROGRAMMING_PROBLEM));
		expectedProblemAttributes.put("UnusedPrivateConstructor", new ProblemAttributes(CategorizedProblem.CAT_UNNECESSARY_CODE));
		expectedProblemAttributes.put("UnusedPrivateField", new ProblemAttributes(CategorizedProblem.CAT_UNNECESSARY_CODE));
		expectedProblemAttributes.put("UnusedScopedField", new ProblemAttributes(CategorizedProblem.CAT_UNNECESSARY_CODE));
		expectedProblemAttributes.put("UnusedPrivateMethod", new ProblemAttributes(CategorizedProblem.CAT_UNNECESSARY_CODE));
		expectedProblemAttributes.put("UnusedPrivateType", new ProblemAttributes(CategorizedProblem.CAT_UNNECESSARY_CODE));
		expectedProblemAttributes.put("UnusedTypeArgumentsForConstructorInvocation", new ProblemAttributes(CategorizedProblem.CAT_MEMBER));

		expectedProblemAttributes.put("UnusedObjectAllocation", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_OBJECT_ALLOCATION));
		expectedProblemAttributes.put("UnusedPrivateConstructor", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_PRIVATE_MEMBER));
		expectedProblemAttributes.put("UnusedPrivateField", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_PRIVATE_MEMBER));
		expectedProblemAttributes.put("UnusedScopedField", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_PRIVATE_MEMBER));
		expectedProblemAttributes.put("UnusedPrivateMethod", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_PRIVATE_MEMBER));
		expectedProblemAttributes.put("UnusedPrivateType", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_PRIVATE_MEMBER));
		expectedProblemAttributes.put("UnusedTypeArgumentsForConstructorInvocation", new ProblemAttributes(JavaCore.COMPILER_PB_UNUSED_TYPE_ARGUMENTS_FOR_METHOD_INVOCATION));

Lines 1713-1719 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/Compliance_1_4.java (-2 / +2 lines)
1713	"1. WARNING in p\\A.java (at line 6)\n" +	1713	"1. WARNING in p\\A.java (at line 6)\n" +
1714	" private int i;\n" +	1714	" private int i;\n" +
1715	" ^\n" +	1715	" ^\n" +
1716	"The field A.i is never read locally\n" +	1716	"The private field A.i is never used\n" +
1717	"----------\n" +	1717	"----------\n" +
1718	"2. ERROR in p\\A.java (at line 8)\n" +	1718	"2. ERROR in p\\A.java (at line 8)\n" +
1719	" int x = i;\n" +	1719	" int x = i;\n" +
Lines 1946-1952 Link Here
1946	"3. WARNING in p\\FieldQualification.java (at line 6)\n" +	1946	"3. WARNING in p\\FieldQualification.java (at line 6)\n" +
1947	" String field = \"Enclosing field for anonymous type\";\n" +	1947	" String field = \"Enclosing field for anonymous type\";\n" +
1948	" ^^^^^\n" +	1948	" ^^^^^\n" +
1949	"The field Local.field is never read locally\n" +	1949	"The field Local.field is never used locally\n" +
1950	"----------\n" +	1950	"----------\n" +
1951	"4. WARNING in p\\FieldQualification.java (at line 7)\n" +	1951	"4. WARNING in p\\FieldQualification.java (at line 7)\n" +
1952	" void foo() {\n" +	1952	" void foo() {\n" +




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"1. WARNING in X.java (at line 2)\n" +
		"	private int unused1;\n" +
		"	            ^^^^^^^\n" +
		"The private field X.unused1 is never used\n" +
		"----------\n" +
		"2. WARNING in X.java (at line 7)\n" +
		"	private int unused2;\n" +
		"	            ^^^^^^^\n" +
		"The private field X.unused2 is never used\n" +
		"----------\n",
		null, null,
		JavacTestOptions.Excuse.EclipseHasSomeMoreWarnings




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"1. WARNING in test\\AbstractVisibility.java (at line 5)\n" + 
		"	public int avf_public = avf_private;\n" + 
		"	           ^^^^^^^^^^\n" + 
		"The field AbstractVisibility.AvcPrivate.avf_public is never used locally\n" + 
		"----------\n" + 
		"2. WARNING in test\\AbstractVisibility.java (at line 10)\n" + 
		"	public int avm_public() {\n" + 

		"1. WARNING in test\\Visibility.java (at line 5)\n" + 
		"	public int vf_public = vf_private;\n" + 
		"	           ^^^^^^^^^\n" + 
		"The field Visibility.VcPrivate.vf_public is never used locally\n" + 
		"----------\n" + 
		"2. WARNING in test\\Visibility.java (at line 11)\n" + 
		"	public int vm_public() {\n" + 

		"1. WARNING in test\\copy\\VisibilityPackage.java (at line 5)\n" + 
		"	public int vf_public = vf_private;\n" + 
		"	           ^^^^^^^^^\n" + 
		"The field VisibilityPackage.VpPrivate.vf_public is never used locally\n" + 
		"----------\n" + 
		"2. WARNING in test\\copy\\VisibilityPackage.java (at line 10)\n" + 
		"	public int vm_public() {\n" + 

		"1. WARNING in test\\copy\\VisibilityPublic.java (at line 5)\n" + 
		"	public int vf_public = vf_private;\n" + 
		"	           ^^^^^^^^^\n" + 
		"The field VisibilityPublic.VpPrivate.vf_public is never used locally\n" + 
		"----------\n" + 
		"2. WARNING in test\\copy\\VisibilityPublic.java (at line 10)\n" + 
		"	public int vm_public() {\n" + 




/*******************************************************************************
 * Copyright (c) 2005, 2010 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at

 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"1. ERROR in X.java (at line 7)\n" +
		"	void bar(int value) { // X#bar(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n",
		// javac options
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError /* javac test options */);

		"1. ERROR in X.java (at line 5)\n" +
		"	void foo(int value) { // X#foo(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"2. ERROR in X.java (at line 7)\n" +
		"	void bar(int value) { // X#bar(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"3. ERROR in X.java (at line 24)\n" +
		"	void parent(int value) { /* Parent#parent(...) */}\n" +
		"	                ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n",
		// javac options
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError /* javac test options */);

		"1. ERROR in X.java (at line 5)\n" +
		"	void foo(int value) { // X#foo(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"2. ERROR in X.java (at line 7)\n" +
		"	void bar(int value) { // X#bar(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"3. ERROR in X.java (at line 24)\n" +
		"	void parent(int value) { /* Parent#parent(...) */}\n" +
		"	                ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n",
		// javac options
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError /* javac test options */);

		"1. ERROR in X.java (at line 5)\n" +
		"	void foo(int value) { // X#foo(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"2. ERROR in X.java (at line 7)\n" +
		"	void bar(int value) { // X#bar(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"3. ERROR in X.java (at line 10)\n" +
		"	void top(int value) { /* X#top(...)*/}\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"4. ERROR in X.java (at line 11)\n" +
		"	void parent(int value) { /* X#parent(...) */}\n" +
		"	                ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"5. ERROR in X.java (at line 12)\n" +
		"	public void doit(int value) { /* X#doit(...) */}\n" +
		"	                     ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"6. ERROR in X.java (at line 24)\n" +
		"	void parent(int value) { /* Parent#parent(...) */}\n" +
		"	                ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n",
		// javac options
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError /* javac test options */);

		"1. ERROR in X.java (at line 3)\n" +
		"	void foo(int value) { // X#foo(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"2. ERROR in X.java (at line 5)\n" +
		"	void bar(int value) { // X#bar(...)\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"3. ERROR in X.java (at line 9)\n" +
		"	void top(int value) { /* X#top(...)*/}\n" +
		"	             ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"4. ERROR in X.java (at line 11)\n" +
		"	void parent(int value) { /* X#parent(...) */}\n" +
		"	                ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"5. ERROR in X.java (at line 13)\n" +
		"	public void doit(int value) { /* X#doit(...) */}\n" +
		"	                     ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n" +
		"6. ERROR in X.java (at line 21)\n" +
		"	void parent(int value) { /* Parent#parent(...) */}\n" +
		"	                ^^^^^\n" +
		"The parameter value is never used\n" +
		"----------\n",
		// javac options
		JavacTestOptions.Excuse.EclipseWarningConfiguredAsError /* javac test options */);




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"1. WARNING in p1\\A.java (at line 3)\n" +
		"	private int value;								\n" +
		"	            ^^^^^\n" +
		"The private field A.value is never used\n" +
		"----------\n" +
		"2. ERROR in p1\\A.java (at line 6)\n" +
		"	value = 2;								\n" +

		"1. WARNING in p1\\A.java (at line 3)\n" +
		"	private String success = \"SUCCESS\";			\n" +
		"	               ^^^^^^^\n" +
		"The private field A.success is never used\n" +
		"----------\n" +
		"2. ERROR in p1\\A.java (at line 7)\n" +
		"	public void aTask() {System.out.println(A.success);}\n" +

				"1. WARNING in com\\internap\\other\\ScopeExample.java (at line 4)\r\n" +
				"	private static final String LOGGER = \"FAILED\";\r\n" +
				"	                            ^^^^^^\n" +
				"The private field ScopeExample.LOGGER is never used\n" +
				"----------\n" +
				"2. ERROR in com\\internap\\other\\ScopeExample.java (at line 8)\r\n" +
				"	System.out.println(LOGGER);\r\n" +

		"1. WARNING in X.java (at line 2)\n" +
		"	private String value;\n" +
		"	               ^^^^^\n" +
		"The private field D.value is never used\n" +
		"----------\n" +
		"2. ERROR in X.java (at line 13)\n" +
		"	super(getValue());\n" +

		"2. WARNING in B.java (at line 3)\n" + 
		"	public final String length = \"very long\";\n" + 
		"	                    ^^^^^^\n" + 
		"The field A.B.length is never used locally\n" + 
		"----------\n" + 
		"3. WARNING in B.java (at line 5)\n" + 
		"	private int [] B = new int[5];\n" + 
		"	               ^\n" + 
		"The private field A.B is never used\n" + 
		"----------\n" + 
		"4. ERROR in B.java (at line 9)\n" + 
		"	System.out.println(A.B.length);\n" + 

		"1. WARNING in B.java (at line 3)\n" + 
		"	private final String length = \"very long\";\n" + 
		"	                     ^^^^^^\n" + 
		"The private field A.B.length is never used\n" + 
		"----------\n" + 
		"2. WARNING in B.java (at line 5)\n" + 
		"	private int [] B = new int[5];\n" + 
		"	               ^\n" + 
		"The private field A.B is never used\n" + 
		"----------\n" + 
		"3. ERROR in B.java (at line 9)\n" + 
		"	System.out.println(A.B.length);\n" + 

		"1. WARNING in A.java (at line 2)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.x is never used\n" + 
		"----------\n" + 
		"2. WARNING in A.java (at line 4)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.B.x is never used\n" + 
		"----------\n" + 
		"3. WARNING in A.java (at line 5)\n" + 
		"	private C c = new C() {\n" + 
		"	          ^\n" + 
		"The private field A.B.c is never used\n" + 
		"----------\n" + 
		"4. WARNING in A.java (at line 6)\n" + 
		"	void foo() {\n" + 

		"6. WARNING in A.java (at line 12)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.C.x is never used\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=316956

		"1. WARNING in A.java (at line 2)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.x is never used\n" + 
		"----------\n" + 
		"2. WARNING in A.java (at line 4)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.B.x is never used\n" + 
		"----------\n" + 
		"3. WARNING in A.java (at line 5)\n" + 
		"	private C c = new C() {\n" + 
		"	          ^\n" + 
		"The private field A.B.c is never used\n" + 
		"----------\n" + 
		"4. WARNING in A.java (at line 6)\n" + 
		"	void foo() {\n" + 

		"1. WARNING in A.java (at line 2)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.x is never used\n" + 
		"----------\n" + 
		"2. WARNING in A.java (at line 3)\n" + 
		"	private C c = new C() {\n" + 
		"	          ^\n" + 
		"The private field A.c is never used\n" + 
		"----------\n" + 
		"3. WARNING in A.java (at line 4)\n" + 
		"	void foo() {\n" + 

		"5. WARNING in A.java (at line 9)\n" + 
		"	private int x;\n" + 
		"	            ^\n" + 
		"The private field A.C.x is never used\n" + 
		"----------\n");
}
public static Class testClass() {	return LookupTest.class;

Lines 1-5 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/ProblemConstructorTest.java (-2 / +3 lines)
1	/*******************************************************************************	1	/*******************************************************************************
2	* Copyright (c) 2000, 2009 IBM Corporation and others.	2	* Copyright (c) 2000, 2010 IBM Corporation and others.
3	* All rights reserved. This program and the accompanying materials	3	* All rights reserved. This program and the accompanying materials
4	* are made available under the terms of the Eclipse Public License v1.0	4	* are made available under the terms of the Eclipse Public License v1.0
5	* which accompanies this distribution, and is available at	5	* which accompanies this distribution, and is available at
Lines 7-12 Link Here
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.core.tests.compiler.regression;	12	package org.eclipse.jdt.core.tests.compiler.regression;
12		13
Lines 185-191 Link Here
185	"3. WARNING in X.java (at line 6)\n" +	186	"3. WARNING in X.java (at line 6)\n" +
186	" public int unusedField = 0;\n" +	187	" public int unusedField = 0;\n" +
187	" ^^^^^^^^^^^\n" +	188	" ^^^^^^^^^^^\n" +
188	"The field X.M.unusedField is never read locally\n" +	189	"The field X.M.unusedField is never used locally\n" +
189	"----------\n" +	190	"----------\n" +
190	"4. WARNING in X.java (at line 7)\n" +	191	"4. WARNING in X.java (at line 7)\n" +
191	" public class N {}\n" +	192	" public class N {}\n" +




 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *     Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
 *******************************************************************************/
package org.eclipse.jdt.core.tests.compiler.regression;


		"1. WARNING in X.java (at line 2)\r\n" +
		"	public void foo(boolean b) {\r\n" +
		"	                        ^\n" +
		"The parameter b is never used\n" +
		"----------\n" /* expectedCompilerLog */,
		"" /* expectedOutputString */,
		false /* forceExecution */,

		"1. WARNING in X.java (at line 3)\n" +
		"	public void foo(boolean b) {\n" +
		"	                        ^\n" +
		"The parameter b is never used\n" +
		"----------\n" /* expectedCompilerLog */,
		"" /* expectedOutputString */,
		false /* forceExecution */,

		"1. ERROR in X.java (at line 2)\r\n" +
		"	public void foo(boolean b) {\r\n" +
		"	                        ^\n" +
		"The parameter b is never used\n" +
		"----------\n" /* expectedCompilerLog */,
		"" /* expectedOutputString */,
		false /* forceExecution */,

		"1. WARNING in X.java (at line 3)\n" +
		"	void foo(int unused) throws IOException {}\n" +
		"	             ^^^^^^\n" +
		"The parameter unused is never used\n" +
		"----------\n" +
		"2. ERROR in X.java (at line 3)\n" +
		"	void foo(int unused) throws IOException {}\n" +

		"1. WARNING in X.java (at line 3)\n" +
		"	void foo(int unused) throws IOException {}\n" +
		"	             ^^^^^^\n" +
		"The parameter unused is never used\n" +
		"----------\n" +
		"2. WARNING in X.java (at line 3)\n" +
		"	void foo(int unused) throws IOException {}\n" +

		"1. ERROR in X.java (at line 2)\n" +
		"	public X(boolean b) {\n" +
		"	                 ^\n" +
		"The parameter b is never used\n" +
		"----------\n" /* expectedCompilerLog */,
		"" /* expectedOutputString */,
		false /* forceExecution */,

		"The assignment to variable nvx has no effect\n" + 
		"----------\n");
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
public void test0046() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    int foo() {\n" + 
				"        int i=1;\n" + 
				"        boolean b=false;\n" + 
				"        b|=true;\n" + 			// not a relevant usage
				"        int k = 2;\n" + 
				"        --k;\n" + 				// not a relevant usage
				"        k+=3;\n" + 			// not a relevant usage
				"        Integer j = 3;\n" + 
				"        j++;\n" + 				// relevant because unboxing is involved
				"        i++;\n" +				// not relevant but should still not report because next is relevant
				"        return i++;\n" + 		// value after increment is used
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 4)\n" + 
			"	boolean b=false;\n" + 
			"	        ^\n" + 
			"The local variable b is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 6)\n" + 
			"	int k = 2;\n" + 
			"	    ^\n" + 
			"The local variable k is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// variant with private fields instead of locals
public void test0046_field() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    private int i=1;\n" + 
				"    private boolean b=false;\n" + 
				"    private int k = 2;\n" + 
				"    private Integer j = 3;\n" + 
				"    int foo() {\n" + 
				"        b|=true;\n" + 			// not a relevant usage
				"        --k;\n" + 				// not a relevant usage
				"        k+=3;\n" + 			// not a relevant usage
				"        j++;\n" + 				// relevant because unboxing is involved
				"        return i++;\n" + 		// value after increment is used
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 3)\n" + 
			"	private boolean b=false;\n" + 
			"	                ^\n" + 
			"The private field X.b is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 4)\n" + 
			"	private int k = 2;\n" + 
			"	            ^\n" + 
			"The private field X.k is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// variant with private fields instead of locals - this-qualified access
public void test0046_field_this_qualified() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    private int i=1;\n" + 
				"    private boolean b=false;\n" + 
				"    private int k = 2;\n" + 
				"    private Integer j = 3;\n" + 
				"    int foo() {\n" + 
				"        this.b|=true;\n" + 		// not a relevant usage
				"        --this.k;\n" + 			// not a relevant usage
				"        getThis().k+=3;\n" + 		// not a relevant usage
				"        this.j++;\n" + 			// relevant because unboxing is involved
				"        return this.i++;\n" + 		// value after increment is used
				"    }\n" +
				"    X getThis() { return this; }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 3)\n" + 
			"	private boolean b=false;\n" + 
			"	                ^\n" + 
			"The private field X.b is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 4)\n" + 
			"	private int k = 2;\n" + 
			"	            ^\n" + 
			"The private field X.k is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// variant with private fields instead of locals - regular qualified access
public void test0046_field_qualified() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    private int i=1;\n" + 
				"    private boolean b=false;\n" + 
				"    private int k = 2;\n" + 
				"    private Integer j = 3;\n" + 
				"    int foo(X that) {\n" + 
				"        that.b|=true;\n" + 		// not a relevant usage
				"        --that.k;\n" + 			// not a relevant usage
				"        that.k+=3;\n" + 			// not a relevant usage
				"        that.j++;\n" + 			// relevant because unboxing is involved
				"        that.i++;\n"+				// not relevant but should still not report because next is relevant
				"        return that.i++;\n" + 		// value after increment is used
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 3)\n" + 
			"	private boolean b=false;\n" + 
			"	                ^\n" + 
			"The private field X.b is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 4)\n" + 
			"	private int k = 2;\n" + 
			"	            ^\n" + 
			"The private field X.k is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// variant with fields inside a private type
public void test0046_field_in_private_type() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" +
				"    private class Y {\n" + 
				"        int i=1;\n" + 
				"        public boolean b=false;\n" + 
				"        protected int k = 2;\n" + 
				"        Integer j = 3;\n" +
				"    }\n" + 
				"    int foo(Y y) {\n" + 
				"        y.b|=true;\n" + 				// not a relevant usage
				"        --y.k;\n" + 					// not a relevant usage
				"        y.k+=3;\n" + 					// not a relevant usage
				"        y.j++;\n" + 					// relevant because unboxing is involved
				"        int result = y.i++;\n" + 	// value after increment is used
				"        y.i++;\n" +					// not relevant, but previous is
				"        return result;\n" +
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 4)\n" + 
			"	public boolean b=false;\n" + 
			"	               ^\n" + 
			"The field X.Y.b is never used locally\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 5)\n" + 
			"	protected int k = 2;\n" + 
			"	              ^\n" + 
			"The field X.Y.k is never used locally\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
public void test0047() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedParameter, CompilerOptions.WARNING);
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    void foo(int param1, int param2, Integer param3) {\n" + 
				"        boolean b=false;\n" + 
				"        b|=true;\n" + 			// not a relevant usage
				"        param1++;\n" + 		// not a relevant usage
				"        {\n" +
				"            int val=23;\n" +
				"            param2 += val;\n" +// not a relevant usage of param2
				"        }\n" +
				"        param3++;\n" + 		// relevant because unboxing is involved
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 2)\n" + 
			"	void foo(int param1, int param2, Integer param3) {\n" + 
			"	             ^^^^^^\n" + 
			"The parameter param1 is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 2)\n" + 
			"	void foo(int param1, int param2, Integer param3) {\n" + 
			"	                         ^^^^^^\n" + 
			"The parameter param2 is never used\n" + 
			"----------\n" + 
			"3. WARNING in X.java (at line 3)\n" + 
			"	boolean b=false;\n" + 
			"	        ^\n" + 
			"The local variable b is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// To verify that unused parameter warning is not shown for an implementing method's parameter when
// CompilerOptions.OPTION_ReportUnusedParameterWhenImplementingAbstract is disabled
public void test0048() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedParameter, CompilerOptions.WARNING);
	customOptions.put(CompilerOptions.OPTION_ReportUnusedParameterWhenImplementingAbstract, CompilerOptions.DISABLED);
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"public class X extends A implements Y{\n" + 
				"   public void foo(int param1, int param2, Integer param3) {\n" + // implementing method, so dont warn
				"        boolean b=false;\n" + 
				"        b|=true;\n" + 			// not a relevant usage
				"        param1++;\n" + 		// not a relevant usage
				"        param2 += 1;\n" + 		// not a relevant usage
				"        param3++;\n" + 		// relevant because unboxing is involved
				"    }\n" + 
				"   public void foo(int param1, int param2) {\n" + // warn
				"        boolean b=false;\n" + 
				"        b|=true;\n" + 			// not a relevant usage
				"        param1++;\n" + 		// not a relevant usage
				"        param2 += 1;\n" + 		// not a relevant usage
				"    }\n" +
				"   public void bar(int param1, int param2, Integer param3) {\n" + // implementing method, so dont warn
				"        param1++;\n" + 		// not a relevant usage
				"        param2 += 1;\n" + 		// not a relevant usage
				"        param3++;\n" + 		// relevant because unboxing is involved
				"    }\n" +
				"}\n" +
				"interface Y{\n" +
				"	public void foo(int param1, int param2, Integer param3);" +
				"}\n" +
				"abstract class A{\n" +
				"	public abstract void bar(int param1, int param2, Integer param3);" +
				"}\n"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 3)\n" + 
			"	boolean b=false;\n" + 
			"	        ^\n" + 
			"The local variable b is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 9)\n" + 
			"	public void foo(int param1, int param2) {\n" + 
			"	                    ^^^^^^\n" + 
			"The parameter param1 is never used\n" + 
			"----------\n" + 
			"3. WARNING in X.java (at line 9)\n" + 
			"	public void foo(int param1, int param2) {\n" + 
			"	                                ^^^^^^\n" + 
			"The parameter param2 is never used\n" + 
			"----------\n" + 
			"4. WARNING in X.java (at line 10)\n" + 
			"	boolean b=false;\n" + 
			"	        ^\n" + 
			"The local variable b is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// To verify that unused parameter warning is not shown for an overriding method's parameter when
// CompilerOptions.OPTION_ReportUnusedParameterWhenOverridingConcrete is disabled
public void test0049() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedParameter, CompilerOptions.WARNING);
	customOptions.put(CompilerOptions.OPTION_ReportUnusedParameterWhenOverridingConcrete, CompilerOptions.DISABLED);
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"public class X extends A {\n" + 
				"   public void foo(int param1, int param2, Integer param3) {\n" + // overriding method, so dont warn
				"        boolean b=false;\n" + 
				"        b|=true;\n" + 			// not a relevant usage
				"        param1++;\n" + 		// not a relevant usage
				"        param2 += 1;\n" + 		// not a relevant usage
				"        param3++;\n" + 		// relevant because unboxing is involved
				"    }\n" + 
				"   public void foo(int param1, Integer param3) {\n" + // overriding method, so dont warn
				"        param1++;\n" + 		// not a relevant usage
				"        param3++;\n" + 		// relevant because unboxing is involved
				"    }\n" + 
				"}\n" +
				"class A{\n" +
				"   public void foo(int param1, int param2, Integer param3) {\n" +
				"        param1 -=1;\n" + 		// not a relevant usage
				"        param2--;\n" + 		// not a relevant usage
				"        param3--;\n" + 		// relevant because unboxing is involved
				"    }\n" + 
				"}\n"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 3)\n" + 
			"	boolean b=false;\n" + 
			"	        ^\n" + 
			"The local variable b is never used\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 9)\n" + 
			"	public void foo(int param1, Integer param3) {\n" + 
			"	                    ^^^^^^\n" + 
			"The parameter param1 is never used\n" + 
			"----------\n" + 
			"3. WARNING in X.java (at line 15)\n" + 
			"	public void foo(int param1, int param2, Integer param3) {\n" + 
			"	                    ^^^^^^\n" + 
			"The parameter param1 is never used\n" + 
			"----------\n" + 
			"4. WARNING in X.java (at line 15)\n" + 
			"	public void foo(int param1, int param2, Integer param3) {\n" + 
			"	                                ^^^^^^\n" + 
			"The parameter param2 is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// To verify that unused local warning is not shown for locals declared in unreachable code
public void test0050() {
	if (this.complianceLevel < ClassFileConstants.JDK1_5)
		return;
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedLocal, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    int foo() {\n" + 
				"        int i=1;\n" +
				"		 if (false) {\n" + 
				"        	boolean b=false;\n" + // don't complain as unused
				"        	b|=true;\n" +
				"		 }\n" + 			// not a relevant usage
				"        int k = 2;\n" + 
				"        --k;\n" + 			// not a relevant usage
				"        k+=3;\n" + 		// not a relevant usage
				"        Integer j = 3;\n" + 
				"        j++;\n" + 			// relevant because unboxing is involved
				"        return i++;\n" + 	// value after increment is used
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 4)\n" + 
			"	if (false) {\n" + 
			"        	boolean b=false;\n" + 
			"        	b|=true;\n" + 
			"		 }\n" + 
			"	           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" + 
			"Dead code\n" + 
			"----------\n" + 
			"2. WARNING in X.java (at line 8)\n" + 
			"	int k = 2;\n" + 
			"	    ^\n" + 
			"The local variable k is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
// https://bugs.eclipse.org/bugs/show_bug.cgi?id=185682
// To verify that we dont throw CCE if we're looking for uselessly read arguments in a constructor
public void test0051() {
	Map customOptions = getCompilerOptions();
	customOptions.put(CompilerOptions.OPTION_ReportUnusedParameter, CompilerOptions.WARNING);
	this.runNegativeTest(
			new String[] {
				"X.java",
				"class X {\n" + 
				"    X(int abc) {\n" + 
				"        abc++;\n" +	// not a relevant usage
				"    }\n" + 
				"}"
			},
			"----------\n" + 
			"1. WARNING in X.java (at line 2)\n" + 
			"	X(int abc) {\n" + 
			"	      ^^^\n" + 
			"The parameter abc is never used\n" + 
			"----------\n",
			null/*classLibraries*/,
			true/*shouldFlushOutputDirectory*/,
			customOptions);
}
}

Lines 7-12 Link Here

(-)src/org/eclipse/jdt/core/tests/compiler/regression/StaticImportTest.java (-1 / +2 lines)
7	*	7	*
8	* Contributors:	8	* Contributors:
9	* IBM Corporation - initial API and implementation	9	* IBM Corporation - initial API and implementation
		10	* Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
10	*******************************************************************************/	11	*******************************************************************************/
11	package org.eclipse.jdt.core.tests.compiler.regression;	12	package org.eclipse.jdt.core.tests.compiler.regression;
12		13
Lines 660-666 Link Here
660	"1. WARNING in bug\\C.java (at line 3)\n" +	661	"1. WARNING in bug\\C.java (at line 3)\n" +
661	" private static B b;\n" +	662	" private static B b;\n" +
662	" ^\n" +	663	" ^\n" +
663	"The field C.b is never read locally\n" +	664	"The private field C.b is never used\n" +
664	"----------\n");	665	"----------\n");
665	}	666	}
666		667

Return to bug 185682

Lines 8-13 Link Here

(-)compiler/org/eclipse/jdt/internal/compiler/problem/messages.properties (-3 / +5 lines)
8	# Contributors:	8	# Contributors:
9	# IBM Corporation - initial API and implementation	9	# IBM Corporation - initial API and implementation
10	# Benjamin Muskalla - Contribution for bug 239066	10	# Benjamin Muskalla - Contribution for bug 239066
		11	# Stephan Herrmann <stephan@cs.tu-berlin.de> - Contribution for bug 185682 - Increment/decrement operators mark local variables as read
11	###############################################################################	12	###############################################################################
12	0 = {0}	13	0 = {0}
13	1 = super cannot be used in java.lang.Object	14	1 = super cannot be used in java.lang.Object
Lines 49-56 Link Here
49	58 = The final local variable {0} cannot be assigned. It must be blank and not using a compound assignment	50	58 = The final local variable {0} cannot be assigned. It must be blank and not using a compound assignment
50	59 = The parameter {0} should not be assigned	51	59 = The parameter {0} should not be assigned
51	60 = The final local variable {0} cannot be assigned, since it is defined in an enclosing type	52	60 = The final local variable {0} cannot be assigned, since it is defined in an enclosing type
52	61 = The local variable {0} is never read	53	61 = The local variable {0} is never used
53	62 = The parameter {0} is never read	54	62 = The parameter {0} is never used
54	63 = The code of method {0}({1}) is exceeding the 65535 bytes limit	55	63 = The code of method {0}({1}) is exceeding the 65535 bytes limit
55	64 = The code for the static initializer is exceeding the 65535 bytes limit	56	64 = The code for the static initializer is exceeding the 65535 bytes limit
56	65 = Too many parameters, parameter {0} is exceeding the limit of 255 words eligible for method parameters	57	65 = Too many parameters, parameter {0} is exceeding the limit of 255 words eligible for method parameters
Lines 65-77 Link Here
65	74 = Cannot make a static reference to the non-static field {0}	66	74 = Cannot make a static reference to the non-static field {0}
66	75 = Cannot reference a field before it is defined	67	75 = Cannot reference a field before it is defined
67	76 = The static field {0}.{1} should be accessed in a static way	68	76 = The static field {0}.{1} should be accessed in a static way
68	77 = The field {0}.{1} is never read locally	69	77 = The private field {0}.{1} is never used
69	78 = The static field {0}.{1} should be accessed directly	70	78 = The static field {0}.{1} should be accessed directly
70	79 = Unqualified access to the field {0}.{1}	71	79 = Unqualified access to the field {0}.{1}
71	80 = The final field {0}.{1} cannot be assigned	72	80 = The final field {0}.{1} cannot be assigned
72	81 = The blank final field {0} may not have been initialized	73	81 = The blank final field {0} may not have been initialized
73	82 = The final field {0} may already have been assigned	74	82 = The final field {0} may already have been assigned
74	83 = {0} cannot be resolved to a variable	75	83 = {0} cannot be resolved to a variable
		76	84 = The field {0}.{1} is never used locally
75		77
76	90 = The local variable {0} is hiding another local variable defined in an enclosing type scope	78	90 = The local variable {0} is hiding another local variable defined in an enclosing type scope
77	91 = The local variable {0} is hiding a field from type {1}	79	91 = The local variable {0} is hiding a field from type {1}