Attachment 177851 Details for Bug 316827 – proposed patch

[patch] proposed patch

patch316827.txt (text/plain), 2.62 KB, created by Ayushman Jain

on 2010-08-31 11:20:07 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ayushman Jain

Created: 2010-08-31 11:20:07 EDT

Size: 2.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java,v
>retrieving revision 1.210
>diff -u -r1.210 BatchCompilerTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java	25 Aug 2010 11:11:58 -0000	1.210
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java	31 Aug 2010 15:19:12 -0000
>@@ -830,8 +830,8 @@
> 	abstract String expected(); // for use in JUnit comparison framework
> }
> static class StringMatcher extends Matcher {
>-	private String expected;
>-	private Normalizer normalizer;
>+	private final String expected;
>+	private final Normalizer normalizer;
> 	StringMatcher(String expected, Normalizer normalizer) {
> 		this.expected = expected;
> 		this.normalizer = normalizer;
>@@ -850,7 +850,7 @@
> 	}
> }
> static class SubstringMatcher extends Matcher {
>-	private String substring;
>+	private final String substring;
> 	SubstringMatcher(String substring) {
> 		this.substring = substring;
> 	}
>@@ -878,7 +878,7 @@
> 	 * here, that is {@link #normalized(String) normalized}.
> 	 */
> 	private static abstract class Normalizer {
>-		private Normalizer nextInChain;
>+		private final Normalizer nextInChain;
> 		Normalizer(Normalizer nextInChain) {
> 			this.nextInChain = nextInChain;
> 		}
>@@ -897,9 +897,9 @@
> 	 * placeholder.
> 	 */
> 	private static class StringNormalizer extends Normalizer {
>-		private String match;
>-		private int matchLength;
>-		private String placeholder;
>+		private final String match;
>+		private final int matchLength;
>+		private final String placeholder;
> 		StringNormalizer(Normalizer nextInChain, String match, String placeholder) {
> 			super(nextInChain);
> 			this.match = match;
>@@ -973,7 +973,8 @@
> 	 * This normalizer removes a selected range of lines from a log file.
> 	 */
> 	private static class LinesRangeNormalizer extends Normalizer {
>-		private int first, number;
>+		private final int first;
>+		private int number;
> 
> 		LinesRangeNormalizer() {
> 			super(null);
>@@ -3851,6 +3852,9 @@
> // code)
> // this test only works on appropriate file systems
> public void test055(){
>+	String os= System.getProperty("os.name");
>+    if (!os.startsWith("Windows")) // https://bugs.eclipse.org/bugs/show_bug.cgi?id=316827
>+    	return;
> 	if (File.separatorChar == '/') {
> 	  	String tentativeOutputDirNameTail =
> 	      	File.separator + "out";

Actions: View | Diff

Attachments on bug 316827: 177851 | 177852 | 179559