Attachment 17686 Details for Bug 71460 – Another patch to fix hardcoded dependecy on java extension

[patch] Another patch to fix hardcoded dependecy on java extension

patch.txt (text/plain), 1.83 KB, created by Alex Smirnoff

on 2005-02-04 10:49:36 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Smirnoff

Created: 2005-02-04 10:49:36 EST

Size: 1.83 KB

patch

obsolete

>Index: Util.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/Util.java,v
>retrieving revision 1.44
>diff -u -r1.44 Util.java
>--- Util.java	12 Jan 2005 20:36:13 -0000	1.44
>+++ Util.java	4 Feb 2005 15:36:40 -0000
>@@ -436,35 +436,16 @@
> 		return false;
> 	}			
> 	/**
>-	 * Returns true iff str.toLowerCase().endsWith(".java")
>-	 * implementation is not creating extra strings.
>+	 * Returns true if name ends with one of the known java like extesnion
> 	 */
> 	public final static boolean isJavaFileName(char[] name) {
>-		int nameLength = name == null ? 0 : name.length;
>-		int suffixLength = SUFFIX_JAVA.length;
>-		if (nameLength < suffixLength) return false;
>-
>-		for (int i = 0, offset = nameLength - suffixLength; i < suffixLength; i++) {
>-			char c = name[offset + i];
>-			if (c != SUFFIX_java[i] && c != SUFFIX_JAVA[i]) return false;
>-		}
>-		return true;		
>+		return org.eclipse.jdt.internal.core.util.Util.isJavaLikeFileName(name);
> 	}
> 	/**
>-	 * Returns true iff str.toLowerCase().endsWith(".java")
>-	 * implementation is not creating extra strings.
>+	 * Returns true if name ends with one of the known java like extesnion
> 	 */
> 	public final static boolean isJavaFileName(String name) {
>-		int nameLength = name == null ? 0 : name.length();
>-		int suffixLength = SUFFIX_JAVA.length;
>-		if (nameLength < suffixLength) return false;
>-
>-		for (int i = 0; i < suffixLength; i++) {
>-			char c = name.charAt(nameLength - i - 1);
>-			int suffixIndex = suffixLength - i - 1;
>-			if (c != SUFFIX_java[suffixIndex] && c != SUFFIX_JAVA[suffixIndex]) return false;
>-		}
>-		return true;		
>+		return org.eclipse.jdt.internal.core.util.Util.isJavaLikeFileName(name);
> 	}
> 	/**
> 	 * Creates a NLS catalog for the given locale.

Actions: View | Diff

Attachments on bug 71460: 17658 | 17686