Attachment 17569 Details for Bug 83965 – Apply on HEAD of jdt.core project

[patch] Apply on HEAD of jdt.core project

patch_for_83965.txt (text/plain), 1.17 KB, created by Olivier Thomann

on 2005-01-29 18:16:56 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2005-01-29 18:16:56 EST

Size: 1.17 KB

patch

obsolete

>Index: Expression.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/Expression.java,v
>retrieving revision 1.60
>diff -u -r1.60 Expression.java
>--- Expression.java	13 Jan 2005 20:55:34 -0000	1.60
>+++ Expression.java	29 Jan 2005 23:14:58 -0000
>@@ -245,16 +245,15 @@
> 					return true;
> 					
> 				}
>-			} else if (use15specifics) { // unboxing - only exact match is allowed
>-				if (env.computeBoxingType(expressionType) == castType) {
>-					// TODO (philippe) could tagAsUnnecessaryCast(scope, castType);  
>-					return true;
>-				}
>+			} else if (use15specifics  && env.computeBoxingType(expressionType).isCompatibleWith(castType)) {
>+				// unboxing 
>+				tagAsUnnecessaryCast(scope, castType);				
>+				return true;
> 			}
> 			return false;
> 		} else if (use15specifics && expressionType.isBaseType()) { // boxing - only exact match is allowed
> 			if (env.computeBoxingType(castType) == expressionType) {
>-				// TODO (philippe) could tagAsUnnecessaryCast(scope, castType);  
>+				tagAsUnnecessaryCast(scope, castType);				
> 				return true;
> 			}
> 		}

Actions: View | Diff

Attachments on bug 83965: 17565 | 17569