Attachment 175634 Details for Bug 317046 – avoiding the cast

[patch] avoiding the cast

Bug_317046.patch (text/plain), 2.04 KB, created by Stephan Herrmann

on 2010-07-30 19:29:28 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Herrmann

Created: 2010-07-30 19:29:28 EDT

Size: 2.04 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/TypeBinding.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/TypeBinding.java,v
>retrieving revision 1.109
>diff -u -r1.109 TypeBinding.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/TypeBinding.java	24 Jun 2010 07:16:15 -0000	1.109
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/TypeBinding.java	30 Jul 2010 23:24:56 -0000
>@@ -630,23 +630,22 @@
> 		            return false;
> 
> 		    	case Binding.GENERIC_TYPE :
>-		            SourceTypeBinding otherGenericType = (SourceTypeBinding) otherType;
>-		            if (paramType.genericType() != otherGenericType)
>+		            if (paramType.genericType() != otherType)
> 		                return true;
> 		            if (!paramType.isStatic()) { // static member types do not compare their enclosing
> 		            	ReferenceBinding enclosing = enclosingType();
> 		            	if (enclosing != null) {
>-		            		ReferenceBinding otherEnclosing = otherGenericType.enclosingType();
>+		            		ReferenceBinding otherEnclosing = (otherType).enclosingType();
> 		            		if (otherEnclosing == null) return true;
> 		            		if ((otherEnclosing.tagBits & TagBits.HasDirectWildcard) == 0) {
> 								if (enclosing != otherEnclosing) return true;
> 		            		} else {
>-		            			if (!enclosing.isEquivalentTo(otherGenericType.enclosingType())) return true;
>+		            			if (!enclosing.isEquivalentTo(otherType.enclosingType())) return true;
> 		            		}
> 		            	}
> 		            }
> 		            length = paramType.arguments == null ? 0 : paramType.arguments.length;
>-		            otherArguments = otherGenericType.typeVariables();
>+		            otherArguments =  otherType.typeVariables();
> 		            otherLength = otherArguments == null ? 0 : otherArguments.length;
> 		            if (otherLength != length)
> 		                return true;

Flags:

srikanth_sankaran: iplog+
srikanth_sankaran: review+

Actions: View | Diff

Attachments on bug 317046: 175634