### Eclipse Workspace Patch 1.0 #P org.eclipse.mylyn.tasks.ui Index: src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java =================================================================== RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java,v retrieving revision 1.78 diff -u -r1.78 AbstractRepositorySettingsPage.java --- src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java 8 Feb 2010 04:00:25 -0000 1.78 +++ src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java 8 Jun 2010 11:46:38 -0000 @@ -290,8 +290,11 @@ } }); - GridDataFactory.fillDefaults().hint(300, SWT.DEFAULT).grab(true, false).span(2, SWT.DEFAULT).applyTo( - serverUrlCombo); + GridDataFactory.fillDefaults() + .hint(300, SWT.DEFAULT) + .grab(true, false) + .span(2, SWT.DEFAULT) + .applyTo(serverUrlCombo); repositoryLabelEditor = new StringFieldEditor("", LABEL_REPOSITORY_LABEL, StringFieldEditor.UNLIMITED, //$NON-NLS-1$ compositeContainer) { @@ -318,6 +321,16 @@ disconnectedButton = new Button(compositeContainer, SWT.CHECK); disconnectedButton.setText(Messages.AbstractRepositorySettingsPage_Disconnected); disconnectedButton.setSelection(repository != null ? repository.isOffline() : false); + disconnectedButton.addSelectionListener(new SelectionAdapter() { + @Override + public void widgetSelected(SelectionEvent e) { + super.widgetSelected(e); + isPageComplete(); + if (getWizard() != null) { + getWizard().getContainer().updateButtons(); + } + } + }); repositoryUserNameEditor = new StringFieldEditor("", LABEL_USER, StringFieldEditor.UNLIMITED, //$NON-NLS-1$ compositeContainer) { @@ -385,6 +398,16 @@ savePasswordButton = new Button(compositeContainer, SWT.CHECK); savePasswordButton.setText(Messages.AbstractRepositorySettingsPage_Save_Password); + savePasswordButton.addSelectionListener(new SelectionAdapter() { + @Override + public void widgetSelected(SelectionEvent e) { + super.widgetSelected(e); + isPageComplete(); + if (getWizard() != null) { + getWizard().getContainer().updateButtons(); + } + } + }); if (repository != null) { try { @@ -622,8 +645,11 @@ section.setClient(httpAuthComp); httpAuthButton = new Button(httpAuthComp, SWT.CHECK); - GridDataFactory.fillDefaults().indent(0, 5).align(SWT.LEFT, SWT.TOP).span(3, SWT.DEFAULT).applyTo( - httpAuthButton); + GridDataFactory.fillDefaults() + .indent(0, 5) + .align(SWT.LEFT, SWT.TOP) + .span(3, SWT.DEFAULT) + .applyTo(httpAuthButton); httpAuthButton.setText(Messages.AbstractRepositorySettingsPage_Enable_http_authentication); @@ -1285,7 +1311,7 @@ */ protected boolean isMissingCredentials() { return repositoryUserNameEditor.getStringValue().trim().equals("") //$NON-NLS-1$ - || repositoryPasswordEditor.getStringValue().trim().equals(""); //$NON-NLS-1$ + || (getSavePassword() && repositoryPasswordEditor.getStringValue().trim().equals("")); //$NON-NLS-1$ } /**