Attachment 170328 Details for Bug 314842 – patch that fixes the problem described under a)

[patch] patch that fixes the problem described under a)

patch (text/plain), 1.55 KB, created by Christian Campo

on 2010-05-28 07:24:06 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Campo

Created: 2010-05-28 07:24:06 EDT

Size: 1.55 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.riena.ui.ridgets.swt
>Index: src/org/eclipse/riena/internal/ui/ridgets/swt/NumericTextRidget.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.ridgets.swt/src/org/eclipse/riena/internal/ui/ridgets/swt/NumericTextRidget.java,v
>retrieving revision 1.37
>diff -u -r1.37 NumericTextRidget.java
>--- src/org/eclipse/riena/internal/ui/ridgets/swt/NumericTextRidget.java	25 May 2010 12:41:23 -0000	1.37
>+++ src/org/eclipse/riena/internal/ui/ridgets/swt/NumericTextRidget.java	28 May 2010 11:23:07 -0000
>@@ -19,6 +19,7 @@
> 
> import org.eclipse.core.databinding.BindingException;
> import org.eclipse.core.databinding.conversion.IConverter;
>+import org.eclipse.core.databinding.observable.value.IObservableValue;
> import org.eclipse.core.runtime.Assert;
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.events.FocusAdapter;
>@@ -487,8 +488,12 @@
> 	}
> 
> 	private void checkValue() {
>-		Object value = getValueBindingSupport().getModelObservable().getValue();
>-		Class<?> type = (Class<?>) getValueBindingSupport().getModelObservable().getValueType();
>+		IObservableValue modelObservable = getValueBindingSupport().getModelObservable();
>+		if (modelObservable == null) {
>+			return;
>+		}
>+		Object value = modelObservable.getValue();
>+		Class<?> type = (Class<?>) modelObservable.getValueType();
> 		IConverter converter = getConverter(type, Integer.MAX_VALUE);
> 		if (converter != null) {
> 			checkNumber((String) converter.convert(value));

Actions: View | Diff

Attachments on bug 314842: 170328 | 170329