Attachment 160683 Details for Bug 304416 – Proposed fix

[patch] Proposed fix

patch_304416.txt (text/plain), 1.97 KB, created by Olivier Thomann

on 2010-03-02 15:44:19 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2010-03-02 15:44:19 EST

Size: 1.97 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/BlockScope.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/BlockScope.java,v
>retrieving revision 1.115
>diff -u -r1.115 BlockScope.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/BlockScope.java	1 Oct 2008 21:16:38 -0000	1.115
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/BlockScope.java	2 Mar 2010 20:43:43 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -191,14 +191,14 @@
> 			LocalVariableBinding local = this.locals[ilocal]; // if no local at all, will be locals[ilocal]==null
> 
> 			// check if variable is actually used, and may force it to be preserved
>-			boolean generateCurrentLocalVar = (local.useFlag == LocalVariableBinding.USED && local.constant() == Constant.NotAConstant);
>+			boolean generateCurrentLocalVar = (local.useFlag != LocalVariableBinding.UNUSED && local.constant() == Constant.NotAConstant);
> 
> 			// do not report fake used variable
> 			if (local.useFlag == LocalVariableBinding.UNUSED
> 				&& (local.declaration != null) // unused (and non secret) local
> 				&& ((local.declaration.bits & ASTNode.IsLocalDeclarationReachable) != 0)) { // declaration is reachable
> 
>-				if (!(local.declaration instanceof Argument))  // do not report unused catch arguments
>+				if (!(local.declaration instanceof Argument)) // do not report unused catch arguments
> 					problemReporter().unusedLocalVariable(local.declaration);
> 			}
>

Actions: View | Diff

Attachments on bug 304416: 160679 | 160683