Attachment 1597 Details for Bug 19686 – patch for TextViewerHoverManager

[patch] patch for TextViewerHoverManager

19686.patch (text/plain), 2.67 KB, created by Kai-Uwe Maetzel

on 2002-06-26 03:57:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kai-Uwe Maetzel

Created: 2002-06-26 03:57:08 EDT

Size: 2.67 KB

patch

obsolete

>Index: TextViewerHoverManager.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui/Eclipse JFace Text/org/eclipse/jface/text/TextViewerHoverManager.java,v
>retrieving revision 1.8
>diff -u -r1.8 TextViewerHoverManager.java
>--- TextViewerHoverManager.java	10 Jun 2002 09:26:20 -0000	1.8
>+++ TextViewerHoverManager.java	26 Jun 2002 07:50:23 -0000
>@@ -60,53 +60,61 @@
> 		
> 		Point location= getHoverEventLocation();
> 		int offset= computeOffsetAtLocation(location.x, location.y);
>-		if (offset == -1)
>+		if (offset == -1) {
>+			setInformation(null, null);
> 			return;
>+		}
> 			
> 		final ITextHover hover= fTextViewer.getTextHover(offset);
>-		if (hover == null)
>+		if (hover == null) {
>+			setInformation(null, null);
> 			return;
>+		}
> 			
> 		final IRegion region= hover.getHoverRegion(fTextViewer, offset);
>-		if (region == null)
>+		if (region == null) {
>+			setInformation(null, null);
> 			return;
>+		}
> 			
> 		final Rectangle area= computeArea(region);
>-		if (area == null || area.isEmpty())
>+		if (area == null || area.isEmpty()) {
>+			setInformation(null, null);
> 			return;
>+		}
> 		
>-		if (fThread == null) {
>-			
>-			fThread= new Thread() {
>-				public void run() {
>+		if (fThread != null) {
>+			setInformation(null, null);
>+			return;
>+		}
>+		
>+		fThread= new Thread() {
>+			public void run() {
>+				// http://bugs.eclipse.org/bugs/show_bug.cgi?id=17693			
>+				try {
> 					
>-					// http://bugs.eclipse.org/bugs/show_bug.cgi?id=17693
>+					if (fThread != null) {
>+						String information= hover.getHoverInfo(fTextViewer, region);
>+						setInformation(information, area);
>+					} else {
>+						setInformation(null, null);
>+					}
> 					
>-					try {
>-						
>-						if (fThread != null) {
>-							String information= hover.getHoverInfo(fTextViewer, region);
>-							setInformation(information, area);
>-						} else {
>-							setInformation(null, null);
>-						}
>-						
>-					} finally {
>-						synchronized (fMutex) {
>-							if (fTextViewer != null)
>-								fTextViewer.removeTextListener(fStopper);
>-							fThread= null;
>-						}
>+				} finally {
>+					synchronized (fMutex) {
>+						if (fTextViewer != null)
>+							fTextViewer.removeTextListener(fStopper);
>+						fThread= null;
> 					}
> 				}
>-			};
>-			
>-			fThread.setDaemon(true);
>-			fThread.setPriority(Thread.MIN_PRIORITY);
>-			synchronized (fMutex) {
>-				fTextViewer.addTextListener(fStopper);
>-				fThread.start();
> 			}
>+		};
>+		
>+		fThread.setDaemon(true);
>+		fThread.setPriority(Thread.MIN_PRIORITY);
>+		synchronized (fMutex) {
>+			fTextViewer.addTextListener(fStopper);
>+			fThread.start();
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 19686: 1597