Attachment 155967 Details for Bug 245007 – Plausible source + test patch

[patch] Plausible source + test patch

patch.txt (text/plain), 8.91 KB, created by Srikanth Sankaran

on 2010-01-13 06:51:57 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Srikanth Sankaran

Created: 2010-01-13 06:51:57 EST

Size: 8.91 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/ast/QualifiedAllocationExpression.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/QualifiedAllocationExpression.java,v
>retrieving revision 1.97
>diff -u -r1.97 QualifiedAllocationExpression.java
>--- compiler/org/eclipse/jdt/internal/compiler/ast/QualifiedAllocationExpression.java	25 Nov 2009 04:56:02 -0000	1.97
>+++ compiler/org/eclipse/jdt/internal/compiler/ast/QualifiedAllocationExpression.java	13 Jan 2010 11:54:12 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -350,8 +350,6 @@
> 							}
> 						}
> 					}
>-				} else {
>-					return null;
> 				}
> 				if (this.anonymousType != null) {
> 					// insert anonymous type in scope (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=210070)
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/ProblemTypeAndMethodTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/ProblemTypeAndMethodTest.java,v
>retrieving revision 1.25
>diff -u -r1.25 ProblemTypeAndMethodTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/ProblemTypeAndMethodTest.java	9 Jan 2010 06:14:47 -0000	1.25
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/ProblemTypeAndMethodTest.java	13 Jan 2010 11:54:16 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -2919,7 +2919,12 @@
> 			"	    ^^^^\n" +
> 			"Zork cannot be resolved to a type\n" +
> 			"----------\n" +
>-			"11. ERROR in X.java (at line 13)\n" +
>+			"11. ERROR in X.java (at line 8)\n" +
>+			"	new Zork(){}.baz();\n" +
>+			"	             ^^^\n" +
>+			"The method baz() is undefined for the type new Zork(){}\n" +
>+			"----------\n" +
>+			"12. ERROR in X.java (at line 13)\n" +
> 			"	X1(Zork z) {}\n" +
> 			"	   ^^^^\n" +
> 			"Zork cannot be resolved to a type\n" +
>#P org.eclipse.jdt.core.tests.model
>Index: src/org/eclipse/jdt/core/tests/dom/ASTConverterAST3Test.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterAST3Test.java,v
>retrieving revision 1.28
>diff -u -r1.28 ASTConverterAST3Test.java
>--- src/org/eclipse/jdt/core/tests/dom/ASTConverterAST3Test.java	29 Nov 2008 22:35:14 -0000	1.28
>+++ src/org/eclipse/jdt/core/tests/dom/ASTConverterAST3Test.java	13 Jan 2010 11:54:23 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -7409,7 +7409,7 @@
> 		checkSourceRange(name, "j", source); //$NON-NLS-1$
> 		IBinding binding = name.resolveBinding();
> 		ASTNode declaringNode = compilationUnit.findDeclaringNode(binding);
>-		assertNull("No declaring node is available", declaringNode); //$NON-NLS-1$
>+		assertNotNull("No declaring node is available", declaringNode); //$NON-NLS-1$
> 	}
> 
> 	/**
>Index: src/org/eclipse/jdt/core/tests/dom/ASTConverterBugsTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterBugsTest.java,v
>retrieving revision 1.27
>diff -u -r1.27 ASTConverterBugsTest.java
>--- src/org/eclipse/jdt/core/tests/dom/ASTConverterBugsTest.java	27 Aug 2009 15:26:53 -0000	1.27
>+++ src/org/eclipse/jdt/core/tests/dom/ASTConverterBugsTest.java	13 Jan 2010 11:54:24 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -859,7 +859,11 @@
> 			"8. ERROR in /Converter15/src/a/X.java (at line 16)\n" +
> 			"	}takeParam((int) c);\n" +
> 			"	^\n" +
>-			"Syntax error, insert \";\" to complete Statement\n",
>+			"Syntax error, insert \";\" to complete Statement\n" + 
>+			"9. ERROR in /Converter15/src/a/X.java (at line 16)\n" + 
>+			"	}takeParam((int) c);\n" + 
>+			"	 ^^^^^^^^^^\n" + 
>+			"Return type for the method is missing\n",
> 			result);
> }
> /**
>Index: src/org/eclipse/jdt/core/tests/dom/ASTConverterTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterTest.java,v
>retrieving revision 1.86
>diff -u -r1.86 ASTConverterTest.java
>--- src/org/eclipse/jdt/core/tests/dom/ASTConverterTest.java	29 Nov 2008 22:35:14 -0000	1.86
>+++ src/org/eclipse/jdt/core/tests/dom/ASTConverterTest.java	13 Jan 2010 11:54:29 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -7581,7 +7581,7 @@
> 		checkSourceRange(name, "j", source); //$NON-NLS-1$
> 		IBinding binding = name.resolveBinding();
> 		ASTNode declaringNode = compilationUnit.findDeclaringNode(binding);
>-		assertNull("No declaring node is available", declaringNode); //$NON-NLS-1$
>+		assertNotNull("No declaring node is available", declaringNode); //$NON-NLS-1$
> 	}
> 
> 	/**
>Index: src/org/eclipse/jdt/core/tests/dom/ASTConverterTestAST3_2.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterTestAST3_2.java,v
>retrieving revision 1.170
>diff -u -r1.170 ASTConverterTestAST3_2.java
>--- src/org/eclipse/jdt/core/tests/dom/ASTConverterTestAST3_2.java	10 Dec 2009 16:02:33 -0000	1.170
>+++ src/org/eclipse/jdt/core/tests/dom/ASTConverterTestAST3_2.java	13 Jan 2010 11:54:34 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -8021,7 +8021,23 @@
> 				"	CharsetDecoder(CharSet\n" +
> 				"	^^^^^^^^^^^^^^^^^^^^^^\n" +
> 				"Syntax error on token(s), misplaced construct(s)\n" +
>-				"11. ERROR in /Converter/src/TestCharset.java (at line 17)\n" +
>+				"11. ERROR in /Converter/src/TestCharset.java (at line 10)\n" +
>+				"	CharsetDecoder(CharSet\n" +
>+				"	^^^^^^^^^^^^^^^\n" +
>+				"Return type for the method is missing\n" +
>+				"12. ERROR in /Converter/src/TestCharset.java (at line 11)\n" +
>+				"	protected CoderResult decodeLoop(ByteBuffer in,\n" +
>+				"	          ^^^^^^^^^^^\n" +
>+				"CoderResult cannot be resolved to a type\n" +
>+				"13. ERROR in /Converter/src/TestCharset.java (at line 11)\n" +
>+				"	protected CoderResult decodeLoop(ByteBuffer in,\n" +
>+				"	                                 ^^^^^^^^^^\n" +
>+				"ByteBuffer cannot be resolved to a type\n" +
>+				"14. ERROR in /Converter/src/TestCharset.java (at line 12)\n" +
>+				"	CharBuffer out) {\n" +
>+				"	^^^^^^^^^^\n" +
>+				"CharBuffer cannot be resolved to a type\n" +
>+				"15. ERROR in /Converter/src/TestCharset.java (at line 17)\n" +
> 				"	public CharsetEncoder newEncoder() {\n" +
> 				"	       ^^^^^^^^^^^^^^\n" +
> 				"CharsetEncoder cannot be resolved to a type\n",

Actions: View | Diff

Attachments on bug 245007: 110722 | 155967 | 156371