Attachment 154536 Details for Bug 235781 – Proposed patch

[patch] Proposed patch

patch.txt (text/plain), 3.82 KB, created by Srikanth Sankaran

on 2009-12-15 23:16:46 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Srikanth Sankaran

Created: 2009-12-15 23:16:46 EST

Size: 3.82 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/ast/ConstructorDeclaration.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/ConstructorDeclaration.java,v
>retrieving revision 1.105
>diff -u -r1.105 ConstructorDeclaration.java
>--- compiler/org/eclipse/jdt/internal/compiler/ast/ConstructorDeclaration.java	1 Apr 2009 05:36:30 -0000	1.105
>+++ compiler/org/eclipse/jdt/internal/compiler/ast/ConstructorDeclaration.java	16 Dec 2009 04:19:21 -0000
>@@ -161,7 +161,9 @@
> 		}
> 
> 		// reuse the initial reach mode for diagnosing missing blank finals
>-		flowInfo.setReachMode(initialReachMode);
>+		// no, we should use the updated reach mode for diagnosing uninitialized blank finals.
>+		// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=235781
>+		// flowInfo.setReachMode(initialReachMode);
> 
> 		// check missing blank final field initializations
> 		if ((this.constructorCall != null)
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/AbstractRegressionTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AbstractRegressionTest.java,v
>retrieving revision 1.121
>diff -u -r1.121 AbstractRegressionTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/AbstractRegressionTest.java	17 Aug 2009 19:02:23 -0000	1.121
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/AbstractRegressionTest.java	16 Dec 2009 04:19:25 -0000
>@@ -336,8 +336,6 @@
> 				new EclipseHasABug(MismatchType.JavacErrorsEclipseNone) : null,
> 			EclipseBug235550 = RUN_JAVAC ? // https://bugs.eclipse.org/bugs/show_bug.cgi?id=235550
> 				new EclipseHasABug(MismatchType.JavacErrorsEclipseNone) : null,
>-			EclipseBug235781 = RUN_JAVAC ? // https://bugs.eclipse.org/bugs/show_bug.cgi?id=235781
>-				new EclipseHasABug(MismatchType.EclipseErrorsJavacNone) : null,
> 			EclipseBug235809 = RUN_JAVAC ? // https://bugs.eclipse.org/bugs/show_bug.cgi?id=235809
> 				new EclipseHasABug(MismatchType.StandardOutputMismatch) : null,
> 			EclipseBug236217 = RUN_JAVAC ? // https://bugs.eclipse.org/bugs/show_bug.cgi?id=236217
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/FlowAnalysisTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/FlowAnalysisTest.java,v
>retrieving revision 1.39
>diff -u -r1.39 FlowAnalysisTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/FlowAnalysisTest.java	28 Apr 2009 17:17:32 -0000	1.39
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/FlowAnalysisTest.java	16 Dec 2009 04:19:26 -0000
>@@ -997,7 +997,7 @@
> }
> //https://bugs.eclipse.org/bugs/show_bug.cgi?id=155423 - variation
> public void test031() {
>-	this.runNegativeTest(
>+	this.runConformTest(
> 		new String[] {
> 			"X.java",
> 			"class Y {\n" +
>@@ -1017,13 +1017,7 @@
> 			"	}\n" +
> 			"}\n", // =================
> 		},
>-		"----------\n" +
>-		"1. ERROR in X.java (at line 13)\n" +
>-		"	X() {\n" +
>-		"	^^^\n" +
>-		"The blank final field blank may not have been initialized\n" +
>-		"----------\n",
>-		JavacTestOptions.EclipseHasABug.EclipseBug235781);
>+		"");
> }
> //https://bugs.eclipse.org/bugs/show_bug.cgi?id=155423 - variation
> public void test032() {
>@@ -1521,7 +1515,7 @@
> 		true /* skipJavac */);
> }
> // https://bugs.eclipse.org/bugs/show_bug.cgi?id=235781
>-public void _test050_definite_assigment_and_if_true() {
>+public void test050_definite_assigment_and_if_true() {
> 	runConformTest(
> 		// test directory preparation
> 		new String[] { /* test files */

Actions: View | Diff

Attachments on bug 235781: 154536