Attachment 154131 Details for Bug 181682 – Proposed fix

[patch] Proposed fix

patch_181682.txt (text/plain), 1.98 KB, created by Olivier Thomann

on 2009-12-09 12:08:15 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2009-12-09 12:08:15 EST

Size: 1.98 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/core/JavaConventions.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/core/JavaConventions.java,v
>retrieving revision 1.122
>diff -u -r1.122 JavaConventions.java
>--- model/org/eclipse/jdt/core/JavaConventions.java	15 Dec 2008 12:30:17 -0000	1.122
>+++ model/org/eclipse/jdt/core/JavaConventions.java	9 Dec 2009 17:11:30 -0000
>@@ -377,13 +377,18 @@
> 	 * @deprecated Use {@link #validateJavaTypeName(String id, String sourceLevel, String complianceLevel)} instead
> 	 */
> 	public static IStatus validateJavaTypeName(String name) {
>-		return validateJavaTypeName(name, CompilerOptions.VERSION_1_3,CompilerOptions.VERSION_1_3);
>+		return validateJavaTypeName(name, JavaCore.VERSION_1_3, JavaCore.VERSION_1_3);
> 	}
> 
> 	/**
> 	 * Validate the given Java type name, either simple or qualified, for the given source and compliance levels.
>-	 * For example, <code>"java.lang.Object"</code>, or <code>"Object"</code>.
>-	 * 
>+	 * 
>+	 * For example, <code>"java.lang.Object"</code>, or <code>"Object"</code>.
>+	 * 
>+	 * The source level and compliance level values should be taken from the constant defined inside
>+	 * {@link JavaCore} class. The constants are named <code>JavaCore#VERSION_1_x</code>, x being set
>+	 * between '1' and '7'.
>+	 * 
> 	 *
> 	 * @param name the name of a type
> 	 * @param sourceLevel the source level
>@@ -395,6 +400,13 @@
> 	 * otherwise a status object indicating what is wrong with
> 	 * the name
> 	 * @since 3.3
>+	 * @see JavaCore#VERSION_1_1
>+	 * @see JavaCore#VERSION_1_2
>+	 * @see JavaCore#VERSION_1_3
>+	 * @see JavaCore#VERSION_1_4
>+	 * @see JavaCore#VERSION_1_5
>+	 * @see JavaCore#VERSION_1_6
>+	 * @see JavaCore#VERSION_1_7
> 	 */
> 	public static IStatus validateJavaTypeName(String name, String sourceLevel, String complianceLevel) {
> 		if (name == null) {

Actions: View | Diff

Attachments on bug 181682: 154131