Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 151012 Details for
Bug 293861
Problem with refactoring when existing jar with invalid package names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
[patch]
patch
org.eclipse.jdt.ui.patch (text/plain), 3.22 KB, created by
Snjezana Peco
on 2009-10-31 19:07:36 EDT
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Snjezana Peco
Created:
2009-10-31 19:07:36 EDT
Size:
3.22 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.jdt.ui >Index: core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RippleMethodFinder2.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RippleMethodFinder2.java,v >retrieving revision 1.18 >diff -u -r1.18 RippleMethodFinder2.java >--- core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RippleMethodFinder2.java 5 Nov 2008 18:44:38 -0000 1.18 >+++ core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RippleMethodFinder2.java 31 Oct 2009 22:22:06 -0000 >@@ -239,8 +239,11 @@ > IMethod alienDeclaration= (IMethod) iter.next(); > IType alienType= alienDeclaration.getDeclaringType(); > alienTypes.add(alienType); >- if (alienType.isInterface()) >- hasAlienInterfaces= true; >+ try { >+ if (alienType.isInterface()) >+ hasAlienInterfaces= true; >+ } catch (Exception ignore) { >+ } > } > if (alienTypes.size() == 0) //no nasty marriage scenarios without types to marry with... > return (IMethod[]) relatedMethods.toArray(new IMethod[relatedMethods.size()]); >@@ -272,9 +275,12 @@ > IType alienType= (IType) iter.next(); > IMethod alienMethod= (IMethod) fTypeToMethod.get(alienType); > ITypeHierarchy hierarchy= getCachedHierarchy(alienType, owner, new SubProgressMonitor(pm, 1)); >- if (hierarchy == null) >- hierarchy= alienType.newTypeHierarchy(owner, new SubProgressMonitor(pm, 1)); >- IType[] allSubtypes= hierarchy.getAllSubtypes(alienType); >+ try { >+ if (hierarchy == null) >+ hierarchy= alienType.newTypeHierarchy(owner, new SubProgressMonitor(pm, 1)); >+ } catch (Exception ignore) { >+ } >+ IType[] allSubtypes= hierarchy == null ? new IType[0] : hierarchy.getAllSubtypes(alienType); > for (int i= 0; i < allSubtypes.length; i++) { > IType subtype= allSubtypes[i]; > if (relatedSubTypes.contains(subtype)) { >@@ -318,10 +324,13 @@ > IType root= (IType) iter.next(); > ITypeHierarchy hierarchy= (ITypeHierarchy) fRootHierarchies.get(root); > if (hierarchy == null) { >- hierarchy= root.newTypeHierarchy(owner, new SubProgressMonitor(monitor, 1)); >- fRootHierarchies.put(root, hierarchy); >+ try { >+ hierarchy= root.newTypeHierarchy(owner, new SubProgressMonitor(monitor, 1)); >+ fRootHierarchies.put(root, hierarchy); >+ } catch (Exception ignore) { >+ } > } >- if (hierarchy.contains(type)) >+ if (hierarchy != null && hierarchy.contains(type)) > return hierarchy; > } > } >@@ -404,7 +413,12 @@ > } else { > //check whether method in supertype is really overridden: > IMember superMethod= (IMember) fTypeToMethod.get(supertype); >- if (JavaModelUtil.isVisibleInHierarchy(superMethod, anchor.getPackageFragment())) { >+ boolean isVisibleInHierarchy = false; >+ try { >+ isVisibleInHierarchy = JavaModelUtil.isVisibleInHierarchy(superMethod, anchor.getPackageFragment()); >+ } catch (Exception ignore) { >+ } >+ if (isVisibleInHierarchy) { > IType rep= fUnionFind.find(anchor); > fUnionFind.union(rep, superRep); > // current type is no root anymore
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
markus.kell.r
:
review-
Actions:
View
|
Diff
Attachments on
bug 293861
:
151012
|
151013
|
151410
|
152146
|
153222
|
153223
|
154621
|
154622
|
154957
|
155298
|
155299
|
155300
|
158473
|
158478
|
159164
|
180736
|
180737
|
180738
|
180739