Attachment 145956 Details for Bug 282391 – support for enabling/disabling binary cycles from GUI

[patch] support for enabling/disabling binary cycles from GUI

org.eclipse.ajdt.ui_binary_cycel_gui.patch (text/plain), 2.98 KB, created by Ivica Loncar

on 2009-08-28 12:17:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivica Loncar

Created: 2009-08-28 12:17:10 EDT

Size: 2.98 KB

patch

obsolete

>Index: src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizardPage.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.ajdt/AJDT_src/org.eclipse.ajdt.ui/src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizardPage.java,v
>retrieving revision 1.3
>diff -u -r1.3 AJPluginExportWizardPage.java
>--- src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizardPage.java	8 Jun 2006 11:02:15 -0000	1.3
>+++ src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizardPage.java	28 Aug 2009 16:16:12 -0000
>@@ -46,4 +46,8 @@
> 	protected String[] getSigningInfo() {
> 		return super.getSigningInfo();
> 	}
>+	
>+	protected boolean allowBinaryCycles() {
>+		return super.allowBinaryCycles();
>+	}
> }
>Index: src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizard.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.ajdt/AJDT_src/org.eclipse.ajdt.ui/src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizard.java,v
>retrieving revision 1.9
>diff -u -r1.9 AJPluginExportWizard.java
>--- src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizard.java	8 Jun 2006 11:02:15 -0000	1.9
>+++ src/org/eclipse/ajdt/internal/ui/wizards/exports/AJPluginExportWizard.java	28 Aug 2009 16:16:12 -0000
>@@ -54,6 +54,8 @@
> 		info.zipFileName = ((AJPluginExportWizardPage)fPage).getFileName();
> 		info.items = ((AJPluginExportWizardPage)fPage).getSelectedItems();
> 		info.signingInfo = ((AJPluginExportWizardPage)fPage).useJARFormat() ? ((AJPluginExportWizardPage)fPage).getSigningInfo() : null;
>+		info.allowBinaryCycles = ((AJPluginExportWizardPage)fPage).allowBinaryCycles(); 
>+		
> 		
> 		AJPluginExportJob job = new AJPluginExportJob(info);
> 		job.setUser(true);
>Index: pde-src/org/eclipse/ajdt/internal/core/exports/FeatureExportOperation.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.ajdt/AJDT_src/org.eclipse.ajdt.ui/pde-src/org/eclipse/ajdt/internal/core/exports/FeatureExportOperation.java,v
>retrieving revision 1.4.6.4
>diff -u -r1.4.6.4 FeatureExportOperation.java
>--- pde-src/org/eclipse/ajdt/internal/core/exports/FeatureExportOperation.java	10 Jul 2009 17:09:31 -0000	1.4.6.4
>+++ pde-src/org/eclipse/ajdt/internal/core/exports/FeatureExportOperation.java	28 Aug 2009 16:16:11 -0000
>@@ -580,7 +580,7 @@
>         // Bug 268667: allow binary cycles
>         // XXX consider adding this to the UI.
> 		Properties properties = new Properties();
>-		properties.put(IBuildPropertiesConstants.PROPERTY_ALLOW_BINARY_CYCLES, Boolean.toString(true));
>+		properties.put(IBuildPropertiesConstants.PROPERTY_ALLOW_BINARY_CYCLES, Boolean.toString(fInfo.allowBinaryCycles));
>         properties.put(IBuildPropertiesConstants.PROPERTY_P2_GATHERING, Boolean.toString(fInfo.useJarFormat && fInfo.exportMetadata));
> 		generator.setImmutableAntProperties(properties);
>         // AspectJ change end

Flags:

andrew.eisenberg: iplog+

Actions: View | Diff

Attachments on bug 282391: 145956