Attachment 12399 Details for Bug 37648 – fix for java compare

[patch] fix for java compare

37648b.txt (text/plain), 1.52 KB, created by Andre Weinand

on 2004-06-17 11:58:50 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andre Weinand

Created: 2004-06-17 11:58:50 EDT

Size: 1.52 KB

patch

obsolete

>Index: ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java,v
>retrieving revision 1.37
>diff -u -r1.37 JavaStructureCreator.java
>--- ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java	24 May 2004 15:56:22 -0000	1.37
>+++ ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java	17 Jun 2004 15:05:38 -0000
>@@ -142,7 +142,7 @@
> 				try {
> 					contents= JavaCompareUtilities.readString(sca);
> 				} catch (CoreException ex) {
>-					JavaPlugin.log(ex);
>+					// return null indicates the error.
> 					return null;
> 				}			
> 			}
>Index: ui/org/eclipse/jdt/internal/ui/compare/PropertiesStructureCreator.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/PropertiesStructureCreator.java,v
>retrieving revision 1.16
>diff -u -r1.16 PropertiesStructureCreator.java
>--- ui/org/eclipse/jdt/internal/ui/compare/PropertiesStructureCreator.java	16 Jun 2004 14:15:10 -0000	1.16
>+++ ui/org/eclipse/jdt/internal/ui/compare/PropertiesStructureCreator.java	17 Jun 2004 15:05:38 -0000
>@@ -118,7 +118,8 @@
> 			try {
> 				content= JavaCompareUtilities.readString(((IStreamContentAccessor) input));
> 			} catch(CoreException ex) {
>-				JavaPlugin.log(ex);
>+				// returning null indicates error
>+				return null;
> 			}
> 		}
>

Actions: View | Diff

Attachments on bug 37648: 12398 | 12399