Attachment 120409 Details for Bug 258752 – Remove ExtendedDirectedGraphLayout

[patch] Remove ExtendedDirectedGraphLayout

removeExtendedDirectedGraphLayout.txt (text/plain), 2.29 KB, created by Richard Miskin

on 2008-12-14 08:49:18 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Richard Miskin

Created: 2008-12-14 08:49:18 EST

Size: 2.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.zest.layouts
>Index: src/org/eclipse/zest/layouts/algorithms/DirectedGraphLayoutAlgorithm.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/plugins/org.eclipse.zest.layouts/src/org/eclipse/zest/layouts/algorithms/DirectedGraphLayoutAlgorithm.java,v
>retrieving revision 1.4
>diff -u -r1.4 DirectedGraphLayoutAlgorithm.java
>--- src/org/eclipse/zest/layouts/algorithms/DirectedGraphLayoutAlgorithm.java	12 Sep 2007 20:44:37 -0000	1.4
>+++ src/org/eclipse/zest/layouts/algorithms/DirectedGraphLayoutAlgorithm.java	14 Dec 2008 13:46:24 -0000
>@@ -10,10 +10,8 @@
>  *******************************************************************************/
> package org.eclipse.zest.layouts.algorithms;
> 
>-import java.lang.reflect.Field;
> import java.util.HashMap;
> import java.util.Iterator;
>-import java.util.List;
> 
> import org.eclipse.draw2d.geometry.Dimension;
> import org.eclipse.draw2d.graph.DirectedGraph;
>@@ -25,34 +23,6 @@
> 
> public class DirectedGraphLayoutAlgorithm extends AbstractLayoutAlgorithm {
> 
>-	class ExtendedDirectedGraphLayout extends DirectedGraphLayout {
>-
>-		public void visit(DirectedGraph graph) {
>-			Field field;
>-			try {
>-				field = DirectedGraphLayout.class.getDeclaredField("steps");
>-				field.setAccessible(true);
>-				Object object = field.get(this);
>-				List steps = (List) object;
>-				steps.remove(10);
>-				steps.remove(9);
>-				steps.remove(8);
>-				steps.remove(2);
>-				field.setAccessible(false);
>-				super.visit(graph);
>-			} catch (SecurityException e) {
>-				e.printStackTrace();
>-			} catch (NoSuchFieldException e) {
>-				e.printStackTrace();
>-			} catch (IllegalArgumentException e) {
>-				e.printStackTrace();
>-			} catch (IllegalAccessException e) {
>-				e.printStackTrace();
>-			}
>-		}
>-
>-	}
>-
> 	public DirectedGraphLayoutAlgorithm(int styles) {
> 		super(styles);
> 	}
>@@ -74,7 +44,7 @@
> 			Edge edge = new Edge(relationship, source, dest);
> 			graph.edges.add(edge);
> 		}
>-		DirectedGraphLayout directedGraphLayout = new ExtendedDirectedGraphLayout();
>+		DirectedGraphLayout directedGraphLayout = new DirectedGraphLayout();
> 		directedGraphLayout.visit(graph);
> 
> 		for (Iterator iterator = graph.nodes.iterator(); iterator.hasNext();) {

Actions: View | Diff

Attachments on bug 258752: 120409