Attachment 119031 Details for Bug 256329 – Proposed fix

[patch] Proposed fix

256329.txt (text/plain), 1.05 KB, created by Jerome Lanneluc

on 2008-11-28 12:29:46 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Jerome Lanneluc

Created: 2008-11-28 12:29:46 EST

Size: 1.05 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/JavaModelManager.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/JavaModelManager.java,v
>retrieving revision 1.420
>diff -u -r1.420 JavaModelManager.java
>--- model/org/eclipse/jdt/internal/core/JavaModelManager.java	28 Nov 2008 16:19:36 -0000	1.420
>+++ model/org/eclipse/jdt/internal/core/JavaModelManager.java	28 Nov 2008 17:29:20 -0000
>@@ -1895,7 +1895,8 @@
> 	public Hashtable getOptions() {
> 
> 		// return cached options if already computed
>-		if (this.optionsCache != null) return new Hashtable(this.optionsCache);
>+		Hashtable cachedOptions; // use a local variable to avoid race condition (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=256329 )
>+		if ((cachedOptions = this.optionsCache) != null) return new Hashtable(cachedOptions);
> 
> 		if (!Platform.isRunning()) {
> 			return this.optionsCache = getDefaultOptionsNoInitialization();

Actions: View | Diff

Attachments on bug 256329: 119031