Attachment 118892 Details for Bug 256735 – Better patch

[patch] Better patch

256735.txt (text/plain), 2.00 KB, created by Philipe Mulet

on 2008-11-27 05:54:30 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Philipe Mulet

Created: 2008-11-27 05:54:30 EST

Size: 2.00 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java,v
>retrieving revision 1.123
>diff -u -r1.123 AbstractImageBuilder.java
>--- model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java	17 Sep 2008 11:58:32 -0000	1.123
>+++ model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java	27 Nov 2008 10:54:07 -0000
>@@ -711,7 +711,11 @@
> 			Object[] allValues = new Object[allNames.length];
> 			// standard attributes
> 			int index = 0;
>-			allValues[index++] = problem.getMessage(); // message
>+			String message = problem.getMessage();
>+			if (message.length() > 2000) { // truncate the message if too long - markers cannot store more than 64kbytes property value
>+				message = message.substring(0, 2000) + "..."; //$NON-NLS-1$
>+			}
>+			allValues[index++] = message; // message
> 			allValues[index++] = problem.isError() ? S_ERROR : S_WARNING; // severity
> 			allValues[index++] = new Integer(id); // ID
> 			allValues[index++] = new Integer(problem.getSourceStart()); // start
>@@ -759,11 +763,14 @@
> 				System.arraycopy(attributeNames, 0, allNames, 0, standardLength);
> 				System.arraycopy(extraAttributeNames, 0, allNames, standardLength, extraLength);
> 			}
>-
>+			String message = task.getMessage();
>+			if (message.length() > 2000) { // truncate the message if too long - markers cannot store more than 64kbytes property value
>+				message = message.substring(0, 2000) + "..."; //$NON-NLS-1$
>+			}
> 			Object[] allValues = new Object[allNames.length];
> 			// standard attributes
> 			int index = 0;
>-			allValues[index++] = task.getMessage();
>+			allValues[index++] = message;
> 			allValues[index++] = priority;
> 			allValues[index++] = new Integer(task.getID());
> 			allValues[index++] = new Integer(task.getSourceStart());

Actions: View | Diff

Attachments on bug 256735: 118874 | 118892 | 118926