Attachment 114598 Details for Bug 249134 – Proposed patch

[patch] Proposed patch

patch.txt (text/plain), 1.41 KB, created by Kent Johnson

on 2008-10-08 16:23:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kent Johnson

Created: 2008-10-08 16:23:36 EDT

Size: 1.41 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/MethodScope.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodScope.java,v
>retrieving revision 1.68
>diff -u -r1.68 MethodScope.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/MethodScope.java	27 Jun 2008 16:04:02 -0000	1.68
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/MethodScope.java	8 Oct 2008 20:22:19 -0000
>@@ -198,8 +198,10 @@
> 		int incompatibleWithAbstract = ClassFileConstants.AccPrivate | ClassFileConstants.AccStatic | ClassFileConstants.AccFinal | ClassFileConstants.AccSynchronized | ClassFileConstants.AccNative | ClassFileConstants.AccStrictfp;
> 		if ((modifiers & incompatibleWithAbstract) != 0)
> 			problemReporter().illegalAbstractModifierCombinationForMethod(declaringClass, (AbstractMethodDeclaration) this.referenceContext);
>-		if (!methodBinding.declaringClass.isAbstract())
>+		if (!methodBinding.declaringClass.isAbstract()) {
>+			modifiers &= ~ClassFileConstants.AccAbstract;
> 			problemReporter().abstractMethodInAbstractClass((SourceTypeBinding) declaringClass, (AbstractMethodDeclaration) this.referenceContext);
>+		}
> 	}
> 
> 	/* DISABLED for backward compatibility with javac (if enabled should also mark private methods as final)

Actions: View | Diff

Attachments on bug 249134: 113880 | 113997 | 114598 | 117235 | 117239 | 118174 | 118376 | 118514