Attachment 113997 Details for Bug 249134 – better patch

[patch] better patch

bug249134-2.diff (text/plain), 1.48 KB, created by Stephan Herrmann

on 2008-10-01 10:28:53 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Herrmann

Created: 2008-10-01 10:28:53 EDT

Size: 1.48 KB

patch

obsolete

>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier.java,v
>retrieving revision 1.97
>diff -u -r1.97 MethodVerifier.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier.java	26 Aug 2008 11:52:54 -0000	1.97
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier.java	1 Oct 2008 14:22:15 -0000
>@@ -338,14 +338,14 @@
> 	}
> 	if (concreteMethod == null) {
> 		if (!this.type.isAbstract()) {
>-			for (int i = length; --i >= 0;) {
>+			for (int i = 0; i < length; i++) {
> 				if (mustImplementAbstractMethod(methods[i].declaringClass)) {
> 					TypeDeclaration typeDeclaration = this.type.scope.referenceContext;
> 					if (typeDeclaration != null) {
>-						MethodDeclaration missingAbstractMethod = typeDeclaration.addMissingAbstractMethodFor(methods[0]);
>-						missingAbstractMethod.scope.problemReporter().abstractMethodMustBeImplemented(this.type, methods[0]);
>+						MethodDeclaration missingAbstractMethod = typeDeclaration.addMissingAbstractMethodFor(methods[i]);
>+						missingAbstractMethod.scope.problemReporter().abstractMethodMustBeImplemented(this.type, methods[i]);
> 					} else {
>-						problemReporter().abstractMethodMustBeImplemented(this.type, methods[0]);
>+						problemReporter().abstractMethodMustBeImplemented(this.type, methods[i]);
> 					}
> 					return;
> 				}

Actions: View | Diff

Attachments on bug 249134: 113880 | 113997 | 114598 | 117235 | 117239 | 118174 | 118376 | 118514