Attachment 113299 Details for Bug 247544 – patch limiting the number of selected items on restore to 100

[patch] patch limiting the number of selected items on restore to 100

patch.txt (text/plain), 1.57 KB, created by David McKnight

on 2008-09-23 16:34:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David McKnight

Created: 2008-09-23 16:34:43 EDT

Size: 1.57 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java,v
>retrieving revision 1.39
>diff -u -r1.39 SystemViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	22 Aug 2008 13:00:36 -0000	1.39
>+++ UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	23 Sep 2008 20:33:16 -0000
>@@ -33,6 +33,7 @@
>  * David Dykstal (IBM) - [216858] Need the ability to Import/Export RSE connections for sharing
>  * Kevin Doyle 	 (IBM) - [186769] Enable Contributions to Drop Down menu of Remote Systems view -> Preferences
>  * David McKnight (IBM)  - [244807] System view does not handle restore from cache
>+ * David McKnight (IBM)  - [247544] [performance] Restoring Selection on Restart can cause the UI to freeze
>  *******************************************************************************/
> 
> package org.eclipse.rse.internal.ui.view;
>@@ -1522,8 +1523,10 @@
> 
> 		protected IStatus doSelect(IProgressMonitor monitor)
> 		{
>+			// for defect 247544, we should only select first item on restart if the selection size is huge
> 			Vector v = new Vector();
>-			for (int i = 0; i < _remoteObjectsToSelect.size(); i++){
>+			int MAX_SELECT = 100;			
>+			for (int i = 0; i < _remoteObjectsToSelect.size() && i < MAX_SELECT; i++){
> 
> 				Object object = _remoteObjectsToSelect.get(i);
> 				if (object instanceof RemoteObject)

Actions: View | Diff

Attachments on bug 247544: 113299 | 113457