Attachment 112086 Details for Bug 244164 – Proposed fix + regression tests

[patch] Proposed fix + regression tests

patch_244164_2.txt (text/plain), 3.53 KB, created by Olivier Thomann

on 2008-09-09 11:38:11 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2008-09-09 11:38:11 EDT

Size: 3.53 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java,v
>retrieving revision 1.754
>diff -u -r1.754 GenericTypeTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java	3 Sep 2008 09:02:11 -0000	1.754
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java	9 Sep 2008 15:17:30 -0000
>@@ -31,7 +31,7 @@
> 	// All specified tests which does not belong to the class are skipped...
> 	static {
> //		TESTS_NAMES = new String[] { "test0788" };
>-//		TESTS_NUMBERS = new int[] { 1369 };
>+//		TESTS_NUMBERS = new int[] { 1368, 1369 };
> //		TESTS_RANGE = new int[] { 1097, -1 };
> 	}
> 	public static Test suite() {
>@@ -45943,7 +45943,7 @@
> 			"----------\n");
> }
> //https://bugs.eclipse.org/bugs/show_bug.cgi?id=244164
>-public void _test1368() {
>+public void test1368() {
> 	this.runNegativeTest(
> 			new String[] {
> 				"X.java", //-----------------------------------------------------------------------
>@@ -45968,6 +45968,35 @@
> 			"Map<String,Zork> cannot be resolved to a type\n" + 
> 			"----------\n");
> }
>+//https://bugs.eclipse.org/bugs/show_bug.cgi?id=244164
>+public void test1369() {
>+	this.runNegativeTest(
>+			new String[] {
>+				"X.java", //-----------------------------------------------------------------------
>+				"class X {\n" + 
>+				"	A<E> a; // E is undefined on purpose\n" + 
>+				"	X() { a = new A<E>(); } // causes Missing code implementation\n" + 
>+				"}",
>+				"A.java",
>+				"class A<E> {}",//-----------------------------------------------------------------------
>+			},
>+			"----------\n" + 
>+			"1. ERROR in X.java (at line 2)\n" + 
>+			"	A<E> a; // E is undefined on purpose\n" + 
>+			"	  ^\n" + 
>+			"E cannot be resolved to a type\n" + 
>+			"----------\n" + 
>+			"2. ERROR in X.java (at line 3)\n" + 
>+			"	X() { a = new A<E>(); } // causes Missing code implementation\n" + 
>+			"	      ^\n" + 
>+			"A<E> cannot be resolved to a type\n" + 
>+			"----------\n" + 
>+			"3. ERROR in X.java (at line 3)\n" + 
>+			"	X() { a = new A<E>(); } // causes Missing code implementation\n" + 
>+			"	                ^\n" + 
>+			"E cannot be resolved to a type\n" + 
>+			"----------\n");
>+}
> //https://bugs.eclipse.org/bugs/show_bug.cgi?id=242448
> public void test1370() {
> 	this.runConformTest(
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java,v
>retrieving revision 1.376
>diff -u -r1.376 ProblemReporter.java
>--- compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java	5 Sep 2008 10:24:43 -0000	1.376
>+++ compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java	9 Sep 2008 15:17:31 -0000
>@@ -3479,8 +3479,15 @@
> 		}
> 	}
> 
>+	int problemId = type.problemId();
>+	if (type.isParameterizedType()) {
>+		List missingTypes = type.collectMissingTypes(null);
>+		if (!missingTypes.isEmpty()) {
>+			problemId = ProblemReasons.NotFound;
>+		}
>+	}
> 	int id = IProblem.UndefinedType; // default
>-	switch (type.problemId()) {
>+	switch (problemId) {
> 		case ProblemReasons.NotFound :
> 			id = IProblem.UndefinedType;
> 			break;

Actions: View | Diff

Attachments on bug 244164: 110000 | 112086 | 112103 | 125135