Attachment 103800 Details for Bug 232391 – better patch using best practice as suggested.

[patch] better patch using best practice as suggested.

nlsINUpdateBetterFormat.txt (text/plain), 2.25 KB, created by Bradley Childs

on 2008-06-05 14:47:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Bradley Childs

Created: 2008-06-05 14:47:51 EDT

Size: 2.25 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.jsdt.core
>Index: src/org/eclipse/wst/jsdt/core/LibrarySuperType.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/core/LibrarySuperType.java,v
>retrieving revision 1.9
>diff -u -r1.9 LibrarySuperType.java
>--- src/org/eclipse/wst/jsdt/core/LibrarySuperType.java	5 Jun 2008 18:26:44 -0000	1.9
>+++ src/org/eclipse/wst/jsdt/core/LibrarySuperType.java	5 Jun 2008 18:46:27 -0000
>@@ -139,8 +139,8 @@
> 			return getLibraryName();
> 
> 		}
>-
>-		return superTypeName + "() in " + getLibraryName(); //$NON-NLS-1$
>+		
>+		return  Messages.getString("LibrarySuperType.0", new Object[]{superTypeName, getLibraryName()}); //$NON-NLS-1$
> 	}
> 
> 	public boolean equals(Object o) {
>Index: src/org/eclipse/wst/jsdt/core/Messages.java
>===================================================================
>RCS file: src/org/eclipse/wst/jsdt/core/Messages.java
>diff -N src/org/eclipse/wst/jsdt/core/Messages.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ src/org/eclipse/wst/jsdt/core/Messages.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,24 @@
>+package org.eclipse.wst.jsdt.core;
>+
>+import java.util.MissingResourceException;
>+import java.util.ResourceBundle;
>+
>+import com.ibm.icu.text.MessageFormat;
>+
>+public class Messages {
>+	private static final String BUNDLE_NAME = "org.eclipse.wst.jsdt.core.messages"; //$NON-NLS-1$
>+
>+	private static final ResourceBundle RESOURCE_BUNDLE = ResourceBundle
>+			.getBundle(BUNDLE_NAME);
>+
>+	private Messages() {
>+	}
>+
>+	public static String getString(String key, Object[] objects) {
>+		try {
>+			return  MessageFormat.format( RESOURCE_BUNDLE.getString(key),  objects);
>+		} catch (MissingResourceException e) {
>+			return '!' + key + '!';
>+		}
>+	}
>+}
>Index: src/org/eclipse/wst/jsdt/core/messages.properties
>===================================================================
>RCS file: src/org/eclipse/wst/jsdt/core/messages.properties
>diff -N src/org/eclipse/wst/jsdt/core/messages.properties
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ src/org/eclipse/wst/jsdt/core/messages.properties	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,1 @@
>+LibrarySuperType.0={0}() in {1}

Flags:

kaloyan: review+

Actions: View | Diff

Attachments on bug 232391: 100528 | 102670 | 103800