Attachment 100171 Details for Bug 231796 – Proposed patch

[patch] Proposed patch

v00.txt (text/plain), 6.27 KB, created by Frederic Fusier

on 2008-05-14 09:44:19 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Fusier

Created: 2008-05-14 09:44:19 EDT

Size: 6.27 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.model
>Index: workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_descr/X30.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_descr/X30.java,v
>retrieving revision 1.2
>diff -u -r1.2 X30.java
>--- workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_descr/X30.java	13 May 2008 17:06:13 -0000	1.2
>+++ workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_descr/X30.java	14 May 2008 11:55:45 -0000
>@@ -10,7 +10,8 @@
> 	 *        the resource to check for errors
> 	 * @return <code>true</code> if the resource (and its children) are error
> 	 *         free
>-	 * @throws import org.eclipse.core.runtime.CoreException if there's a marker
>+	 * @throws import
>+	 *         org.eclipse.core.runtime.CoreException if there's a marker
> 	 *         problem
> 	 */
> 	void foo() {
>Index: workspace/FormatterJavadoc/test/wksp/eclipse/out/default/X30.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/workspace/FormatterJavadoc/test/wksp/eclipse/out/default/X30.java,v
>retrieving revision 1.2
>diff -u -r1.2 X30.java
>--- workspace/FormatterJavadoc/test/wksp/eclipse/out/default/X30.java	13 May 2008 17:06:12 -0000	1.2
>+++ workspace/FormatterJavadoc/test/wksp/eclipse/out/default/X30.java	14 May 2008 11:55:45 -0000
>@@ -10,8 +10,9 @@
> 	 *            the resource to check for errors
> 	 * @return <code>true</code> if the resource (and its children) are error
> 	 *         free
>-	 * @throws import org.eclipse.core.runtime.CoreException if there's a marker
>-	 *         problem
>+	 * @throws import
>+	 *             org.eclipse.core.runtime.CoreException if there's a marker
>+	 *             problem
> 	 */
> 	void foo() {
> 	}
>Index: workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_tags/X30.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_tags/X30.java,v
>retrieving revision 1.1
>diff -u -r1.1 X30.java
>--- workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_tags/X30.java	6 May 2008 08:47:48 -0000	1.1
>+++ workspace/FormatterJavadoc/test/wksp/eclipse/out/dont_indent_tags/X30.java	14 May 2008 11:55:45 -0000
>@@ -10,8 +10,8 @@
> 	 * the resource to check for errors
> 	 * @return <code>true</code> if the resource (and its children) are error
> 	 * free
>-	 * @throws import org.eclipse.core.runtime.CoreException if there's a marker
>-	 * problem
>+	 * @throws import
>+	 * org.eclipse.core.runtime.CoreException if there's a marker problem
> 	 */
> 	void foo() {
> 	}
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java,v
>retrieving revision 1.74
>diff -u -r1.74 AbstractCommentParser.java
>--- compiler/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java	8 May 2008 19:01:53 -0000	1.74
>+++ compiler/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java	14 May 2008 11:55:47 -0000
>@@ -1022,22 +1022,61 @@
> 					consumeToken();
> 					break;
> 
>-				case TerminalTokens.TokenNamevoid :
>-				case TerminalTokens.TokenNameboolean :
>-				case TerminalTokens.TokenNamebyte :
>-				case TerminalTokens.TokenNamechar :
>-				case TerminalTokens.TokenNamedouble :
>-				case TerminalTokens.TokenNamefloat :
>-				case TerminalTokens.TokenNameint :
>-				case TerminalTokens.TokenNamelong :
>-				case TerminalTokens.TokenNameshort :
>-					if (iToken > 0) {
>-						throw new InvalidInputException();
>+				case TerminalTokens.TokenNameabstract:
>+				case TerminalTokens.TokenNameassert:
>+				case TerminalTokens.TokenNameboolean:
>+				case TerminalTokens.TokenNamebreak:
>+				case TerminalTokens.TokenNamebyte:
>+				case TerminalTokens.TokenNamecase:
>+				case TerminalTokens.TokenNamecatch:
>+				case TerminalTokens.TokenNamechar:
>+				case TerminalTokens.TokenNameclass:
>+				case TerminalTokens.TokenNamecontinue:
>+				case TerminalTokens.TokenNamedefault:
>+				case TerminalTokens.TokenNamedo:
>+				case TerminalTokens.TokenNamedouble:
>+				case TerminalTokens.TokenNameelse:
>+				case TerminalTokens.TokenNameextends:
>+				case TerminalTokens.TokenNamefalse:
>+				case TerminalTokens.TokenNamefinal:
>+				case TerminalTokens.TokenNamefinally:
>+				case TerminalTokens.TokenNamefloat:
>+				case TerminalTokens.TokenNamefor:
>+				case TerminalTokens.TokenNameif:
>+				case TerminalTokens.TokenNameimplements:
>+				case TerminalTokens.TokenNameimport:
>+				case TerminalTokens.TokenNameinstanceof:
>+				case TerminalTokens.TokenNameint:
>+				case TerminalTokens.TokenNameinterface:
>+				case TerminalTokens.TokenNamelong:
>+				case TerminalTokens.TokenNamenative:
>+				case TerminalTokens.TokenNamenew:
>+				case TerminalTokens.TokenNamenull:
>+				case TerminalTokens.TokenNamepackage:
>+				case TerminalTokens.TokenNameprivate:
>+				case TerminalTokens.TokenNameprotected:
>+				case TerminalTokens.TokenNamepublic:
>+				case TerminalTokens.TokenNameshort:
>+				case TerminalTokens.TokenNamestatic:
>+				case TerminalTokens.TokenNamestrictfp:
>+				case TerminalTokens.TokenNamesuper:
>+				case TerminalTokens.TokenNameswitch:
>+				case TerminalTokens.TokenNamesynchronized:
>+				case TerminalTokens.TokenNamethis:
>+				case TerminalTokens.TokenNamethrow:
>+				case TerminalTokens.TokenNametransient:
>+				case TerminalTokens.TokenNametrue:
>+				case TerminalTokens.TokenNametry:
>+				case TerminalTokens.TokenNamevoid:
>+				case TerminalTokens.TokenNamevolatile:
>+				case TerminalTokens.TokenNamewhile:
>+					if (iToken == 0) {
>+						pushIdentifier(true, true);
>+						primitiveToken = token;
>+						consumeToken();
>+						break nextToken;
> 					}
>-					pushIdentifier(true, false);
>-					primitiveToken = token;
>-					consumeToken();
>-					break nextToken;
>+					// Fall through default case to verify that we do not leave on a dot
> 
> 				default :
> 					if (iToken == 0) {

Actions: View | Diff

Attachments on bug 231796: 100171