Attachment 99041 Details for Bug 230447 – Check for a Java nature before looking for the classpath

[patch] Check for a Java nature before looking for the classpath

230447.patch (text/plain), 2.02 KB, created by Ed Merks

on 2008-05-07 06:34:44 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ed Merks

Created: 2008-05-07 06:34:44 EDT

Size: 2.02 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.core
>Index: src/org/eclipse/pde/internal/core/builders/ExtensionsErrorReporter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/ExtensionsErrorReporter.java,v
>retrieving revision 1.29
>diff -u -r1.29 ExtensionsErrorReporter.java
>--- src/org/eclipse/pde/internal/core/builders/ExtensionsErrorReporter.java	29 Apr 2008 19:01:57 -0000	1.29
>+++ src/org/eclipse/pde/internal/core/builders/ExtensionsErrorReporter.java	7 May 2008 10:33:24 -0000
>@@ -526,8 +526,9 @@
> 	}
> 
> 	protected void validateJavaAttribute(Element element, Attr attr) {
>+		IProject project = fFile.getProject();
> 		String value = attr.getValue();
>-		IJavaProject javaProject = JavaCore.create(fFile.getProject());
>+		IJavaProject javaProject = JavaCore.create(project);
> 
> 		// be careful: people have the option to use the format:
> 		// fullqualifiedName:staticMethod
>@@ -539,9 +540,14 @@
> 		boolean onClasspath = true;
> 		int severity = CompilerFlags.getFlag(fProject, CompilerFlags.P_UNKNOWN_CLASS);
> 		if (severity != CompilerFlags.IGNORE) {
>-			onClasspath = PDEJavaHelper.isOnClasspath(value, javaProject);
>-			if (!onClasspath) {
>-				report(NLS.bind(PDECoreMessages.Builders_Manifest_class, (new String[] {value, attr.getName()})), getLine(element, attr.getName()), severity, PDEMarkerFactory.P_UNKNOWN_CLASS, element, attr.getName() + F_ATT_VALUE_PREFIX + attr.getValue(), PDEMarkerFactory.CAT_FATAL);
>+			try {
>+				if (project.hasNature(JavaCore.NATURE_ID)) {
>+					onClasspath = PDEJavaHelper.isOnClasspath(value, javaProject);
>+					if (!onClasspath) {
>+						report(NLS.bind(PDECoreMessages.Builders_Manifest_class, (new String[] {value, attr.getName()})), getLine(element, attr.getName()), severity, PDEMarkerFactory.P_UNKNOWN_CLASS, element, attr.getName() + F_ATT_VALUE_PREFIX + attr.getValue(), PDEMarkerFactory.CAT_FATAL);
>+					}
>+				}
>+			} catch (CoreException e) {
> 			}
> 		}
>

Actions: View | Diff

Attachments on bug 230447: 99041 | 99042 | 99075