Attachment 98885 Details for Bug 229453 – Mark missing plugins with the build.properties severity

[patch] Mark missing plugins with the build.properties severity

229453.patch (text/plain), 1.72 KB, created by Ed Merks

on 2008-05-06 12:43:24 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ed Merks

Created: 2008-05-06 12:43:24 EDT

Size: 1.72 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.core
>Index: src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java,v
>retrieving revision 1.34
>diff -u -r1.34 BuildErrorReporter.java
>--- src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java	11 Mar 2008 01:13:41 -0000	1.34
>+++ src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java	6 May 2008 16:40:17 -0000
>@@ -155,8 +155,6 @@
> 
> 		// validation not relying on build flag
> 		if (fClasspathSeverity != CompilerFlags.IGNORE) {
>-			if (jarsExtra != null)
>-				validateJarsExtraClasspath(jarsExtra);
> 			if (bundleList != null)
> 				validateDependencyManagement(bundleList);
> 		}
>@@ -165,6 +163,8 @@
> 		if (fBuildSeverity == CompilerFlags.IGNORE)
> 			return;
> 
>+		if (jarsExtra != null)
>+			validateJarsExtraClasspath(jarsExtra);
> 		validateIncludes(binIncludes, sourceEntryKeys);
> 		validateIncludes(binExcludes, sourceEntryKeys);
> 		validateIncludes(srcIncludes, sourceEntryKeys);
>@@ -307,7 +307,7 @@
> 				exists = projectPath.append(tokens[i]).toFile().exists();
> 
> 			if (!exists && !startsWithAntVariable(tokens[i])) {
>-				prepareError(PROPERTY_JAR_EXTRA_CLASSPATH, tokens[i], NLS.bind(PDECoreMessages.BuildErrorReporter_cannotFindJar, tokens[i]), PDEMarkerFactory.NO_RESOLUTION, fClasspathSeverity, PDEMarkerFactory.CAT_OTHER);
>+				prepareError(PROPERTY_JAR_EXTRA_CLASSPATH, tokens[i], NLS.bind(PDECoreMessages.BuildErrorReporter_cannotFindJar, tokens[i]), PDEMarkerFactory.NO_RESOLUTION, fBuildSeverity, PDEMarkerFactory.CAT_OTHER);
> 			}
> 		}
> 	}

Actions: View | Diff

Attachments on bug 229453: 98885 | 98941 | 98944