Attachment 9813 Details for Bug 31612 – patch to fix this bug

[patch] patch to fix this bug

fix-patch.txt (text/plain), 1.94 KB, created by Matthew Hatem

on 2004-04-21 21:39:32 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew Hatem

Created: 2004-04-21 21:39:32 EDT

Size: 1.94 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/internal/ViewFactory.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewFactory.java,v
>retrieving revision 1.21
>diff -u -r1.21 ViewFactory.java
>--- Eclipse UI/org/eclipse/ui/internal/ViewFactory.java	15 Apr 2004 19:04:56 -0000	1.21
>+++ Eclipse UI/org/eclipse/ui/internal/ViewFactory.java	22 Apr 2004 01:26:45 -0000
>@@ -383,7 +383,14 @@
> 	 * Returns whether a view with the given id exists.
> 	 */
> 	public boolean hasView(String id) {
>-	    return getView(id) != null;
>+	    return getView(id, null) != null;
>+	}
>+	
>+	/**
>+	 * Returns whether a view with the given ids exists.
>+	 */
>+	public boolean hasView(String id, String secondaryId) {
>+	    return getView(id, secondaryId) != null;
> 	}
> 	
> 	/**
>Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java,v
>retrieving revision 1.129
>diff -u -r1.129 WorkbenchPage.java
>--- Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java	15 Apr 2004 19:55:59 -0000	1.129
>+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java	22 Apr 2004 01:26:49 -0000
>@@ -1204,7 +1204,7 @@
> 			IViewReference ref = refs[i];
> 
> 			//If the part is no longer reference then dispose it.
>-			boolean exists = viewFactory.hasView(ref.getId());
>+			boolean exists = viewFactory.hasView(ref.getId(), ref.getSecondaryId());
> 			if (!exists) {
> 				firePartClosed(ref);
> 				activationList.remove(ref);
>@@ -1768,7 +1768,7 @@
> 		persp.hideView(ref);
> 
> 		// If the part is no longer reference then dispose it.
>-		boolean exists = viewFactory.hasView(ref.getId());
>+		boolean exists = viewFactory.hasView(ref.getId(), ref.getSecondaryId());
> 		if (!exists) {
> 			firePartClosed(ref);
> 			disposePart(ref);

Actions: View | Diff

Attachments on bug 31612: 9813