Attachment 90169 Details for Bug 196200 – Results and analysis from running JDT UI/refactoring tests on the patch

Results and analysis from running JDT UI/refactoring tests on the patch

binding-patch-report.txt (text/plain), 2.63 KB, created by Martin Aeschlimann

on 2008-02-20 07:15:36 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Aeschlimann

Created: 2008-02-20 07:15:36 EST

Size: 2.63 KB

patch

obsolete

>Running the JDT UI/Refactoring tests on the new patch (HEAD, 20.2.2008)
>
>10 test failures
>
>5 failures: changes to our tests required
>5 failures: should be fixed in the patch
>
>-------------------------
>Changes to our tests required:
>
>(more quick fix proposals thanks to the new bindings)
>
>UnresolvedTypesQuickFixTest.testTypeInMethodArguments
>UnresolvedTypesQuickFixTest.testTypeInMethodReturnType
>ConvertForLoopQuickFixTest.testCollectionTypeBindingIsNull()
>
>(refactoring works now better on code with compilation errors)
>
>ExtractMethodTests.test801()
>ExtractMethodTests.A_test802
>
>
>============================
>Should be fixed in the patch:
>
>
>UnresolvedTypesQuickFixTest.testArrayTypeInStatement():
>
>package aku.akutest;
>import java.io.*;		
>public class E {
>    void foo() {
>        Serializable[] v= new ArrayListExtra[10];
>    }
>}
>
>results in 2 compiler errors:
>
>E[105, 22] ArrayListExtra cannot be resolved to a type
>E[109, 14] ArrayListExtra cannot be resolved to a type
>
>should be one
>
>(use AST view to investigate)
>
>----------------------
>
>UnresolvedTypesQuickFixTest.testTypeInTypeArguments1()
>
>public class E<T> {
>    class SomeType { }
>    void foo() {
>        E<XYX> list= new E<SomeType>();
>    }
>}
>
>results in 2 compiler errors:
>
>E[75, 3] XYX cannot be resolved to a type
>E[86, 17] Type mismatch: cannot convert from E<E<T>.SomeType> to E<XYX>
>
>should be only one:
>E[75, 3] XYX cannot be resolved to a type
>
>------------------------
>
>org.eclipse.jdt.ui.tests.quickfix.UnresolvedTypesQuickFixTest.testTypeInTypeArguments2()
>
>package test1;
>import java.util.Map;
>public class E<T> {
>    static class SomeType { }
>    void foo() {
>        E<Map<String, ? extends XYX>> list= new E<Map<String, ? extends SomeType>>() {
>        };
>    }
>}
>
>results in 2 compiler errors:
>
>E[141, 3] XYX cannot be resolved to a type
>E[153, 53] Type mismatch: cannot convert from new E<Map<String,? extends E.SomeType>>(){} to E<Map<String,? extends XYX>>
>
>should be only one:
>E[141, 3] XYX cannot be resolved to a type
>
>---------------------------------
>
>ChangeSignatureTests.testGenerics02()
>ChangeSignatureTests.testGenerics03()
>
>Here we request an normal AST (no binding recovery) but still get (new) recovered binding:
>
>package test1;
>public class E1 {
>  void foo(  java.util.List<Vector> p0) {}
>}
>
>AST (no binding recovery)
>
>before:
>List: no binding
>Vector: no binding
>
>now:
>java.util.List: recovered binding: java.util.List<Vector>
>Vector: no binding
>
>
>It's an easy fix in our code (test for recovered bindings), but 
>I think it would be good to keep the old behaviour to not break clients.

Actions: View

Attachments on bug 196200: 83553 | 83825 | 83870 | 84003 | 84439 | 84626 | 85731 | 87237 | 88973 | 89990 | 90154 | 90169 | 90307 | 90374 | 90499 | 90846