Attachment 89357 Details for Bug 188330 – there is no need to escape special chars on Windows if the arguments are enclosed with double quotes

[patch] there is no need to escape special chars on Windows if the arguments are enclosed with double quotes

patch-188330.txt (text/plain), 2.31 KB, created by Radoslav Gerganov

on 2008-02-10 15:21:57 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Radoslav Gerganov

Created: 2008-02-10 15:21:57 EST

Size: 2.31 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.services.local
>Index: src/org/eclipse/rse/internal/services/local/files/LocalFileService.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/internal/services/local/files/LocalFileService.java,v
>retrieving revision 1.26
>diff -u -r1.26 LocalFileService.java
>--- src/org/eclipse/rse/internal/services/local/files/LocalFileService.java	7 Feb 2008 16:10:19 -0000	1.26
>+++ src/org/eclipse/rse/internal/services/local/files/LocalFileService.java	10 Feb 2008 20:17:58 -0000
>@@ -30,6 +30,7 @@
>  * Kevin Doyle		(IBM)		 - [208778] [efs][api] RSEFileStore#getOutputStream() does not support EFS#APPEND
>  * David McKnight   (IBM)        - [209593] [api] add support for "file permissions" and "owner" properties for unix files
>  * Radoslav Gerganov (ProSyst)   - [218173] [local] non-generic filters don't work
>+ * Radoslav Gerganov (ProSyst)   - [188330] Problems Copying files with $ in name
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.services.local.files;
>@@ -1263,9 +1264,12 @@
> //		 handle special characters in source and target strings 
> 		StringBuffer srcBuf = new StringBuffer(src);
> 		StringBuffer tgtBuf = new StringBuffer(target);
>-		handleSpecialChars(srcBuf);
>-		handleSpecialChars(tgtBuf);
>-		
>+		// there is no need to escape special chars on Windows,
>+		// if the arguments are enclosed with double quotes
>+		if (!isWindows()) {
>+  		handleSpecialChars(srcBuf);
>+  		handleSpecialChars(tgtBuf);
>+		}
> 		src = "\"" + srcBuf.toString() + "\""; //$NON-NLS-1$ //$NON-NLS-2$
> 		target = "\"" + tgtBuf.toString() + "\""; //$NON-NLS-1$ //$NON-NLS-2$
> 		/*
>@@ -1275,8 +1279,7 @@
> 		if (target.indexOf(' ') >= 0)
> 			target = "\"" + target + "\"";
> 		*/
>-		boolean isWindows = System.getProperty("os.name").toLowerCase().startsWith("win"); //$NON-NLS-1$ //$NON-NLS-2$
>-		if (isWindows)
>+		if (isWindows())
> 		{
> 			if (folderCopy)
> 			{
>@@ -1320,7 +1323,7 @@
> 		{
> 			Process p = null;
> 			Runtime runtime = Runtime.getRuntime();
>-			if (isWindows)
>+			if (isWindows())
> 			{
> 				String theShell = "cmd /C "; //$NON-NLS-1$
> 				p = runtime.exec(theShell + command);

Actions: View | Diff

Attachments on bug 188330: 89357 | 89388