Attachment 88859 Details for Bug 217735 – Proposed patch

[patch] Proposed patch

v00.txt (text/plain), 2.65 KB, created by Frederic Fusier

on 2008-02-05 02:15:36 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Fusier

Created: 2008-02-05 02:15:36 EST

Size: 2.65 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.test.performance
>Index: src/org/eclipse/test/internal/performance/db/DB.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.test.performance/src/org/eclipse/test/internal/performance/db/DB.java,v
>retrieving revision 1.71
>diff -u -r1.71 DB.java
>--- src/org/eclipse/test/internal/performance/db/DB.java	1 Feb 2008 17:17:44 -0000	1.71
>+++ src/org/eclipse/test/internal/performance/db/DB.java	4 Feb 2008 20:19:36 -0000
>@@ -321,12 +321,12 @@
>             //long l= System.currentTimeMillis();
>             int variation_id= fSQL.getVariations(variations);
>             int scenario_id= fSQL.getScenario(sample.getScenarioID());
>+			String comment= sample.getComment();
>             if (sample.isSummary()) {
>                 boolean isGlobal= sample.isGlobal();
>                 
>                 int commentId= 0;
>                 int commentKind= sample.getCommentType();
>-                String comment= sample.getComment();
>                 if (commentKind == Performance.EXPLAINS_DEGRADATION_COMMENT && comment != null)
>                 		commentId= fSQL.getCommentId(commentKind, comment);
>                 
>@@ -339,20 +339,13 @@
>                 String shortName= sample.getShortname();
>                 if (shortName != null)
>                     fSQL.setScenarioShortName(scenario_id, shortName);
>-            } else {
>-                
>+            } else if (comment != null) {
>                 int commentId= 0;
>                 int commentKind= sample.getCommentType();
>-                String comment= sample.getComment();
>-                if (commentKind == Performance.EXPLAINS_DEGRADATION_COMMENT && comment != null)
>-                		commentId= fSQL.getCommentId(commentKind, comment);
>-                
>-                Dimension[] summaryDimensions= sample.getSummaryDimensions();
>-                for (int i= 0; i < summaryDimensions.length; i++) {
>-                    Dimension dimension= summaryDimensions[i];
>-                    if (dimension instanceof Dim)
>-                        fSQL.createSummaryEntry(variation_id, scenario_id, 0/*invalid dim id*/, false, commentId);
>+                if (commentKind == Performance.EXPLAINS_DEGRADATION_COMMENT) {
>+                	commentId= fSQL.getCommentId(commentKind, comment);
>                 }
>+				fSQL.createSummaryEntry(variation_id, scenario_id, 0, false, commentId); // use special dim id '0' to identify summary entry created to only handle a comment
>             }
>             int sample_id= fSQL.createSample(variation_id, scenario_id, new Timestamp(sample.getStartTime()));
>

Actions: View | Diff

Attachments on bug 217735: 88859